From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Olivier Certner Newsgroups: gmane.emacs.bugs Subject: bug#62693: 28.2; VC: CVS: Fix lost file reporting and enable reverting it Date: Mon, 17 Apr 2023 22:10:02 +0200 Message-ID: <3969694.eEzTlFAC4L@ravel> References: <2029306.bkXEbi1Pq8@ravel> <2020915.n1Ql7ez4OO@ravel> <83a5z69z84.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7Bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10750"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 62693@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 17 22:11:31 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1poVCF-0002hV-4l for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 Apr 2023 22:11:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1poVBp-0002u4-Ne; Mon, 17 Apr 2023 16:11:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1poVBn-0002th-Cq for bug-gnu-emacs@gnu.org; Mon, 17 Apr 2023 16:11:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1poVBn-0005IX-5g for bug-gnu-emacs@gnu.org; Mon, 17 Apr 2023 16:11:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1poVBn-0001HI-13 for bug-gnu-emacs@gnu.org; Mon, 17 Apr 2023 16:11:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Olivier Certner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Apr 2023 20:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62693 X-GNU-PR-Package: emacs Original-Received: via spool by 62693-submit@debbugs.gnu.org id=B62693.16817622104817 (code B ref 62693); Mon, 17 Apr 2023 20:11:02 +0000 Original-Received: (at 62693) by debbugs.gnu.org; 17 Apr 2023 20:10:10 +0000 Original-Received: from localhost ([127.0.0.1]:56998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1poVAv-0001Fd-MW for submit@debbugs.gnu.org; Mon, 17 Apr 2023 16:10:10 -0400 Original-Received: from smtp2-g21.free.fr ([212.27.42.2]:29962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1poVAt-0001FL-RN for 62693@debbugs.gnu.org; Mon, 17 Apr 2023 16:10:08 -0400 Original-Received: from ravel.localnet (unknown [90.118.140.172]) (Authenticated sender: ocert.dev@free.fr) by smtp2-g21.free.fr (Postfix) with ESMTPSA id 6C1942003E3; Mon, 17 Apr 2023 22:10:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1681762205; bh=VdQdDPo/edOrm9IZW++QquPIfssAPeQ6fySnI8zDULs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=putnq+XKweC0k2oBIIs6345fejg6R2LlPlO5OXgQSnmDVqovVDdKpUROFj/QVNj5o IBT31qeCecXIKQr6fpPMYun8DxqvCdmKzx9b+Rc3iZqbCosfbZoNy7WfTeECMwIsoY eS56mbrbcKmr27SzGoCbCe7ZqwquCn91zBIMyZzxyL5ueVjjxtD6ywYvC78Gk322eL i9/Tngp0mfgtsgIhbR37Oc7b9Jgns2VYFyXDjfrZK+KIOoUrh5Y2y4ZF+blHWxoLO2 nu8lmQMfE6vcWZ3IjWUxgAT7GIjKsYVemXXlFoLWTli64frT5mFTbv3KgFDrxmWRBp q89mrr5fuIqtA== In-Reply-To: <83a5z69z84.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260195 Archived-At: Hi, > I should have said "non-trivial". Sorry for potentially confusing > selection of words. Non-trivial certainly, but not that complex either (and this thanks to the style used). And, as importantly, this is a component with very delimited and clear functionality and interface, making it simple to reason about from the outside (and this has not been changed by the patch) and see the impacts, especially with a single chain of callers. > Dmitry asked whether it was okay to install this on the release > branch, which is currently undergoing pretest. So I looked at the > changes from the POV of the potential for unintended consequences and > regressions. This job is much harder when the code is thoroughly > rewritten, let alone uses a different macro system and style. That is > why I asked the question: I presume that if the changes were less > radical, they could perhaps have been deemed appropriate for the > release branch, or at least the chances for that were higher. That I can perfectly understand, even if my take would probably be different. That said, I've re-read your mail and it really comes out very differently without such context. So at least thanks for providing it. > You didn't have to. That's not why I asked the question. You didn't state the underpinnings, and were apparently adressing to me, not Dmitry, in the rest of the mail, so this is what I inferred for the first paragraph as well. Which then made me lose some time (and subsequently temper), and perhaps made you as well. Proper, transparent communication is key here. > Not really, but that's a minor point. We can always fix the > terminology later. So I guess this means that I'll leave it to you to possibly change names later. Given the previous miscommunication, let me explicitly invite you to manifest yourself if my guess is wrong and you are expecting something else from me on this topic. Thanks. -- Olivier Certner