From: Bozhidar Batsov <bozhidar@batsov.com>
To: 16182@debbugs.gnu.org, Gutov Dmitry <dgutov@yandex.ru>
Cc: Steve Purcell <steve@sanityinc.com>,
Adam Sokolnicki <adam.sokolnicki@gmail.com>
Subject: bug#16182: Acknowledgement (24.3.50; ruby-mode: Indentation style of multiline literals with hanging open paren inside other parens)
Date: Thu, 19 Dec 2013 14:54:56 +0200 [thread overview]
Message-ID: <395424D4599947EBA14047DBA9440BB1@gmail.com> (raw)
In-Reply-To: <1E72CA8B046B46A6B320EBB9A71FF8CA@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2634 bytes --]
I can confirm that your method args indentation fix is working. I did, however, notice the following problem after I mentioned the if/unless/case with assignment indentation. Consider the following:
res = method do |x, y|
something
end
Might make sense to indent those like:
res = method do |x, y|
something
end
for consistency with the if/unless/case indentation by default. Also:
res =
method do |x, y|
something
end
is actually indented like this:
res =
method do |x, y|
something
end
--
Cheers,
Bozhidar
On Thursday, December 19, 2013 at 11:08 AM, Bozhidar Batsov wrote:
> On Thursday, December 19, 2013 at 6:35 AM, Dmitry Gutov wrote:
> > Bozhidar Batsov <bozhidar@batsov.com (mailto:bozhidar@batsov.com)> writes:
> >
> > > Personally I dislike this style, because you’re basically it obscures
> > > the semantics of the method arguments, but I acknowledge that I’ve
> > > seen it the wild.
> > >
> >
> >
> > Ok, that's a -1, then.
> >
> > > For me it would be more beneficial if we supported a
> > > variant of the style:
> > >
> > > methods.each do |method|
> > > route_set.add_route(
> > > self, {
> > > path_info: route.route_compiled,
> > > request_method: method,
> > > }, route_info: route
> > > )
> > > end
> > >
> >
> >
> > Should work now, with revision 115602.
> >
> > > Something that’s not mentioned here, but it’s a bigger problem for the
> > > users is probably the fact that we don’t support the following
> > > indentation style:
> > >
> > > x = if something
> > > do_something
> > > end
> > >
> > > Even if I don’t use and (and the majority of Ruby hackers AFAIK) it’s
> > > still fairly popular.
> > >
> >
> >
> > It's actually easy to do now, but the old engine doesn't support that
> > either. That should be takes as evidence that Emacs Rubyists don't care
> > about this variant much (I didn't see it in feature requests either).
> >
> > So I'd rather wait for a request from someone who actually would use it.
> > If you'd like to add it now, please propose the name of the user option.
> >
> >
> >
>
> I recall seeing StackOverflow questions about this in Emacs, but as I neither practice nor promote this style I’m indifferent to supporting it in Emacs. I do, however, support it in RuboCop (https://github.com/bbatsov/rubocop/issues/661). If we decide to have it in Emacs we might use a similar name for the config variable - `ruby-end-alignment’ with two options - ‘keword and ‘assignment.
>
[-- Attachment #2: Type: text/html, Size: 4608 bytes --]
next prev parent reply other threads:[~2013-12-19 12:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 3:55 bug#16182: 24.3.50; ruby-mode: Indentation style of multiline literals with hanging open paren inside other parens Dmitry Gutov
[not found] ` <handler.16182.B.138733895212351.ack@debbugs.gnu.org>
2013-12-18 4:05 ` bug#16182: Acknowledgement (24.3.50; ruby-mode: Indentation style of multiline literals with hanging open paren inside other parens) Dmitry Gutov
2013-12-18 10:31 ` Bozhidar Batsov
2013-12-19 4:35 ` Dmitry Gutov
2013-12-19 9:08 ` Bozhidar Batsov
2013-12-19 12:54 ` Bozhidar Batsov [this message]
2013-12-19 17:15 ` Dmitry Gutov
2013-12-19 20:33 ` Bozhidar Batsov
2013-12-19 20:42 ` Steve Purcell
2013-12-20 5:21 ` Dmitry Gutov
2013-12-20 9:51 ` Bozhidar Batsov
2013-12-20 11:57 ` Dmitry Gutov
2013-12-20 15:46 ` Bozhidar Batsov
2013-12-21 15:31 ` Dmitry Gutov
2013-12-21 15:38 ` Steve Purcell
2013-12-21 15:53 ` Dmitry Gutov
2013-12-21 16:49 ` Steve Purcell
2013-12-21 19:32 ` Adam Doppelt
2013-12-22 2:01 ` Dmitry Gutov
2013-12-19 13:47 ` Dmitry Gutov
2013-12-18 12:42 ` bug#16182: 24.3.50; ruby-mode: Indentation style of multiline literals with hanging open paren inside other parens Stefan Monnier
2013-12-19 4:57 ` Dmitry Gutov
2013-12-19 13:47 ` Stefan Monnier
2013-12-18 17:57 ` bug#16182: Adam Sokolnicki
2013-12-19 4:48 ` bug#16182: Dmitry Gutov
2013-12-19 18:39 ` bug#16182: Adam Doppelt
2013-12-20 12:44 ` bug#16182: Adam Sokolnicki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=395424D4599947EBA14047DBA9440BB1@gmail.com \
--to=bozhidar@batsov.com \
--cc=16182@debbugs.gnu.org \
--cc=adam.sokolnicki@gmail.com \
--cc=dgutov@yandex.ru \
--cc=steve@sanityinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).