From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#62043: [PATCH] Fix enums appearing as structs in c-ts-base-mode's imenu Date: Thu, 9 Mar 2023 21:59:49 -0800 Message-ID: <394FE8AD-FAB3-4244-BD16-2D2014DAF2B0@gmail.com> References: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37787"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62043@debbugs.gnu.org To: Randy Taylor Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 10 07:01:41 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1paVoy-0009az-Ic for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Mar 2023 07:01:40 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1paVoS-0004RC-19; Fri, 10 Mar 2023 01:01:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paVoM-0004Qo-RQ for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2023 01:01:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1paVoM-00017G-JW for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2023 01:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1paVoM-0003Xb-1F for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2023 01:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Mar 2023 06:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62043 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62043-submit@debbugs.gnu.org id=B62043.167842801113535 (code B ref 62043); Fri, 10 Mar 2023 06:01:01 +0000 Original-Received: (at 62043) by debbugs.gnu.org; 10 Mar 2023 06:00:11 +0000 Original-Received: from localhost ([127.0.0.1]:53472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1paVnX-0003WE-7O for submit@debbugs.gnu.org; Fri, 10 Mar 2023 01:00:11 -0500 Original-Received: from mail-pj1-f41.google.com ([209.85.216.41]:43666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1paVnU-0003UY-Mr for 62043@debbugs.gnu.org; Fri, 10 Mar 2023 01:00:09 -0500 Original-Received: by mail-pj1-f41.google.com with SMTP id y15-20020a17090aa40f00b00237ad8ee3a0so4210399pjp.2 for <62043@debbugs.gnu.org>; Thu, 09 Mar 2023 22:00:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678428001; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HnyEbD33rAaC4KU0WtYYooOAv8wwepnSY35Gb8KpkZI=; b=WOJBIf3HnnuHO8HLc9DbfqyF9vumoreNhWfrSMCUXe6OQIuNlGNjwxzt9VWk+0lq1/ vDOrFQ7FJI4HRy9+qZX5IRGDR1a6upXRu/xZ1d9rwOrTLCdjzd4l6d5u6tODZN1WkD61 8rqlTUBFhR8lVeH/7N/98qKLpr2l3YmK2UOVPCGM7se7Fa1fA8oftFhSEioy76ddsIvZ s4VQvjbWcogHNtjQuHyScJ0U0hUZYLQtPNLMvPPHSnKdvjUG74nw3gY7SGXv+pb/ihta Zbu3DEtQPYuVVcl1B0rbM1m/wuOHmUD/YRQZU73jhJxfV84BoUpsVu4A0olZzHS94rXT pygw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678428001; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HnyEbD33rAaC4KU0WtYYooOAv8wwepnSY35Gb8KpkZI=; b=C1L+kGhn7o76E/gnNjggTmVYMY+db3pxA4JhaDyWfIJxeMyh7Sd37iimAfoQQLviho qRE0R5CJhei1wjlWOS7UMcVFRYaSgA74+Xfapyl4OmRuvxyLDsafW3QVaN04ANWilBpl D43h625RRWkNaKiDFrVReZsw965TPBiIYXQBU730Z5GbIsHbKaHiFwOuy/ZjD213HCQy w5uXD+l0DlN0LMsYtR/LbRtgG97qKAHacacIg/utpj6GkUOAHbXKpcsZnN3B71Yfud30 w6wnUgOAcDjZgbYq5W4fafl1iJJYYmHYDPcjQ2P1SOdZeYuEHp9eXQ1LYX574/85FAhA QiIA== X-Gm-Message-State: AO0yUKXRsHKWmz0ecVlGSl+dhKn+cQzAttf0Knob4kFQ0HJCnyKSx63c +JTzZmtdf9SRp3o/47iyTWM= X-Google-Smtp-Source: AK7set/d9brWqjAV44Y9kDZSIViwOTLM0qAmG0HmYoDxecQCHUVLbGv2UAbsxReFCU8XpAqBie4/Sw== X-Received: by 2002:a05:6a20:8413:b0:cc:6699:dd8a with SMTP id c19-20020a056a20841300b000cc6699dd8amr31107330pzd.45.1678428001451; Thu, 09 Mar 2023 22:00:01 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id j26-20020aa78d1a000000b00593e5a45ce7sm551657pfe.173.2023.03.09.22.00.00 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Mar 2023 22:00:01 -0800 (PST) In-Reply-To: X-Mailer: Apple Mail (2.3731.400.51.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257649 Archived-At: > On Mar 8, 2023, at 6:04 PM, Randy Taylor wrote: >=20 > On Wednesday, March 8th, 2023 at 18:27, Yuan Fu = wrote: >>=20 >>> On Mar 7, 2023, at 5:49 PM, Randy Taylor dev@rjt.dev wrote: >>>=20 >>> X-Debbugs-CC: casouri@gmail.com >>>=20 >>> With {c, c++}-ts-mode, enums appear as structs in imenu. The = attached patch fixes this. >>>=20 >>> Example: >>> enum Thing { A, B, C }; >>>=20 >>> Should appear as Enum Thing >>> <0001-Fix-enums-appearing-as-structs-in-c-ts-base-mode-s-i.patch> >>=20 >>=20 >> Thanks! I wonder what determines which categories to merge together = and which to not? If we separate Enums, should we also separate Unions? >>=20 >> Yuan >=20 > I think they should all be separate actually. Attached a patch that = does = so.<0001-Fix-enums-and-unions-appearing-as-structs-in-c-ts-ba.patch> That=E2=80=99s probably the right thing to do. I applied the patch, = thanks! Yuan