From: Yuan Fu <casouri@gmail.com>
To: Randy Taylor <dev@rjt.dev>
Cc: 62043@debbugs.gnu.org
Subject: bug#62043: [PATCH] Fix enums appearing as structs in c-ts-base-mode's imenu
Date: Thu, 9 Mar 2023 21:59:49 -0800 [thread overview]
Message-ID: <394FE8AD-FAB3-4244-BD16-2D2014DAF2B0@gmail.com> (raw)
In-Reply-To: <UnskLUv6MSBcs1-A0AIgBSosn3r3LKBlPajlJt4UNjmR7Y1KDwp3kcC3wyWzv2XLNZeiTmc18jt-m0wFNdPGj2VEA4BDLvyxiBw46Srvah8=@rjt.dev>
> On Mar 8, 2023, at 6:04 PM, Randy Taylor <dev@rjt.dev> wrote:
>
> On Wednesday, March 8th, 2023 at 18:27, Yuan Fu <casouri@gmail.com> wrote:
>>
>>> On Mar 7, 2023, at 5:49 PM, Randy Taylor dev@rjt.dev wrote:
>>>
>>> X-Debbugs-CC: casouri@gmail.com
>>>
>>> With {c, c++}-ts-mode, enums appear as structs in imenu. The attached patch fixes this.
>>>
>>> Example:
>>> enum Thing { A, B, C };
>>>
>>> Should appear as Enum Thing
>>> <0001-Fix-enums-appearing-as-structs-in-c-ts-base-mode-s-i.patch>
>>
>>
>> Thanks! I wonder what determines which categories to merge together and which to not? If we separate Enums, should we also separate Unions?
>>
>> Yuan
>
> I think they should all be separate actually. Attached a patch that does so.<0001-Fix-enums-and-unions-appearing-as-structs-in-c-ts-ba.patch>
That’s probably the right thing to do. I applied the patch, thanks!
Yuan
next prev parent reply other threads:[~2023-03-10 5:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 1:49 bug#62043: [PATCH] Fix enums appearing as structs in c-ts-base-mode's imenu Randy Taylor
2023-03-08 23:27 ` Yuan Fu
2023-03-09 2:04 ` Randy Taylor
2023-03-10 5:59 ` Yuan Fu [this message]
2023-03-10 18:16 ` Randy Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=394FE8AD-FAB3-4244-BD16-2D2014DAF2B0@gmail.com \
--to=casouri@gmail.com \
--cc=62043@debbugs.gnu.org \
--cc=dev@rjt.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).