From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#66211: 30.0.50; C-x v v in vc-diff does not work with lesser versionf of patch Date: Fri, 29 Sep 2023 21:11:26 +0300 Message-ID: <3949ad53-045d-b012-fc02-e3dee9f683c9@gutov.dev> References: <83h6nd1msw.fsf@gnu.org> <78f8becb-7150-33cb-537c-47728b305699@gutov.dev> <835y3typge.fsf@gnu.org> <1e1f0e18-1fe2-4bb4-38f3-1c49de831abc@gutov.dev> <831qegc1yw.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23715"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: ams@gnu.org, 66211@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 29 20:12:07 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qmHyA-0005mr-1Z for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 Sep 2023 20:12:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qmHxt-0005Rz-Tb; Fri, 29 Sep 2023 14:11:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qmHxs-0005Rm-7A for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2023 14:11:48 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qmHxr-0000L7-VL for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2023 14:11:47 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qmHy6-0003rd-7y for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2023 14:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Sep 2023 18:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66211 X-GNU-PR-Package: emacs Original-Received: via spool by 66211-submit@debbugs.gnu.org id=B66211.169601111214833 (code B ref 66211); Fri, 29 Sep 2023 18:12:02 +0000 Original-Received: (at 66211) by debbugs.gnu.org; 29 Sep 2023 18:11:52 +0000 Original-Received: from localhost ([127.0.0.1]:57178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmHxw-0003rA-36 for submit@debbugs.gnu.org; Fri, 29 Sep 2023 14:11:52 -0400 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:52259) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmHxt-0003qo-Cv for 66211@debbugs.gnu.org; Fri, 29 Sep 2023 14:11:50 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 56A8C5C00E1; Fri, 29 Sep 2023 14:11:29 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 29 Sep 2023 14:11:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1696011089; x=1696097489; bh=jTcjD3wIS9V5AwRH0IvuS+Crdqm+tATS5VF S7JwyVRs=; b=EHmmkW6BxKjxqhTtKhdMBDu+9xnPMJ4Gm36mCQ0bPVpktAS4bDV qMUo28yk5uNYGGRG0aGQLvZZhWzYY98odIVf1fQgC2xKpDrF7Gf2bn5K1UBc9iRI f67iznhqaEx3tAM/mQSkdW8pVVM8LJrUrZLDq4uONDyHGfHzrwsgUa7hzVj8cECV Hr1E8UhiB2KVhdW/72YGgR5EPlW/lxuYujv2cTBoVVnX5WC5go0pz02eygtShmBn PyqY9p/y6fMNi9j2DqY962EkG8k8qxy6nbLcPDkHU42KLDILS9TlOBgcmC+EvbLv M5uMhXVp5H/9w7ZdqJ9yhkvZ0e/ffACHOWQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1696011089; x=1696097489; bh=jTcjD3wIS9V5AwRH0IvuS+Crdqm+tATS5VF S7JwyVRs=; b=gA3JQtVdIvlj3cltET8eEHKptuIrpE6CSxYNbT7bcf3JW71GCNp hSRgYNm+rtZjoPQ5cGoGy5jbXKCK7EilyFi7E6CbZBIpY/yHR7BwPOrkHGl1g7v4 wlaSZImCo7O1rvHKHvT58CK4ybxttNZQiFzP9764ABJok+mdpnnpwY5L4Ia7N3Rj GrvoHNTr4reopnKf4q7HxqIX5yJUr/SzmC5z+6q7HWjabf5sc8EeVESMRv4FOhXU KRpkQ0/14UjvK6EsoT/bSqA1RRgGzl+DmseG1eUEqERKIyhw/ka+BcYkUjlyNoHI zrEVcTypC2DWQutq43A4Y9NCLJS29GciCtw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrtddvgdduvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhephfeutdekveeggeetteekfeejffegudduudfhueevleeftdffffeggeeivddv jeelnecuffhomhgrihhnpehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 29 Sep 2023 14:11:27 -0400 (EDT) Content-Language: en-US In-Reply-To: <831qegc1yw.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271522 Archived-At: On 29/09/2023 20:40, Eli Zaretskii wrote: >> Date: Fri, 29 Sep 2023 20:27:21 +0300 >> Cc: ams@gnu.org, 66211@debbugs.gnu.org >> From: Dmitry Gutov >> >> On 29/09/2023 18:22, Eli Zaretskii wrote: >>>> vc-default-checkin-patch calls 'patch'. It's for other backends. >>> >>> Why do we call Patch if we have a way to apply hunks in Lisp? Wasn't >>> that just discussed in the other thread? >> >> https://lists.gnu.org/archive/html/emacs-devel/2022-10/msg01353.html > > That doesn't have a lot in the way of answering my question above. The discussion regarding that choice is inside the quotes' ladder in that message. >> Anyway, it doesn't seem like 'patch' itself is the problem in this case: > > When Patch is installed, sure. But using our own code is better > because it doesn't need Patch and doesn't have to rely on specific > options it may or may not support. > > I'm not insisting, mind you, just asking. It sounds inconsistent with > what we do in similar situations in other places, that's all. My preference was to limit the number of points of unreliability. And/or minor differences (e.g. whether file removals are supported). 'diff-apply-buffer' has only been checked in, we can revisit this a little later, after more testing and stuff.