From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.bugs Subject: bug#54606: 27.1; next/previous image command in image-mode triggers tramp connections for all remote dired buffers Date: Mon, 28 Mar 2022 23:13:14 +1300 Message-ID: <3947f11808243544dcdd4e4d2fde4922@webmail.orcon.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32098"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Orcon Webmail To: 54606@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 28 12:14:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nYmO8-0008Dd-2m for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Mar 2022 12:14:16 +0200 Original-Received: from localhost ([::1]:45030 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nYmO6-0000Dr-IP for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Mar 2022 06:14:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44482) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYmNv-0000Bn-5I for bug-gnu-emacs@gnu.org; Mon, 28 Mar 2022 06:14:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35217) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nYmNu-0007qs-TA for bug-gnu-emacs@gnu.org; Mon, 28 Mar 2022 06:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nYmNu-0000Pp-J8 for bug-gnu-emacs@gnu.org; Mon, 28 Mar 2022 06:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Mar 2022 10:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 54606 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16484624191557 (code B ref -1); Mon, 28 Mar 2022 10:14:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 28 Mar 2022 10:13:39 +0000 Original-Received: from localhost ([127.0.0.1]:57347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nYmNW-0000P3-Dq for submit@debbugs.gnu.org; Mon, 28 Mar 2022 06:13:39 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:42904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nYmNU-0000Ov-7E for submit@debbugs.gnu.org; Mon, 28 Mar 2022 06:13:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44336) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYmNU-0000BE-3C for bug-gnu-emacs@gnu.org; Mon, 28 Mar 2022 06:13:36 -0400 Original-Received: from smtp-3.orcon.net.nz ([60.234.4.44]:35629) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYmNP-0007le-7M for bug-gnu-emacs@gnu.org; Mon, 28 Mar 2022 06:13:35 -0400 Original-Received: from [10.253.37.70] (port=48266 helo=webmail.orcon.net.nz) by smtp-3.orcon.net.nz with esmtpa (Exim 4.90_1) (envelope-from ) id 1nYmN9-0004Xs-2m for bug-gnu-emacs@gnu.org; Mon, 28 Mar 2022 23:13:16 +1300 Original-Received: from ip-139-180-65-103.kinect.net.nz ([139.180.65.103]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Mon, 28 Mar 2022 23:13:14 +1300 X-Sender: psainty@orcon.net.nz X-GeoIP: -- Received-SPF: pass client-ip=60.234.4.44; envelope-from=psainty@orcon.net.nz; helo=smtp-3.orcon.net.nz X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229005 Archived-At: In 27.1 this code is in `image-next-file'. In master it's now `image-mode--directory-buffers', but the relevant code looks the same: ;; Find a dired buffer. (dolist (buffer (buffer-list)) (with-current-buffer buffer (when (and (derived-mode-p 'dired-mode) (equal (file-truename dir) (file-truename default-directory))) That call to (file-truename default-directory) for each dired buffer can cause tramp to spin up for closed connections for entirely irrelevant dired buffers. Can we put some guards in there to decide whether or not dir and default-directory are actually on the same host before comparing them via file-truename? -Phil (who is simply testing (not (file-remote-p default-directory)) as an interim fix) In GNU Emacs 27.1 (build 2, x86_64-pc-linux-gnu, X toolkit, Xaw scroll bars) of 2020-08-20 built on mts-devtools Windowing system distributor 'The X.Org Foundation', version 11.0.12008000 System Description: Ubuntu 18.04.3 LTS Recent messages: Copying /tmp/tramp.XFX7Dz.elcNyCbqo to /sudo:root@mts-devtools:/usr/local/share/emacs/27.1/lisp/image-mode.elcNyCbqo...done Renaming /sudo:root@mts-devtools:/usr/local/share/emacs/27.1/lisp/image-mode.elcNyCbqo to /sudo:root@mts-devtools:/usr/local/share/emacs/27.1/lisp/image-mode.elc...done Wrote /sudo:root@mts-devtools:/usr/local/share/emacs/27.1/lisp/image-mode.elc Wrote /sudo:root@mts-devtools:/usr/local/share/emacs/27.1/lisp/image-mode.{el,elc} Making completion list... Loading /sudo:root@mts-devtools:/usr/local/share/emacs/27.1/lisp/image-mode.elc... Copying /sudo:root@mts-devtools:/usr/local/share/emacs/27.1/lisp/image-mode.elc to /tmp/tramp.vr7HOL.elc...done Loading /sudo:root@mts-devtools:/usr/local/share/emacs/27.1/lisp/image-mode.elc...done Hunk already applied Mark set [2 times] Configured using: 'configure --with-x-toolkit=lucid --without-sound' Configured features: XPM JPEG TIFF GIF PNG RSVG DBUS GSETTINGS GLIB NOTIFY INOTIFY GNUTLS LIBXML2 FREETYPE HARFBUZZ XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 XDBE XIM MODULES THREADS PDUMPER LCMS2 GMP Important settings: value of $LC_MONETARY: en_NZ.UTF-8 value of $LC_NUMERIC: en_NZ.UTF-8 value of $LC_TIME: en_NZ.UTF-8 value of $LANG: en_NZ.UTF-8 locale-coding-system: utf-8 Major mode: Emacs-Lisp Minor modes in effect: hi-lock-mode: t global-magit-file-mode: t goto-address-prog-mode: t elisp-slime-nav-mode: t hl-sexp-mode: t lexbind-mode: t idle-highlight-mode: t minibuffer-line-mode: t global-edit-server-edit-mode: t savehist-mode: t magit-wip-before-change-mode: t magit-wip-after-apply-mode: t magit-wip-after-save-mode: t global-git-commit-mode: t magit-auto-revert-mode: t shell-dirtrack-mode: t async-bytecomp-package-mode: t my-contextual-help-mode: t global-so-long-mode: t show-paren-mode: t my-visible-bell-mode: t cua-mode: t global-display-fill-column-indicator-mode: t display-fill-column-indicator-mode: t minibuffer-depth-indicate-mode: t which-key-mode: t winner-mode: t global-subword-mode: t subword-mode: t global-hl-line-mode: t hl-line-mode: t display-time-mode: t keep-buffers-mode: t fic-mode: t my-keys-local-minor-mode: t auto-compile-on-load-mode: t auto-compile-on-save-mode: t auto-compile-mode: t url-handler-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t column-number-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: /home/vagrant/.emacs.d/el-get/scratch/el-get hides /home/vagrant/.emacs.d/el-get/el-get/el-get /home/vagrant/.emacs.d/my-lisp/so-long hides /usr/local/share/emacs/27.1/lisp/so-long /home/vagrant/.emacs.d/lisp/python hides /usr/local/share/emacs/27.1/lisp/progmodes/python Features: (shadow emacsbug sendmail tramp-adb tramp-archive tramp-ftp tramp-gvfs edebug image-file dabbrev image-dimensions-minor-mode image-mode exif mhtml-mode debug backtrace magit-ediff calc-alg calc-ext calc-menu calc calc-loaddefs calc-macs find-file diff-hl-flydiff diff-hl vc-dir ewoc flyspell sockit web-mode rfc2104 tramp-cmds wdired nroff-mode sort align tramp-sh repeat ispell css-mode sgml-mode git-rebase js hippie-exp log-view ediff ediff-merg ediff-mult ediff-wind ediff-diff ediff-help ediff-init ediff-util magit-submodule cua-rect vc-annotate vc vc-dispatcher markdown-mode mail-extr magit-extras shr-color color url-file url-dired adaptive-wrap eww mm-url gnus nnheader url-queue shr svg dom php-local-manual bug-reference gitconfig-mode conf-mode compare-w mm-archive gnutls network-stream url-cache url-dav wgrep find-dired ido find-file-in-project etags-select sh-script ruby-mode smie face-remap two-column iso-transl php-extras-eldoc-functions sql-upcase sql view php-eldoc my-drupal grep scroll-lock drush-php psysh php-mode mode-local cc-langs php-face php php-project flymake-proc flymake cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs docker-tramp tramp-cache tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat parse-time iso8601 ls-lisp pp cl-print mule-util imenu man term disp-table ehelp warnings winnow compile eieio-opt speedbar sb-image ezimage dframe loadhist ibuf-ext ibuffer ibuffer-loaddefs help-fns hi-lock misearch multi-isearch executable finder finder-inf find-func skeleton dired-aux magit-obsolete magit-blame magit-stash magit-bisect magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-collab ghub url-http url-gw nsm url-auth url url-proxy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap let-alist magit-files magit-refs magit-status magit magit-repos magit-apply autoinsert goto-addr project-local-variables elisp-slime-nav etags fileloop generator xref project hl-sexp lexbind-mode idle-highlight-mode rx tabify minibuffer-line edit-server my-org my-projects my-session savehist desktop frameset my-theme zenburn-theme my-mail autoloads my-libraries sudo my-version-control magit-wip magit-log magit-diff smerge-mode diff git-commit log-edit message rmc puny rfc822 mml mml-sec epa epg epg-config gnus-util rmail rmail-loaddefs text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log magit-core magit-autorevert autorevert filenotify magit-process with-editor shell pcomplete comint server ansi-color magit-margin magit-mode magit-git magit-section magit-utils crm magit-popup pcase async-bytecomp async format-spec dash my-text my-programming my-python so-long my-whitespace ws-trim my-rectangles my-utilities browse-kill-ring my-configuration cus-edit cus-start cus-load wid-edit dired-details dired-x highlight-parentheses paren url-privacy delight delsel cua-base ffap display-fill-column-indicator mb-depth which-key framemove windmove winner ring cap-words superword subword hl-line time my-externals .loaddefs windcycle transpose-frame simple-wiki derived sdcv-mode noutline outline sauron rainbow-mode notify dbus xml multiple-cursors mc-separate-operations rectangular-region-mode mc-mark-pop mc-mark-more thingatpt mc-cycle-cursors mc-edit-lines multiple-cursors-core rect mo-git-blame keep-buffers iedit fic-mode dtrt-indent browse-at-remote vc-git diff-mode easy-mmode s el-get cl-extra help-mode autoload radix-tree lisp-mnt cl dired dired-loaddefs my-elpa my-local my-keybindings edmacro kmacro jka-compr auto-compile packed etags-select-autoloads info project-local-variables-autoloads advice wtf-autoloads package easymenu browse-url url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 6395697 774980) (symbols 48 99712 1) (strings 32 264602 49924) (string-bytes 1 13742442) (vectors 16 478511) (vector-slots 8 5272375 517538) (floats 8 2334 4710) (intervals 56 1397671 5095) (buffers 1000 1327))