From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: mituharu@math.s.chiba-u.ac.jp Newsgroups: gmane.emacs.bugs Subject: bug#38774: crash in image_pix_context_get_pixel Date: Mon, 30 Dec 2019 15:10:40 +0900 Message-ID: <393824cdb46651a2b3b9128ca3683c1e.squirrel@weber.math.s.chiba-u.ac.jp> References: Mime-Version: 1.0 Content-Type: text/plain;charset=iso-2022-jp Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="184793"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: SquirrelMail/1.4.22-5.el6 To: "Madhu" , 38774@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 30 07:11:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iloGp-000lsN-UN for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Dec 2019 07:11:16 +0100 Original-Received: from localhost ([::1]:58772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iloGj-0006D5-Jh for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Dec 2019 01:11:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46155) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iloGd-0006Cy-Nc for bug-gnu-emacs@gnu.org; Mon, 30 Dec 2019 01:11:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iloGc-0007qw-Lg for bug-gnu-emacs@gnu.org; Mon, 30 Dec 2019 01:11:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54486) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iloGc-0007nE-H0 for bug-gnu-emacs@gnu.org; Mon, 30 Dec 2019 01:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iloGc-0002PS-DG for bug-gnu-emacs@gnu.org; Mon, 30 Dec 2019 01:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: mituharu@math.s.chiba-u.ac.jp Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Dec 2019 06:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38774 X-GNU-PR-Package: emacs Original-Received: via spool by 38774-submit@debbugs.gnu.org id=B38774.15776862479242 (code B ref 38774); Mon, 30 Dec 2019 06:11:02 +0000 Original-Received: (at 38774) by debbugs.gnu.org; 30 Dec 2019 06:10:47 +0000 Original-Received: from localhost ([127.0.0.1]:60459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iloGM-0002P0-SR for submit@debbugs.gnu.org; Mon, 30 Dec 2019 01:10:47 -0500 Original-Received: from mathmail.math.s.chiba-u.ac.jp ([133.82.132.2]:50454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iloGK-0002N2-9e for 38774@debbugs.gnu.org; Mon, 30 Dec 2019 01:10:45 -0500 Original-Received: from weber.math.s.chiba-u.ac.jp (weber [192.168.32.4]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 3D7F5F08D5; Mon, 30 Dec 2019 15:10:40 +0900 (JST) (envelope-from mituharu@math.s.chiba-u.ac.jp) Original-Received: from 153.216.236.73 (SquirrelMail authenticated user mituharu) by weber.math.s.chiba-u.ac.jp with HTTP; Mon, 30 Dec 2019 15:10:40 +0900 In-Reply-To: X-Priority: 3 (Normal) Importance: Normal X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173921 Archived-At: >> >> Recent emacs configured with >> >> configure -C --without-all --with-xml2 --with-dbus --with-m17n-flt >> --with-libotf --with-xft --with-x-toolkit=athena >> --with-toolkit-scroll-bars --with-xaw3d --with-cairo --with-harfbuzz >> --with-png >> >> crashes on startup > > Could you try the patch below? > > YAMAMOTO Mitsuharu > mituharu@math.s.chiba-u.ac.jp > > diff --git a/src/image.c b/src/image.c > index fc90c5ea74..7172bfc810 100644 > --- a/src/image.c > +++ b/src/image.c > @@ -1242,6 +1242,10 @@ prepare_image_for_display (struct frame *f, struct > image *img) > if (img->cr_data == NULL || (cairo_pattern_get_type (img->cr_data) > != CAIRO_PATTERN_TYPE_SURFACE)) > { > + /* Fill in the background/background_transparent field while > + we have img->pixmap->data/img->mask->data. */ > + IMAGE_BACKGROUND (img, f, img->pixmap); > + IMAGE_BACKGROUND_TRANSPARENT (img, f, img->mask); > cr_put_image_to_cr_data (img); > if (img->cr_data == NULL) > { Also, could you try if the following patch gives some output in the terminal from which you invoke Emacs? I suspect find-image failed to get a proper tool bar icon image file because file-readable-p erroneously returned nil. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp diff --git a/src/fileio.c b/src/fileio.c index 01f8a04e5d..997faa9820 100644 --- a/src/fileio.c +++ b/src/fileio.c @@ -162,6 +162,12 @@ file_access_p (char const *file, int amode) if (faccessat (AT_FDCWD, file, amode, AT_EACCESS) == 0) return true; + if (errno == EINTR) + { + perror ("faccessat"); + fprintf (stderr, "file = %s, amode = %d\n", file, amode); + } + #ifdef CYGWIN /* Return success if faccessat failed because Cygwin couldn't determine the file's UID or GID. */