From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Wed, 23 Oct 2019 19:12:26 +0300 Message-ID: <3919a409-1a2b-8da6-a1d0-f9f6def09dfe@yandex.ru> References: <83bluhf7nz.fsf@gnu.org> <20191016111004.oialbyleokafpccz@Ergus> <87k194fvn7.fsf@mail.linkov.net> <871rvceeqp.fsf@mail.linkov.net> <83tv88cyic.fsf@gnu.org> <83pniwcvon.fsf@gnu.org> <87pniw30td.fsf@mail.linkov.net> <4dc05091-53db-bff9-4623-0aedd9c2907f@gmx.at> <6f01b03d-7be3-71cc-ff97-c1a4f7b3c213@yandex.ru> <83tv879vy0.fsf@gnu.org> <6bc27f9f-e701-afb8-c6f1-408f471187c7@yandex.ru> <83imon9tg3.fsf@gnu.org> <5db11c91-a216-40f6-f4c2-7b10c73532cc@yandex.ru> <83h8424ojp.fsf@gnu.org> <9fbdd8e8-4f6a-1aba-6509-d2699c82373b@yandex.ru> <83k18vzd1j.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="112813"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: 37774@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 23 18:40:00 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iNJfx-000T99-8B for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Oct 2019 18:39:57 +0200 Original-Received: from localhost ([::1]:41374 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNJfv-00009s-5r for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Oct 2019 12:39:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46929) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNJFy-0006tu-3u for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 12:13:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iNJFv-0005k8-Ps for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 12:13:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54286) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iNJFt-0005jj-V4 for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 12:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iNJFt-0003hs-Pm for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 12:13:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Oct 2019 16:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157184716214208 (code B ref 37774); Wed, 23 Oct 2019 16:13:01 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 23 Oct 2019 16:12:42 +0000 Original-Received: from localhost ([127.0.0.1]:34874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNJFZ-0003h6-G6 for submit@debbugs.gnu.org; Wed, 23 Oct 2019 12:12:41 -0400 Original-Received: from mail-wm1-f45.google.com ([209.85.128.45]:36882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNJFX-0003gs-IO for 37774@debbugs.gnu.org; Wed, 23 Oct 2019 12:12:40 -0400 Original-Received: by mail-wm1-f45.google.com with SMTP id f22so20239189wmc.2 for <37774@debbugs.gnu.org>; Wed, 23 Oct 2019 09:12:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0dcX77nJ0rgZjV0iwFCN5XflANbGErC2brpPHs4peMs=; b=JA6q6FjUPc4s8nsAV4kolv97axeh9igeT1HfqLz1mBi4gq0IFgKazrIQtiVSbHw14f 7v1Mqy65/9yjoo7mEq2tEBV6MBwINy+9zEihiPtjXic8y0W6MDlDsh9L3LKgsJ8f0ORU EVYHmnUFOyTo1tYuRnlW78T48tR9CTGlwlXRLGycVIwPef80WHcZW4swMc3ZKiaWE3nq JPHJLx9yF3AdWy0J4CX8Ooqoy5RKB4J/ll1rZz4Sn0JmbA4nN5E9V48el8D2/H62vBfS wS+Dtb4LdBSkCrcBeQcf703mUmKEBBgHzvXe3zxC99JDJ0LfwE6vOg2HS43YGYzr31Ne q85w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0dcX77nJ0rgZjV0iwFCN5XflANbGErC2brpPHs4peMs=; b=Gl/9tTTJ733PmTYYua0o9Fj2Viv0Q0n8CzY0DX+Lr8SJvDsBQwBij1wMuNLTVO2nmk C0EHqTKDSTu18y6vd1GFILT1MFg62zmOi4YFafjiUCNWXjZOWwlaN6TkX2LqFnSUvRCi DYrXOZpVFe6fxj3zCvsJIZk5BZWpZgaMISMKUh3t3k5BKQqFs3pIYEP9KoPSeOHCfYUf xal7VIQrgPHVsvWY16Il5CQVrI8Qi66j6KVn9rqX5xTaU/3lNMbWmo3uUWTEqpkhhGbL CTYvvrU/ce/7TUE0tceL0izLakYZqd/obMYPT2qkULemwmhazEXBB3Eqj37cY0/qG5FW w30Q== X-Gm-Message-State: APjAAAU38HEzJNEJ7sAi8WpSusQjJ0KRJUTl2FS5X0qJSs748x4eW/Sp rO88cqA3ZsCvwW8wZQpyy09Ur8QsSH8= X-Google-Smtp-Source: APXvYqw9dXU38tFxU/JR9BllRGoMS/57pF+T5MExtm2EyfIsibc39lXEOgy4PRySh/TmfMuLFzJVsQ== X-Received: by 2002:a05:600c:3cb:: with SMTP id z11mr672011wmd.138.1571847153145; Wed, 23 Oct 2019 09:12:33 -0700 (PDT) Original-Received: from [192.168.0.140] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id s10sm26839768wrr.5.2019.10.23.09.12.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Oct 2019 09:12:32 -0700 (PDT) In-Reply-To: <83k18vzd1j.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170079 Archived-At: On 23.10.2019 18:39, Eli Zaretskii wrote: >>> I don't know, as I don't have a clear idea what faces there are >>> affected and why. I hoped someone, preferably the Magit developers, >>> would describe that in enough detail to understand the situation. >> >> The list of faces has been posted here already: >> >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37774#233 > > AFAIU, that's a list of faces one particular user decided to customize > to have them extended. It's a far cry from the list of faces that > actually need to be extended, lest some important functionality will > suffer. IOW, we need some rationale for each face, so that we could > consider that and decide whether or not to extend each one by default. Magit's maintainer will decide for each face, sure. But I don't really see much a difference between having 2 and 20 faces that will need to be updated, if it's within one package. Even if it's just 2, do we have a recommended way to write their definitions in third-party packages in a way that's compatible with Emacs 26? > If too many faces in unbundled packages indeed need to change in that > way, we should consider additional measures. That's why we need good > reasons for extending each face, not just "because they were before" > or because people were used to see them extended. Those are not the worst reasons, though.