From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs,gmane.emacs.erc.general Subject: bug#73686: 31.0.50; ERC 5.6.1-git: back button gone from describe-face via erc-nicks-list-faces Date: Wed, 9 Oct 2024 04:05:04 +0300 Message-ID: <38df6195-e438-41c4-b107-3e2e9a20f873@gutov.dev> References: <875xq38g4y.fsf__36834.6894437977$1728355711$gmane$org@neverwas.me> <87ttdn5dsz.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21976"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: emacs-erc@gnu.org To: "J.P." , 73686@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 09 03:06:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1syL9X-0005Tl-Np for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Oct 2024 03:06:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1syL9H-0000iV-Ng; Tue, 08 Oct 2024 21:05:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1syL9F-0000i4-3V for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2024 21:05:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1syL9E-0008OU-Rj for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2024 21:05:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=mx7V9NdTkw/lN0CvhGLX+R1cTKp26PO8EFkWLAtkiuM=; b=DbfxrubuTV6AXXZdyNaIgVsB4hlMS2O0GZ6maCHZ1gsrk4Cdhmnlvhj4OCOJDwdKtdPTK9tEYLKxH30udv1lowMYi5NsrPcw2ERQXdhsinphc3TiBfdQx95pRc8n4Y8jKqEBFeHCjWiuIQ+G3ri8lxzQQLlwwwTtzhBE0l//GT/XyytZqv6R34SfFb9j2M3stuvOMV2sXprXivyaGXRZQnnSk0TuroeNnxRnHd8I4aeeC6pKOzwjhXZJKvoRtJ3z5N1N5lkkPGmcuRoWC/GdQxX8/qXEQkdriY4Rl1EcOn7D5VtySTO9QWXpmLc1ASAWv4VnRpF7IT0zDsorWN1fvQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1syL9O-0002Pl-0K for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2024 21:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Oct 2024 01:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73686 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73686-submit@debbugs.gnu.org id=B73686.17284359349244 (code B ref 73686); Wed, 09 Oct 2024 01:06:01 +0000 Original-Received: (at 73686) by debbugs.gnu.org; 9 Oct 2024 01:05:34 +0000 Original-Received: from localhost ([127.0.0.1]:54974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syL8s-0002Oy-Jv for submit@debbugs.gnu.org; Tue, 08 Oct 2024 21:05:34 -0400 Original-Received: from fout-b1-smtp.messagingengine.com ([202.12.124.144]:46773) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syL8n-0002OB-2c for 73686@debbugs.gnu.org; Tue, 08 Oct 2024 21:05:29 -0400 Original-Received: from phl-compute-01.internal (phl-compute-01.phl.internal [10.202.2.41]) by mailfout.stl.internal (Postfix) with ESMTP id 7ADF511400AF; Tue, 8 Oct 2024 21:05:09 -0400 (EDT) Original-Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-01.internal (MEProxy); Tue, 08 Oct 2024 21:05:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1728435909; x=1728522309; bh=mx7V9NdTkw/lN0CvhGLX+R1cTKp26PO8EFkWLAtkiuM=; b= ncDEHaDJHUCnBl48UJ60pTJAczwOD7kYsWpA0Rv87JJL2HIVPCI30vrrQRQ5zMPa r+SxOs5OqNnNlAgzSTedXnyJRWLvIrW4D+TR2PK9hyWmFptcb+toXlcz/e8UP9N/ 2kLtLkWQIL0u8hxCwO9XnEGVib3MTb4j5/x05Z82e+axqxwxF30zfOcM9lsChrnf KgrZxP+451oZE4w+ugd3Io/cwYX/9s8Md3JRaao0e3NzcbDiLBFkdQizq0MQHuNN vMYdWxt3/dwrWaI9WdqhuRroXoOuaYYFjpPHDk+v96ueJeyj0HXm8V8FIiW+PwWo N8ODNxWGTqftg6MgZgKKPg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1728435909; x= 1728522309; bh=mx7V9NdTkw/lN0CvhGLX+R1cTKp26PO8EFkWLAtkiuM=; b=K /+0zWej2f8mVE7tvD8DjmW0ohszwaunZXS7k5XXKztSXu5udVGQlSBgqjdhtmR7C 8XumeA5O3fCby3rxdHQu0nfz4hvSIu42Wc9Yeq/x9RAFCsPYMFg8QUQw5oDJbp9R Sdh2+R6IhquS6QIBJuY3RaQpsPFkb3krYnOJGLiGMmExBuVJ8mqe9tpibt7AnCw1 hLpJpQxs9YLaDS8T70kJAOfUUY9dB2tFRLRku6M3PrjQ3gGTLkEvx4ppCBctSQZU sW4qngnFkYJbh9L/3IhUe7TKDnJNAUPKVwoo8FFMJtPfQuoydQDXCfTzzAS3tAZd C8y0LE8Y0VGOFscrvbp6g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdefvddggeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdej necuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdrug gvvheqnecuggftrfgrthhtvghrnhepteduleejgeehtefgheegjeekueehvdevieekueef tddvtdevfefhvdevgedujeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghvpdhnsggprhgtphhtthho peefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehjphesnhgvvhgvrhifrghsrd hmvgdprhgtphhtthhopeejfeeikeeiseguvggssghughhsrdhgnhhurdhorhhgpdhrtghp thhtohepvghmrggtshdqvghrtgesghhnuhdrohhrgh X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 8 Oct 2024 21:05:07 -0400 (EDT) Content-Language: en-US In-Reply-To: <87ttdn5dsz.fsf@neverwas.me> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293180 gmane.emacs.erc.general:2572 Archived-At: Hi! On 08/10/2024 09:06, J.P. wrote: > And because `major-mode' is buffer-local, it gets wiped out with these > latest changes before `help-buffer' ever sees it: This is a problem, sorry. The command in question (erc-nicks-list-faces) doesn't really work for me -- it errors with No faces matching "\`erc-nicks-" I've just pushed the patch below to master. Could you try it and see if it helps? diff --git a/lisp/help-mode.el b/lisp/help-mode.el index 4ee4f4156a1..f233633d2ca 100644 --- a/lisp/help-mode.el +++ b/lisp/help-mode.el @@ -505,7 +505,8 @@ help-setup-xref because we want to record the \"previous\" position of point so we can restore it properly when going back." (with-current-buffer (help-buffer) - (kill-all-local-variables) + ;; Re-enable major mode, killing all other local vars. + (funcall major-mode) (when help-xref-stack-item (push (cons (point) help-xref-stack-item) help-xref-stack) (setq help-xref-forward-stack nil))