From: Dmitry Gutov <dmitry@gutov.dev>
To: "J.P." <jp@neverwas.me>, 73686@debbugs.gnu.org
Cc: emacs-erc@gnu.org
Subject: bug#73686: 31.0.50; ERC 5.6.1-git: back button gone from describe-face via erc-nicks-list-faces
Date: Wed, 9 Oct 2024 04:05:04 +0300 [thread overview]
Message-ID: <38df6195-e438-41c4-b107-3e2e9a20f873@gutov.dev> (raw)
In-Reply-To: <87ttdn5dsz.fsf@neverwas.me>
Hi!
On 08/10/2024 09:06, J.P. wrote:
> And because `major-mode' is buffer-local, it gets wiped out with these
> latest changes before `help-buffer' ever sees it:
This is a problem, sorry.
The command in question (erc-nicks-list-faces) doesn't really work for
me -- it errors with
No faces matching "\`erc-nicks-"
I've just pushed the patch below to master. Could you try it and see if
it helps?
diff --git a/lisp/help-mode.el b/lisp/help-mode.el
index 4ee4f4156a1..f233633d2ca 100644
--- a/lisp/help-mode.el
+++ b/lisp/help-mode.el
@@ -505,7 +505,8 @@ help-setup-xref
because we want to record the \"previous\" position of point so we can
restore it properly when going back."
(with-current-buffer (help-buffer)
- (kill-all-local-variables)
+ ;; Re-enable major mode, killing all other local vars.
+ (funcall major-mode)
(when help-xref-stack-item
(push (cons (point) help-xref-stack-item) help-xref-stack)
(setq help-xref-forward-stack nil))
next prev parent reply other threads:[~2024-10-09 1:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 2:47 bug#73686: 31.0.50; ERC 5.6.1-git: back button gone from describe-face via erc-nicks-list-faces J.P.
2024-10-08 6:06 ` J.P.
[not found] ` <87ttdn5dsz.fsf@neverwas.me>
2024-10-08 21:07 ` J.P.
[not found] ` <87y12y1exp.fsf@neverwas.me>
2024-10-08 23:41 ` J.P.
[not found] ` <87o73uyxgv.fsf@neverwas.me>
2024-10-09 0:59 ` J.P.
[not found] ` <8734l6xf91.fsf@neverwas.me>
2024-10-09 3:00 ` J.P.
2024-10-09 1:05 ` Dmitry Gutov [this message]
2024-10-09 1:24 ` J.P.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38df6195-e438-41c4-b107-3e2e9a20f873@gutov.dev \
--to=dmitry@gutov.dev \
--cc=73686@debbugs.gnu.org \
--cc=emacs-erc@gnu.org \
--cc=jp@neverwas.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).