From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel Newsgroups: gmane.emacs.bugs Subject: bug#4911: mouse-face property should merge face attributes, not replace Date: Fri, 8 May 2020 11:01:35 -0400 Message-ID: <38d17eb2-ba5b-30a6-d9ac-ec18ee7d8fe9@gmail.com> References: <8452d0c8-afc3-bdb8-2c88-f66dc770c3c4@gmail.com> <0955d0dd-c4fe-4feb-b68b-0ed212ccf291@default> <35268628-9ef1-8dd2-ab93-05ca1cae06be@gmail.com> <83blne74mk.fsf@gnu.org> <83a72iij8l.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="DoSeGQJ46vOG8qwARh81HBXWJn9hvXQkD" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="41828"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 Cc: larsi@gnus.org, 4911@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 08 17:02:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jX4Vv-000Alx-18 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 May 2020 17:02:11 +0200 Original-Received: from localhost ([::1]:57240 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jX4Vu-0005uC-1a for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 May 2020 11:02:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58012) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jX4Vm-0005tN-9e for bug-gnu-emacs@gnu.org; Fri, 08 May 2020 11:02:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34534) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jX4Vl-0003pB-Vl for bug-gnu-emacs@gnu.org; Fri, 08 May 2020 11:02:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jX4Vl-000431-TX for bug-gnu-emacs@gnu.org; Fri, 08 May 2020 11:02:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 May 2020 15:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4911 X-GNU-PR-Package: emacs Original-Received: via spool by 4911-submit@debbugs.gnu.org id=B4911.158895010615534 (code B ref 4911); Fri, 08 May 2020 15:02:01 +0000 Original-Received: (at 4911) by debbugs.gnu.org; 8 May 2020 15:01:46 +0000 Original-Received: from localhost ([127.0.0.1]:46080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jX4VW-00042U-Ev for submit@debbugs.gnu.org; Fri, 08 May 2020 11:01:46 -0400 Original-Received: from mail-qt1-f178.google.com ([209.85.160.178]:43021) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jX4VU-00042D-Ed for 4911@debbugs.gnu.org; Fri, 08 May 2020 11:01:44 -0400 Original-Received: by mail-qt1-f178.google.com with SMTP id z90so1445113qtd.10 for <4911@debbugs.gnu.org>; Fri, 08 May 2020 08:01:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:references:from:autocrypt:subject:message-id:date:user-agent :mime-version:in-reply-to; bh=ARqQS7xCyRvavsMTi7DN6rLwZ0BABSf24Ptloc1jYoI=; b=IejkujoF60jGB/Mqa+NEY0t3S0meO0+Py4/y2bTpQ4ZEr0J6xgY2GWa++16GDTlF/c KRmxajuG7wm/juNfQjOi7hoz5pUZUijI6zHBiJ3YoZNZR/iVhJTXrNRhXo+3qq/+vDzG 6zLjfUW9jcTLYg4C6OHNmOU3B6qlmx7zrcCjWYjB8eE7xPWBLk2yPxQgBAkomKfV4ns/ 3YHIwCU1F+Nx+ms4KEJyKJm5s9Q9V4hBfd4IGggHj/Bamdv+1lLukoLLNPhfKjyiAk7Q pSJh6H3OVrxbTYx82RFRrswLr5PxbkvMroBFUGycIfTZf0A+pZISsM/Ut6EBG2EKne29 tllA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:autocrypt:subject :message-id:date:user-agent:mime-version:in-reply-to; bh=ARqQS7xCyRvavsMTi7DN6rLwZ0BABSf24Ptloc1jYoI=; b=N4uwpt6ExNFaM/q/a/o+SYrZ1LyRarPWmj626/gfWpr3ado16efBP3cE45A8NvU0oY ByFSBlpLKCjCxfhRhg6jPVUHx/rtbcOKjAwQSyv2c817uroWNf7StHRX3+pnFlLQmSGu kwg8Bde3h4cXB1D0QRPVahVO3YGla1wlG0IrndIba5jkaChryeA1eynepP8EUlK9Z9Jf Djla/Ioequs2pHGf4fj/ZQLbCjArlPxTZ1nR9au+cgiT+VQ38rd4quBJbMKlDWzPdlk3 1MDSr8hvkSnU4oPNOx9aUi0OXpw5LQv1Ox1zdsrO0s1j6Tx5la0L0yrFqW7up3TNNfCv 3FWQ== X-Gm-Message-State: AGi0Puaf+7Je3MxMorSPXRyQ6g32wXzQyvDPrJ/g9b8UM0LivzFWBBaw HtXuENciVH7Ohs2ItjsPC2c= X-Google-Smtp-Source: APiQypLgrNzzHi7BVzCxl6Apz5GQPB75OHdXe7V79epywvporAtcoftjsRXKLX0I8X8L4gjie9RT7w== X-Received: by 2002:ac8:4796:: with SMTP id k22mr3395102qtq.215.1588950098383; Fri, 08 May 2020 08:01:38 -0700 (PDT) Original-Received: from ?IPv6:2601:184:4180:66e7:4d17:b25e:8d9:2188? ([2601:184:4180:66e7:4d17:b25e:8d9:2188]) by smtp.gmail.com with ESMTPSA id e206sm1315692qkb.94.2020.05.08.08.01.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 May 2020 08:01:37 -0700 (PDT) Autocrypt: addr=clement.pitclaudel@gmail.com; prefer-encrypt=mutual; keydata= xsFNBFStGiEBEAC8eHa+DdcrVtDSwYoIgoUtMfRAan4bdLxZuNIASy6iFytCHNsKqfPkq8zD YV2+uMtbdcnjapE038nidEMItNhO04JdZ+PJ6jvJo1gW+XI4fM8uzkGZauwR+d3hEq6goFSp rIlSlaVf2g5q4OKxI754yqwz00++EZhZQMntzoKQVV9stJ5eQ+gxTT1ANr7wQKbjn/8PM/Cg hBZvYLhh+WsS0Ko5qZuWdsvUBLpprmCWkP4FpZ234/tWpdVID65nlHpu25+6ajIcxfCIK+dN 2br0wN1szTeQFG19cfr3jXEvwHmLQbQqCg4UH+2b7JpMGR2/KWjqRWfWVvZMPVeJdOsZHx53 k6HIbEhvFBHbmqCI6FAZQjkgzGGkrSD92+jeMYiCTxRKqq2hFZ6xqQ6pJdXD1TXcIYPEs7rA MwcNMj8g4e6vuI+2CjHyQQkyMPAEi8guNPnyfBb648f1lxj7JiJu/ehRghIP5u/kLOsHNCKG QgCT04sawBZYHqEVYni8oHlGJcdWGT5/UI4B+wn70eXvYSScZEaB+S2s/bD0cdlSpHY5Od3l tpRZTva+ydswlrz4fxbYF45s6rFpqVwBMfNv3gqhBFXbuiEEctcTSGqhHxxT4R+24Yn+ZSBa EfUbrKnVTUmV20k+57rghiVw2wpj8v7sn3QXt96HJ9ImY4JvuwARAQABzTNDbMOpbWVudCBQ aXQtLUNsYXVkZWwgPGNsZW1lbnQucGl0Y2xhdWRlbEBsaXZlLmNvbT7CwXsEEwECACUCGyMG CwkIBwM In-Reply-To: <83a72iij8l.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179925 Archived-At: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DoSeGQJ46vOG8qwARh81HBXWJn9hvXQkD Content-Type: multipart/mixed; boundary="RPcWroiE2EbHaLNIYbLIYRWw4gsncOKeh"; protected-headers="v1" From: =?UTF-8?Q?Cl=c3=a9ment_Pit-Claudel?= To: Eli Zaretskii Cc: drew.adams@oracle.com, 4911@debbugs.gnu.org, larsi@gnus.org Message-ID: <38d17eb2-ba5b-30a6-d9ac-ec18ee7d8fe9@gmail.com> Subject: Re: bug#4911: mouse-face property should merge face attributes, not replace References: <8452d0c8-afc3-bdb8-2c88-f66dc770c3c4@gmail.com> <0955d0dd-c4fe-4feb-b68b-0ed212ccf291@default> <35268628-9ef1-8dd2-ab93-05ca1cae06be@gmail.com> <83blne74mk.fsf@gnu.org> <83a72iij8l.fsf@gnu.org> In-Reply-To: <83a72iij8l.fsf@gnu.org> --RPcWroiE2EbHaLNIYbLIYRWw4gsncOKeh Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable On 08/05/2020 10.39, Eli Zaretskii wrote: >> Cc: drew.adams@oracle.com, 4911@debbugs.gnu.org, larsi@gnus.org >> From: Cl=C3=A9ment Pit-Claudel >> Date: Mon, 4 May 2020 11:16:05 -0400 >> >> Currently we cache a single realized mouse_face. Could we cache a seq= uence of such realized faces instead, attached to regions of text? That = is, we'd compute the realized mouse-face for all regions of the current s= pan, and cache that. Concretely, I guess this would mean enhancing Mouse= _HLInfo to keep a list of spans instead of a single one. >=20 > I'm not sure I understand what you mean by "span" in general and > "current span" in particular. I meant a range of text with a single mouse-face property. > We could, of course, realize such combinations. It would need: >=20 > . realizing and caching 2 faces whenever we render some text which > has a mouse-face property; Don't we already do this, currently? > . recording the buffer positions to which those realized mouse-faces > are relevant; and That makes sense. Basically, I was hoping to change Mouse_HLInfo to cont= ain more than one range and more than one face. > . using the corresponding face when redrawing the highlighted > portions of text by looking at the positions of each of the > affected glyphs (which might be complicated if the text doesn't > come from a buffer) But isn't that already taken care of by the existing highlighting code? --RPcWroiE2EbHaLNIYbLIYRWw4gsncOKeh-- --DoSeGQJ46vOG8qwARh81HBXWJn9hvXQkD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEElGa8adIcPra4Jxxu+qD5xOb3TCMFAl61dE8ACgkQ+qD5xOb3 TCPwsxAAi7OJrQIb6+H5F4t2Pt9LRSpDHhkjnzQOG1E5RmTBAOQNu+5U50AHp6Qe r005UHsYNurI98EqMhlJbPOj3sHjXV0kVLBkyXUFTpCTJFa7rA10JfKI14OSN1oB zBe5dcCCD0ue4WnNIm4Y933z7mX/Bk4VyP3W8gzdPbdn+Bbee4Ay9k8AR1oGEZ8X xUa22BSpjdBKuV29psaCu5rR059PVTwGeiPpS47dBk6k/1ZI5pu4W5nmb0YVTD7h JJNF1ufK7VtKXkneHpB5+ZZhJXKjntHx7INR5ACp6T8DDDDSXheEwg/s2ZIDF6Oc 71U5AaMZ1iDLfmX1DvyGBqA4JlyQfF5u27drZkTj3MuBYHmUAh07MUfQsHdWOthz +F3pNgYl/FeM7ha2RbvsN9mOb86ZiIEm7HyWJ8KA746ZonYbS0KaP0PxYJ2DK4Qa pBp8PQmqig4zkQRkVnuTePL8GVS/TgFRAjv7b3JTpQUiuGSRHsfbf2f1NCX5MTS9 zQohpN37Culnf4aVTGBuZvjdptr+BMHrfsBQon8bea8bk5zLLcMsoYwBG8KbvQwM g2Dxa44kX1tLsQBZnPLm60c/JC9O8tSkD7/Bqo2KjZTPRFNvSTIVKk8IDjlc+YTK 8bi5U0FJEqoPFmOFy+bAxyQxIa9te9PTfcGn+jDZ0PRMutp/AFg= =hi79 -----END PGP SIGNATURE----- --DoSeGQJ46vOG8qwARh81HBXWJn9hvXQkD--