From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#56393: Actually fix the long lines display bug Date: Tue, 05 Jul 2022 16:21:57 +0000 Message-ID: <38c1a31040ba2976eb4d@heytings.org> References: <38c1a31040d2d2bc47ae@heytings.org> <38c1a310405bd4bbe370@heytings.org> <87a69n98yy.fsf@yahoo.com> <38c1a31040f5546dbd3a@heytings.org> <83a69n90t8.fsf@gnu.org> <38c1a31040ad21b41adc@heytings.org> <835ykb8x3z.fsf@gnu.org> <38c1a310403dbabc7270@heytings.org> <834jzv8sv4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12557"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56393@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 05 18:57:33 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8lrh-00033H-I9 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Jul 2022 18:57:33 +0200 Original-Received: from localhost ([::1]:59576 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8lrg-0002BH-Kt for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Jul 2022 12:57:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35358) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8lKI-0006CD-9o for bug-gnu-emacs@gnu.org; Tue, 05 Jul 2022 12:23:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57508) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o8lKH-000745-VO for bug-gnu-emacs@gnu.org; Tue, 05 Jul 2022 12:23:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o8lKH-0003Wa-S1 for bug-gnu-emacs@gnu.org; Tue, 05 Jul 2022 12:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Jul 2022 16:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56393 X-GNU-PR-Package: emacs Original-Received: via spool by 56393-submit@debbugs.gnu.org id=B56393.165703812213449 (code B ref 56393); Tue, 05 Jul 2022 16:23:01 +0000 Original-Received: (at 56393) by debbugs.gnu.org; 5 Jul 2022 16:22:02 +0000 Original-Received: from localhost ([127.0.0.1]:51398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8lJK-0003Ur-Gl for submit@debbugs.gnu.org; Tue, 05 Jul 2022 12:22:02 -0400 Original-Received: from heytings.org ([95.142.160.155]:53856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8lJH-0003UR-Qx for 56393@debbugs.gnu.org; Tue, 05 Jul 2022 12:22:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1657038118; bh=6FTyfxtAtPfp2yKm6a+8LD98XP9UwTd4snRu2zlVLzE=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=c1hmXCODh1DPUkmI3r45SGdAZLiSgXCb6+kGKFr7C1TYrZbXZVgzu2PKAmGiJRaUR aWub8Rjg46TW+lYBlkyoJDA6/yhtIGjiZFWQq44WJtw4DgPbWrqNUrNcOXyn6oRMyu p1mLJi3ifASEnenaz6ietA64b0zFiiCvAUpdweJf+QwWUme103wDexKPivrF+5EVeL i6WLJKHien/TfpkLP6XXPRWtyTjZkIPHYpvVUhXw/TMfjs3IgsBp8MgkntY4RV1OPE awX8L5d39t+p57hIn6P0mVBox/C94HRMhyp1CMVQmcm5InogAnM0w2dvbyDiWLQhed roZrKD9hmVckg== In-Reply-To: <834jzv8sv4.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236140 Archived-At: >> As I said, if that's the case, it's easy to add a "(let >> ((auto-narrow-long-line-threshold nil))" around the code, in this case >> either in the with-temp-buffer macro or in the code above. > > These macros are called a lot, and I don't think it's a good idea to > tell all their callers to make such changes. > As I said, this can also be done inside the with-temp-buffer macro. A (very quick) review of calls to insert-file-contents in Emacs core and ELPA tells me that that the majority of these calls are inside a with-temp-buffer or with-current-buffer (with a temporary buffer). > > I think we should try to work out a solution that only affects the C > code in the display engine, such that any Lisp called from the various > hooks and places in display code is not affected, and neither are > pre-command-hook and post-command-hook. That should have almost the > same effect, performance-wise, but be much safer than the automatic > narrowing that affects everything in Emacs as long as the narrowing is > in effect. > > IOW, replace all BEGV and ZV in display code with a couple of new > macros, which effectively "narrow" the buffer, as far as the display > engine is concerned. Then set the limits of this restriction in > redisplay_window, and remove it when the window's redisplay is done. Or > something along these lines. > I guess this means, in essence, to throw away the patch? Or do I interpret what you wrote too negatively?