From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#64619: [PATCH] Add toggle-window-dedicated command Date: Sat, 19 Aug 2023 20:37:31 +0000 Message-ID: <387ee04aa97c3477c4f3@heytings.org> References: <87h6ovgnpn.fsf@catern.com> <387ee04aa9601b936ac5@heytings.org> <87350ere4n.fsf@catern.com> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30578"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Spencer Baugh , Philip Kaludercic , 64619@debbugs.gnu.org, martin rudalics , Eli Zaretskii , Drew Adams To: sbaugh@catern.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 19 22:38:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qXSiA-0007lb-27 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Aug 2023 22:38:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qXShu-0005eW-N7; Sat, 19 Aug 2023 16:38:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXSht-0005eO-Fm for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 16:38:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qXSht-00016I-7M for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 16:38:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qXShu-0001xs-1L for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 16:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Aug 2023 20:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64619 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64619-submit@debbugs.gnu.org id=B64619.16924774617523 (code B ref 64619); Sat, 19 Aug 2023 20:38:02 +0000 Original-Received: (at 64619) by debbugs.gnu.org; 19 Aug 2023 20:37:41 +0000 Original-Received: from localhost ([127.0.0.1]:52358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXShY-0001xH-Rd for submit@debbugs.gnu.org; Sat, 19 Aug 2023 16:37:41 -0400 Original-Received: from heytings.org ([95.142.160.155]:45292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXShT-0001x4-5z for 64619@debbugs.gnu.org; Sat, 19 Aug 2023 16:37:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1692477452; bh=BQ+3v90H+TofVlKI++//BrG9PL4Et+Q/4l9MrqdLGu0=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=MiprR/O4Dd7Tt0Z219gl3kBoCdbYH856pbJuyB6uOlfbhaYzxtiwilqfrGNpfSnQZ asrAcWQbGHDPjOiKHO5KXnQBEUmOERzxozXPH9JMynVXIb/vI/Ih2lndtNTP+cFBqi XAbSMD0lP5Eq7bfsIyL2iXGV143HyMk+CES7+UrGDMAWn/DlP2TSUFm4z9SPW2bGLF HVZ7gCO7I38gaAxqBZtmnv6QlDzwET9YcX6+FOJBj4+bzXLE4MO5Eark4piSd07bZB TORm6OzMu0Nam8JuL5zN1Xb0nyFANOIvPDiUl/ud435AZTKy+gQ9+KjPQMWHrJmOjG 6Wr5Y/hXNBzVA== In-Reply-To: <87350ere4n.fsf@catern.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267915 Archived-At: >> This makes the window "strongly" dedicated, which is more in line with >> what "Window will now display only its current buffer" promises (e.g. >> C-x b will refuse to switch to another buffer). > > Ah, see earlier discussion. > Sorry, I missed that in the earlier discussion. > > We at least want to be able to choose between strong and non-strong > dedication. And having used this command I think non-strong dedication > is a much better default, since it allows users to explicitly run C-x b > to change buffers without having to switch off dedication. > I agree with Drew here: strong dedication would be a better default. The fact that the window was weakly dedicated and that I could switch to another buffer without any warning or confirmation surprised me when I tried your patch, hence my reaction. Dedicating a window to a buffer is somewhat like making a buffer read-only, and I guess "weak read-onlyness" would be surprising to most users. >> 2. I would not bind it to the "d" key but to the "!" key: ISTM that >> toggling window dedication is not such a common action that it needs a >> letter key binding. > > It's not common at the moment, but I expect some users will use this > command quite frequently. Also the C-x w prefix is pretty empty at the > moment, so it's not as if it's competing with anything. > It's pretty empty, but IMO that's not a reason to use its "best" bindings for something like this. "d" should IMO be used for "delete" (yes, I know it's already available with C-x 0). See https://lists.gnu.org/archive/html/emacs-devel/2022-09/msg00326.html.