From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#36237: Support (rx (and (regexp EXPR) (regexp-quote EXPR))) Date: Tue, 18 Jun 2019 21:45:57 +0200 Message-ID: <385FA4F7-7FB5-43A2-B571-CFBA20B24123@acm.org> References: <87fto9yawl.fsf@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="179026"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Michael Heerdegen , 36237@debbugs.gnu.org, Stefan Monnier , kevin.legouguec@gmail.com To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 18 21:47:25 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hdK4j-000kNO-14 for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Jun 2019 21:47:25 +0200 Original-Received: from localhost ([::1]:33128 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdK4h-0006AO-Sm for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Jun 2019 15:47:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46103) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdK4N-0006AG-Cz for bug-gnu-emacs@gnu.org; Tue, 18 Jun 2019 15:47:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hdK4M-0007GL-A4 for bug-gnu-emacs@gnu.org; Tue, 18 Jun 2019 15:47:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60332) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hdK4L-0007Fs-QA for bug-gnu-emacs@gnu.org; Tue, 18 Jun 2019 15:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hdK4L-0006vT-M4 for bug-gnu-emacs@gnu.org; Tue, 18 Jun 2019 15:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Jun 2019 19:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36237-submit@debbugs.gnu.org id=B36237.156088716726543 (code B ref 36237); Tue, 18 Jun 2019 19:47:01 +0000 Original-Received: (at 36237) by debbugs.gnu.org; 18 Jun 2019 19:46:07 +0000 Original-Received: from localhost ([127.0.0.1]:45643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hdK3S-0006u2-G2 for submit@debbugs.gnu.org; Tue, 18 Jun 2019 15:46:07 -0400 Original-Received: from mail211c50.megamailservers.eu ([91.136.10.221]:35784 helo=mail194c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hdK3P-0006tG-47 for 36237@debbugs.gnu.org; Tue, 18 Jun 2019 15:46:04 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1560887160; bh=MLz5JpYEymNrBa09YmIz4fHXck+/ZgGj04CJlbrRIcQ=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=bOgRtBthLO46mw6pTOgpwBg4STUbjT4yt4H2lbLn93JjcLLB+igDOIEZJgyLh6Scy 8r9KuVaIMzpHFjD6EKc4Xi+xTYje75slDZ0TyPYHR6nz+Z5FXNzLvpBoWS6olEeNyB l/T2lDRJiy4/Qw1l9MqEWKp9sSQbfAhLf+hHI1cE= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.1.65] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail194c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x5IJjweo018931; Tue, 18 Jun 2019 19:46:00 +0000 In-Reply-To: <87fto9yawl.fsf@gmail.com> X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B020B.5D093F78.0044, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=OuZhNR3t c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=pGLkceISAAAA:8 a=M9u8WbzkAAAA:20 a=pNNhlyHfwFR-6d7Vh-8A:9 a=CjuIK1q_8ugA:10 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160796 Archived-At: 16 juni 2019 kl. 14.25 skrev Noam Postavsky : >>> The plan was to replace rx with ry entirely when complete. >=20 > How far away is this? Would it make sense to delay this bug until = "ry" > comes in? The function-complete ry has been put at https://gitlab.com/mattiase/ry = for the time being. It should now be entirely compatible, including = support for `rx-constituents'. Your proposed `literal' was also added, = which was instructive; I needed to know how it would fit in. Bootstrapping Emacs with it (ry renamed to rx, of course) works, = including python-mode which uses `rx-constituents' for extension. It = also has fewer of the known bugs of the current rx, and a much more = extensive test suite. There are two things that perhaps need to be resolved before replacing = the current rx: 1. Is there externally developed elisp code that makes use of internal = rx functions and variables, perhaps for extension purposes, and do we = need to worry about breaking it? The code is old enough not to delineate = internal and public symbols clearly (no double-dash), which means that = people may have gone and used all sort of things. 2. What would a good extension mechanism look like, and should one be = put into place right away, so that we can point to a decent replacement = for the internal toys that users relied upon? Noam, unless the consensus is that ry is unequivocally as good or better = than rx, you could just as well apply your patch (suitably fixed up). = Even if later replaced, there is nothing fundamentally wrong with the = design; let's not hold it hostage.