From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#63790: 30.0.50; prog-fill-reindent-defun regression Date: Sat, 3 Jun 2023 05:40:47 +0300 Message-ID: <382ab3bd-b9ed-ea18-1ae5-9458ffb1b85c@gutov.dev> References: <864jnv6pf8.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30360"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 To: Juri Linkov , 63790@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 03 04:42:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q5HDe-0007jE-GA for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Jun 2023 04:42:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q5HDR-0005P9-Hh; Fri, 02 Jun 2023 22:42:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5HDP-0005Oz-QL for bug-gnu-emacs@gnu.org; Fri, 02 Jun 2023 22:42:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q5HDO-0007zH-Ty for bug-gnu-emacs@gnu.org; Fri, 02 Jun 2023 22:42:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q5HDO-0008G5-Dt for bug-gnu-emacs@gnu.org; Fri, 02 Jun 2023 22:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Jun 2023 02:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63790 X-GNU-PR-Package: emacs Original-Received: via spool by 63790-submit@debbugs.gnu.org id=B63790.168576006231674 (code B ref 63790); Sat, 03 Jun 2023 02:42:02 +0000 Original-Received: (at 63790) by debbugs.gnu.org; 3 Jun 2023 02:41:02 +0000 Original-Received: from localhost ([127.0.0.1]:41136 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5HCQ-0008Ed-2I for submit@debbugs.gnu.org; Fri, 02 Jun 2023 22:41:02 -0400 Original-Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:39529) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5HCM-0008E8-Qp for 63790@debbugs.gnu.org; Fri, 02 Jun 2023 22:41:00 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 09B63320084E; Fri, 2 Jun 2023 22:40:50 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 02 Jun 2023 22:40:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1685760050; x=1685846450; bh=w7F1pFxPw/y4dU/y/fEBt4Lfc4RWvHaZVMU dK1IG2F4=; b=koNgrP8gVrfd33+3acZz+iljRc8lKYFFW7kdO3+h1gaK8Fm3vQZ DuwESF7R/ZGv1QBHsuf7p9D6ThuTheITOQg9mTo04AQ/nMaZBeNilSynMLS1ukeC vFHaLwMAWr/zVyVDTu7OjjEthrH7bUWRd8GxGEU7ILCjJYyF0dG3FdmPJFfnSnIE AaqCRAVRyBaJzVCmMS/ET/dgJFx8xrzkLGgt9tMCcciWJrkMuegAULasrn2q3n2P UawHN7/VEA0z7NaaOz3xRFCEakrNyeVhFYUz39EZSS36jT9qfjNVHZT9zgwIuwLF CHX6sL0OY8xuHMOnJhrSCtncmRfD55t2FxA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1685760050; x= 1685846450; bh=w7F1pFxPw/y4dU/y/fEBt4Lfc4RWvHaZVMUdK1IG2F4=; b=m v02MOkG32XbRJ7u2kn/nTVOFCIDfSZOM2dW2u1fKzXh7QT/8toQ/PZ9xOpYWlbfR teySGocQWeZnH3RkFvvgoMCFk1HwEO8+1jEMt9H9nfOwiG3g5DjAE4qzv4W7p0IM ax4k+NA3Ao/NwlERmJn6+Govv9D7NUK8O0Yi6x/OnpfwS/OUxMyW8Ikp5x2Miyln PQVql8L16UV04REhC6Lxu5gl8xESZebT0M8zFmYQgwoIzgpOS5fM3K76lN3ZY1w+ JMoWA2AQVK2iPotlT0tMyj1qR54WDHkdYs2bK0RC+x3cDC6sOj6fN1p7IVV0bhX5 KoY9h/27y3brd6fDO2qRw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeelgedgiedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeeghedthedujeeiteeutddtjeekheejteeukeehffdutdejuedvfeevueeviedu udenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 2 Jun 2023 22:40:49 -0400 (EDT) Content-Language: en-US In-Reply-To: <864jnv6pf8.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262796 Archived-At: On 29/05/2023 19:53, Juri Linkov wrote: > This regression is in master, not in emacs-29. If it is a regression, then compared to what? emacs-29 doesn't have this function. Compared to some earlier revision? > 0. emacs-30 -Q > 1. add to the beginning of the *scratch* buffer a list, so that > *scratch* looks like this: > > (+ > 1 > 2 > 3) > > ;; This buffer is for text that is not saved, and for Lisp evaluation. > ;; To create a file, visit it with C-x C-f and enter text in its buffer. > > 2. Activate the region with the beginning at the start of the line with > the first comment, and the region end with point at the end of the buffer. > > 3. Type 'M-q' (prog-fill-reindent-defun) > > It indents the list instead of the comment. > > But when point is at the region beginning then 'M-q' correctly indents > the comments. This happens because in this scenario point ends up outside of the comment (at eob). So when the function is called, in looks for a defun. Did we at some point add (or decide to add) a condition when, if a region is active, it should only refill and not reindent?