From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#21091: 25.0.50; `isearch-done' called before `isearch-update' raises wrong-type-arg error Date: Sat, 3 Sep 2016 17:08:41 -0700 (PDT) Message-ID: <37c2e51c-3593-4e67-ae29-ce8705a412bf@default> References: <87inyyait0.fsf@gnus.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1472947760 466 195.159.176.226 (4 Sep 2016 00:09:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 4 Sep 2016 00:09:20 +0000 (UTC) Cc: 21091@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 04 02:09:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgKzr-00080Y-Jr for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Sep 2016 02:09:15 +0200 Original-Received: from localhost ([::1]:48229 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgKzp-0006RX-FO for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Sep 2016 20:09:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgKzj-0006RR-6B for bug-gnu-emacs@gnu.org; Sat, 03 Sep 2016 20:09:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bgKze-0006xf-RP for bug-gnu-emacs@gnu.org; Sat, 03 Sep 2016 20:09:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51316) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgKze-0006xb-Nh for bug-gnu-emacs@gnu.org; Sat, 03 Sep 2016 20:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bgKze-0001Or-Ha for bug-gnu-emacs@gnu.org; Sat, 03 Sep 2016 20:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Sep 2016 00:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21091 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 21091-submit@debbugs.gnu.org id=B21091.14729477355368 (code B ref 21091); Sun, 04 Sep 2016 00:09:02 +0000 Original-Received: (at 21091) by debbugs.gnu.org; 4 Sep 2016 00:08:55 +0000 Original-Received: from localhost ([127.0.0.1]:49028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgKzW-0001OW-Op for submit@debbugs.gnu.org; Sat, 03 Sep 2016 20:08:54 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:33944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgKzU-0001OI-TA for 21091@debbugs.gnu.org; Sat, 03 Sep 2016 20:08:53 -0400 Original-Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u8408ja8009526 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 4 Sep 2016 00:08:45 GMT Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.13.8) with ESMTP id u8408hdP010975 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 4 Sep 2016 00:08:44 GMT Original-Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by userv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u8408gkh014086; Sun, 4 Sep 2016 00:08:43 GMT In-Reply-To: <87inyyait0.fsf@gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6753.5000 (x86)] X-Source-IP: userv0022.oracle.com [156.151.31.74] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122915 Archived-At: > > Recently someone added `isearch--current-buffer' to isearch.el. > > > > This is initially nil. It is given a string value (buffer name) only i= n > > `isearch-update'. But it is called in `isearch-done' and expected to > > have a string value there. If it does not, a wrong-type-arg error is > > raised... > >=20 > > When called at top level, `isearch--current-buffer' is nil, and the > > wrong-type arg error is raised. > >=20 > > I can "fix" the problem that was introduced by wrapping the > > `isearch-done' call in `ignore-errors'. But I think it would be better > > for isearch.el not to assume that `isearch-done' is called after > > `isearch-update'. I don't think there is a reason why the two need to > > be coupled in that way. Adding variable `isearch--current-buffer' in > > the way it was done makes the isearch.el code more fragile than it need= s > > to be, I think. > >=20 > > Anyway, please consider somehow ensuring that `isearch-done' does not > > care whether `isearch--current-buffer' has a string value. >=20 > If I understand you correctly, I don't think this is a bug. If somebody > else disagrees, please reopen this bug report. No reason given? Why do you think it is not a bug? Why do you not think that "adding variable `isearch--current-buffer' in the way it was done makes the isearch.el code more fragile than it needs to be"? Why should the code assume that `isearch-done' is called only after `isearch-update'? There is nothing inherent in `isearch-done' that suggests that.