From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#38164: quit-restore-window doesn't restore point in man Date: Wed, 13 Nov 2019 09:04:12 +0100 Message-ID: <37ad920d-a8ca-8cc4-33c7-ecec4792eb61@gmx.at> References: <8ea0a3fa-5169-4493-bd54-3ebe47836a35@default> <87r3i9nped.fsf@gnus.org> <87wps1m7co.fsf@web.de> <87r22gbquk.fsf@mail.linkov.net> <875zjrzgoz.fsf_-_@mail.linkov.net> <02f0564a-baf3-b15c-bcc5-98d37f510d7a@gmx.at> <877e45ksaz.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="26974"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 38164@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 13 09:05:35 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iUneg-0006sZ-V0 for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Nov 2019 09:05:35 +0100 Original-Received: from localhost ([::1]:41880 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUnef-000439-JI for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Nov 2019 03:05:33 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34452) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUneD-00042p-LN for bug-gnu-emacs@gnu.org; Wed, 13 Nov 2019 03:05:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iUneA-0001WE-PP for bug-gnu-emacs@gnu.org; Wed, 13 Nov 2019 03:05:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49979) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iUneA-0001WA-Hk for bug-gnu-emacs@gnu.org; Wed, 13 Nov 2019 03:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iUneA-0005SK-AD for bug-gnu-emacs@gnu.org; Wed, 13 Nov 2019 03:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Nov 2019 08:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38164 X-GNU-PR-Package: emacs Original-Received: via spool by 38164-submit@debbugs.gnu.org id=B38164.157363226320915 (code B ref 38164); Wed, 13 Nov 2019 08:05:02 +0000 Original-Received: (at 38164) by debbugs.gnu.org; 13 Nov 2019 08:04:23 +0000 Original-Received: from localhost ([127.0.0.1]:58800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iUndX-0005RH-6K for submit@debbugs.gnu.org; Wed, 13 Nov 2019 03:04:23 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:36747) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iUndV-0005R4-8P for 38164@debbugs.gnu.org; Wed, 13 Nov 2019 03:04:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1573632252; bh=ekUThouR9vQXLpcrKPZ67WJyk3hjSjp/JKEvijqlKSE=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=RVQe27UA3a1AWyEDpsCXIUAdbBvBhbgixiTpZNYU+CXvJUgt/Yzi2RQRL3ohANe2T VkJP6vt6+DFCyNyZou6LvtZgxTs2oSbHH4RA1h0RswXCwgU6zmA7Sx9G1Ov1ym7ptQ uqpT+FppdjqaEx6Yxik2Qub6VjPcsgT0ESgJybtc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.103] ([46.125.249.127]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MiacR-1i082l0TwN-00flPc; Wed, 13 Nov 2019 09:04:12 +0100 In-Reply-To: <877e45ksaz.fsf@mail.linkov.net> Content-Language: de-AT X-Provags-ID: V03:K1:3PHQzKTP7/B0wSX2imTrnmCAc/flNAOfOVYmQv9XGETo8+NE3VH aJW7OOl0DQIzgiv2mxbBbf/LsWYyCyJwVBvhVD+dIfqtTKl/zMSLmMxXtNGtdsHNxkm4j6W zkdjOzRWpVdVqqeuM6x21N6qDoFvUKb2xrxSgGLAPsA/A5QPKj8bkEjQXd1dFItTvesF/4f yzBSmsYtdHSUM6BwzcoIA== X-UI-Out-Filterresults: notjunk:1;V03:K0:ssG+3vTjozY=:BsR3scqxLXAGXq7bxSTDKT 8dxnxEXPoSjDkjwBuV/m5coZL/hC3XN0i4feWlRmGAPWOhGXrdFV804obL8Up4gx2ASCC2vz7 s/TC3jIvkMbCO32bY2+jpPUkZXXO9gygg5FOpWbnpMAGFuRkayniCkUc7kjGz+r46QbNRjEjc TDBaPb4DM37ZvzY5H/wHJxQgnabfFZOeEup+MoBQaH7ie6PHxOqVjmNsy6jAc+vd+GI3WvPd6 Kmm2L9PpIDRLuLnsC7psnBcARryRM87Kr42HSlyRCL2iablGF1EY24WFdpi7ew6/4ilSShNUI qEkuLvTok2Vwwab6kunLpXGscFpXWL16ehgTU1B+a3Xni9sKB9tDVzCOHbPLNDJJGnNK7zSv3 i5J2u/Vv0kw1TCu/AiALrG9nR3qjfwCb4KoaT2FAbtRJab22gy6cSXlvFfqh+LlftYuGgLhEK dxlyHBJjQ8ixejdNfW7Tz0hXm2mA0ErZ1Cgq/mbiCEP4GXtkIk7jSXtHm9jh9XRCEs3R5ThGb F+T6JEidg+Lm5sZIrkTpSJg5/anulHZdvPv28T0x6wDj9fTY9k5lo9aKat4GxGc3j6SxHfjnx /xRO/305nteesOF98jvQQxPPm1aREz1CXWk7DvM47dl05LhyLs6eqgszkhPdykgGSyDjVWk3y 1OIwXoh2LmvPMZ5eQF0B3+BO+mHR4P8UYppUtKq9pwyef83hrfqetU/0Pccrfe3szq41cqM44 ssLk0I2w6Wz1hkfawBkbu8+VGfnsMzBo1zfkujvNBMxXc2R4J29DsAAIlmBgBpeAcLY1EArW X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171484 Archived-At: > Removing these lines from 'quit-restore-window' fixes the problem: > > ;; Select old window. > (when (window-live-p (nth 2 quit-restore)) > (select-window (nth 2 quit-restore))) > > If there lines are the whole purpose of 'quit-restore-window', > then in man.el we need to reselect the original window explicitly: > > diff --git a/lisp/man.el b/lisp/man.el > index ce01fdc805..76890f74a9 100644 > --- a/lisp/man.el > +++ b/lisp/man.el > @@ -1469,8 +1469,10 @@ Man-bgproc-sentinel > > (when delete-buff > (if (window-live-p (get-buffer-window Man-buffer t)) > - (quit-restore-window > - (get-buffer-window Man-buffer t) 'kill) > + (progn > + (quit-restore-window > + (get-buffer-window Man-buffer t) 'kill) > + (select-window (old-selected-window))) > (kill-buffer Man-buffer))) > > (when message I'm completely lost now. Can you tell me in a detailed fashion what goes wrong here? Is the window stored in (nth 2 quit-restore) the wrong window right from the outset? Or is it in a sense falsified by what happens later during minibuffer interaction? martin