From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#70968: 29.2.50; choose-completion on an emacs22-style completion deletes text after point Date: Thu, 16 May 2024 20:26:31 +0300 Message-ID: <377f815c-52d2-4770-ae85-55e096e104b0@gutov.dev> References: <86bk56jhsp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21765"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 70968@debbugs.gnu.org, Stefan Monnier , juri@linkov.net To: Eli Zaretskii , Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 16 19:27:27 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s7et4-0005Lo-Lz for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 May 2024 19:27:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s7esi-0004i3-Im; Thu, 16 May 2024 13:27:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s7ese-0004hn-CZ for bug-gnu-emacs@gnu.org; Thu, 16 May 2024 13:27:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s7ese-0001WE-4H for bug-gnu-emacs@gnu.org; Thu, 16 May 2024 13:27:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s7esg-0001GC-66 for bug-gnu-emacs@gnu.org; Thu, 16 May 2024 13:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 May 2024 17:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70968 X-GNU-PR-Package: emacs Original-Received: via spool by 70968-submit@debbugs.gnu.org id=B70968.17158804064831 (code B ref 70968); Thu, 16 May 2024 17:27:02 +0000 Original-Received: (at 70968) by debbugs.gnu.org; 16 May 2024 17:26:46 +0000 Original-Received: from localhost ([127.0.0.1]:49972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s7esP-0001Fr-LW for submit@debbugs.gnu.org; Thu, 16 May 2024 13:26:46 -0400 Original-Received: from fout2-smtp.messagingengine.com ([103.168.172.145]:35563) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s7esM-0001Fl-Fn for 70968@debbugs.gnu.org; Thu, 16 May 2024 13:26:43 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfout.nyi.internal (Postfix) with ESMTP id F109A1381511; Thu, 16 May 2024 13:26:34 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 16 May 2024 13:26:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1715880394; x=1715966794; bh=8LDx7Cf4RT/ExUJrLeXJaIwmHTslW10/HrV8BoCDq9Q=; b= GKHChPLXOPGdmSH/W70nM8knIP66UFlVeHVT95FO/EAlSimjCyA8Fx2e65G3BFw3 dCY9rJLUQN6tdiuJlZchrmuSEWOQKMe4c88m90CHl3ruFXNCQ0flxRgDHMuy0g60 TSICFMi4JtMfrxdU58BUmHhFkeWRZgQq+D/A6eb6ahRVutPNk63dhtPIuDXK7OKv Ten9uwgF61f7fzgOC+KPJKeIirTx2GLKzlAnkkb8yTC3QaXahFfrLXiqeusx2oC6 ep3SmvTWnmB4sN7rQzq8ou1WcSdSor7H++9YOzkrMYtb6tL/tSZ7/U03SoX/Wd5F gRgU74zPQ8Ps6IU2S+4L+g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1715880394; x= 1715966794; bh=8LDx7Cf4RT/ExUJrLeXJaIwmHTslW10/HrV8BoCDq9Q=; b=i XaWsRCnKrAIx2VUXxD7v/rt+k9nb49nA4gWIKHbs+k3f+vAJ5fLyjwPllEfML+PE FoF69KTBfPhIxhwwmtOPG50un1JX9vEyomFHJnPfKxvPq7g/H1MDZY9SrDfC4Dqu ch+AaW41hsz5LdhYsanoSe3IA73ccfAUkGufM+bNIgB6tMR2HS0tJCLJXyQq4a2H +1n0HEGlLh+gSIWY12ArqTat5pDoT+pVCyCsDZw2Cg/rstBMsiB79ka1EWr1IsdM lx/scjEL/8zFbpHy02KLpnCGN1FD4WWxWOs6K/1I2JSoZcUVTw3C9pbV4D4hIjGW l+hIvHcO2PUICVgH5kCig== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdehuddgudduudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeenucfhrhhomhepffhm ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg htthgvrhhnpeetudeljeegheetgfehgeejkeeuhedvveeikeeufedtvddtveefhfdvveeg udejheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe gumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 16 May 2024 13:26:33 -0400 (EDT) Content-Language: en-US In-Reply-To: <86bk56jhsp.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285177 Archived-At: On 16/05/2024 11:13, Eli Zaretskii wrote: >> Cc: dmitry@gutov.dev, juri@linkov.net >> From: Spencer Baugh >> Date: Wed, 15 May 2024 16:26:50 -0400 >> >> >> try-completion and choose-completion have different behavior; with the >> emacs22 completion style, the former preserves the text after point >> (while ignoring it), whereas the latter deletes the text after point. >> >> 1. emacs -Q >> >> 2. In scratch, type "inhibit-asdf" and move point to after the "-" >> >> 3. Type "q" and M- >> The buffer now contains "inhibit-quitasdf", because the emacs22 style >> ignored the text after point and completed on "inhibit-q". >> >> 4. C-/ C-/ to change the buffer back to "inhibit-asdf" >> >> 5. M- >> The *Completions* buffer will be displayed, containing among others >> "inhibit-quit" as a completion, because the emacs22 style ignored the >> text after point and completed on "inhibit-". >> >> 6. Use M- and M- to select and choose "inhibit-quit" >> The buffer now contains "inhibit-quit". >> >> The two ways of selecting completions should behave the same. >> >> I suggest that the behavior of not deleting the text after point is >> better. The emacs22 style takes care to not delete the text after point >> in try-completion and in completion cycling; we should take similar care >> in choose-completion. > > If making these two ways consistent means we need to change the > behavior of emacs22 style of completion, then I'm sorry, but we cannot > do that. This style is a legacy style, and is there to provide the > legacy behavior for those who need it. I don't think that would be required exactly. The problem here (IIUC) is that completion behaves differently with the emacs22 style depending on whether the execution path went through choose-completion (which is not a method of completion style but a common subroutine) or not (when completion--do-completion performed expansion).