From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#27897: [PATCH] 25.1; Add REGION-NONCONTIGUOUS-P arg to other replace.el commands Date: Wed, 18 Apr 2018 16:25:54 -0700 (PDT) Message-ID: <37626ae6-22bd-43ca-80b9-5ba7e21d599e@default> References: <6168a7c3-dfa3-4894-8fb7-b2e6e9550dab@default> <1a732915-3277-45a0-b5fd-9e4e19efe2e9@default> <87o9igp4zj.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1524093908 25023 195.159.176.226 (18 Apr 2018 23:25:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 18 Apr 2018 23:25:08 +0000 (UTC) Cc: 27897@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 19 01:25:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8wRj-0006L6-SX for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Apr 2018 01:25:04 +0200 Original-Received: from localhost ([::1]:59147 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8wTo-0003ls-D8 for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Apr 2018 19:27:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48174) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8wTh-0003lD-NA for bug-gnu-emacs@gnu.org; Wed, 18 Apr 2018 19:27:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8wTe-0007Wm-GI for bug-gnu-emacs@gnu.org; Wed, 18 Apr 2018 19:27:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51908) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f8wTe-0007WQ-BO for bug-gnu-emacs@gnu.org; Wed, 18 Apr 2018 19:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f8wTe-0000Wf-0f for bug-gnu-emacs@gnu.org; Wed, 18 Apr 2018 19:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Apr 2018 23:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27897 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27897-submit@debbugs.gnu.org id=B27897.15240939651954 (code B ref 27897); Wed, 18 Apr 2018 23:27:01 +0000 Original-Received: (at 27897) by debbugs.gnu.org; 18 Apr 2018 23:26:05 +0000 Original-Received: from localhost ([127.0.0.1]:59805 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8wSj-0000VR-1Q for submit@debbugs.gnu.org; Wed, 18 Apr 2018 19:26:05 -0400 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:36236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8wSh-0000Uy-IA for 27897@debbugs.gnu.org; Wed, 18 Apr 2018 19:26:04 -0400 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w3INPvOu003549; Wed, 18 Apr 2018 23:25:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=v5HjBl71yexhEWm19L05GIXeYgvIKXUjFSw+oduxxZk=; b=YwdjUBzyKbiN/5Eg3A7idP9N+0jwxDuV6rAQqdSmE7Fq+TaZBUZCaPYHJhqUg7Su9d0A fZ2/mn0v9Bi7bpbHZrwOJGi+kVWDX2FwsYhdLN5bst5bjo99ZVyofn3R1AymRPho29ZM xoSbc2dslys0Jet1HwEdLO7A66ERX3druBXkgPRCmjHMsxMuRswHcQDPdmTb1Rhn0bxv fVZl/wn6iqujzouCgEbZ+MxsL4+1CGQBCdPtzyBC92qN1odnDOSImv01mF8k1VFsf1H0 1rnNFHb7ZgrCoiUYh4W4BKMXMWiGGEl4ZoV7T4cU2PE36YndcwoQKYIVwdzomG38wuod hQ== Original-Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2120.oracle.com with ESMTP id 2hdrxnd0c2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 18 Apr 2018 23:25:57 +0000 Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w3INPurP031518 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 18 Apr 2018 23:25:56 GMT Original-Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w3INPuVK008115; Wed, 18 Apr 2018 23:25:56 GMT In-Reply-To: <87o9igp4zj.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4678.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8867 signatures=668698 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=776 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1804180209 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145589 Archived-At: > > -(defun query-replace-regexp-eval (regexp to-expr &optional delimited > start end) > > +(defun query-replace-regexp-eval (regexp to-expr &optional delimited > start end region-noncontiguous-p) > > -(defun map-query-replace-regexp (regexp to-strings &optional n start > end) > > +(defun map-query-replace-regexp (regexp to-strings &optional n start > end region-noncontiguous-p) >=20 > But why not to add the arg backward like in all other commands? PLEASE DO, here and elsewhere where it is missing, wherever it makes sense. I'm having enough trouble just getting REGION-NONCONTIGUOUS-P added. ;-) [And getting arguments described in doc strings (bug #31207). I was afraid that someone might even complain that I added some rudimentary mention of other args in this patch. But I tried to sneak that in anyway. ;-)] And some of the commands I added REGION-NONCONTIGUOUS-P to already had BACKWARD, while others did not. Should we assume that whoever did that did it on purpose and wisely? Dunno. My purpose here was not to fix missing BACKWARD, but if you want to think about that and take care of it, please do - that would be great, along with applying my patch for REGION-NONCONTIGUOUS-P. I have the impression that someone added some stuff here and there without bothering to think more about it and doing it more systematically. But maybe not; maybe there are good reasons why they did what they did. For REGION-NONCONTIGUOUS-P, at least, it seems clear to me that it is useful everywhere I added it.