From: Drew Adams <drew.adams@oracle.com>
To: Juri Linkov <juri@linkov.net>
Cc: 27897@debbugs.gnu.org
Subject: bug#27897: [PATCH] 25.1; Add REGION-NONCONTIGUOUS-P arg to other replace.el commands
Date: Wed, 18 Apr 2018 16:25:54 -0700 (PDT) [thread overview]
Message-ID: <37626ae6-22bd-43ca-80b9-5ba7e21d599e@default> (raw)
In-Reply-To: <87o9igp4zj.fsf@mail.linkov.net>
> > -(defun query-replace-regexp-eval (regexp to-expr &optional delimited
> start end)
> > +(defun query-replace-regexp-eval (regexp to-expr &optional delimited
> start end region-noncontiguous-p)
> > -(defun map-query-replace-regexp (regexp to-strings &optional n start
> end)
> > +(defun map-query-replace-regexp (regexp to-strings &optional n start
> end region-noncontiguous-p)
>
> But why not to add the arg backward like in all other commands?
PLEASE DO, here and elsewhere where it is missing, wherever
it makes sense.
I'm having enough trouble just getting REGION-NONCONTIGUOUS-P
added. ;-)
[And getting arguments described in doc strings (bug #31207).
I was afraid that someone might even complain that I added
some rudimentary mention of other args in this patch. But
I tried to sneak that in anyway. ;-)]
And some of the commands I added REGION-NONCONTIGUOUS-P to
already had BACKWARD, while others did not. Should we
assume that whoever did that did it on purpose and wisely?
Dunno. My purpose here was not to fix missing BACKWARD,
but if you want to think about that and take care of it,
please do - that would be great, along with applying my
patch for REGION-NONCONTIGUOUS-P.
I have the impression that someone added some stuff here
and there without bothering to think more about it and
doing it more systematically. But maybe not; maybe there
are good reasons why they did what they did. For
REGION-NONCONTIGUOUS-P, at least, it seems clear to me
that it is useful everywhere I added it.
next prev parent reply other threads:[~2018-04-18 23:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 4:37 bug#27897: 25.1; Add REGION-NONCONTIGUOUS-P arg to other replace.el commands Drew Adams
2018-04-17 21:53 ` Drew Adams
2018-04-18 21:05 ` bug#27897: [PATCH] " Drew Adams
2018-04-18 21:41 ` Juri Linkov
2018-04-18 23:25 ` Drew Adams [this message]
2018-04-19 19:36 ` Juri Linkov
2018-04-19 19:48 ` Drew Adams
2018-04-19 20:12 ` Drew Adams
2018-04-19 20:27 ` Juri Linkov
2018-04-20 7:31 ` Eli Zaretskii
2018-04-21 19:59 ` Juri Linkov
2018-04-22 2:36 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37626ae6-22bd-43ca-80b9-5ba7e21d599e@default \
--to=drew.adams@oracle.com \
--cc=27897@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).