From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#14940: 24.3.50; [PATCH] enhancement for `dired-hide-details-mode' Date: Thu, 25 Jul 2013 17:57:28 -0700 (PDT) Message-ID: <375ded7a-1525-4e81-842c-748fa54d9812@default> References: <42783abc-5cff-41d5-8b9d-e7e641584cb6@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1374800288 10644 80.91.229.3 (26 Jul 2013 00:58:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 26 Jul 2013 00:58:08 +0000 (UTC) Cc: 14940@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 26 02:58:08 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1V2WMB-0005Wi-Lk for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Jul 2013 02:58:07 +0200 Original-Received: from localhost ([::1]:34963 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2WMB-0007cl-70 for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Jul 2013 20:58:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38654) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2WM7-0007bh-Ld for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2013 20:58:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2WM6-0005hN-IB for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2013 20:58:03 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55741) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2WM6-0005gd-Ep for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2013 20:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1V2WM5-00085p-NH for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2013 20:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Jul 2013 00:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14940 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 14940-submit@debbugs.gnu.org id=B14940.137480026431068 (code B ref 14940); Fri, 26 Jul 2013 00:58:01 +0000 Original-Received: (at 14940) by debbugs.gnu.org; 26 Jul 2013 00:57:44 +0000 Original-Received: from localhost ([127.0.0.1]:50057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V2WLm-000851-QR for submit@debbugs.gnu.org; Thu, 25 Jul 2013 20:57:43 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:41016) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V2WLi-00084i-TH for 14940@debbugs.gnu.org; Thu, 25 Jul 2013 20:57:40 -0400 Original-Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r6Q0vVm3007330 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 26 Jul 2013 00:57:32 GMT Original-Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r6Q0vTmQ024451 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 26 Jul 2013 00:57:30 GMT Original-Received: from abhmt104.oracle.com (abhmt104.oracle.com [141.146.116.56]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r6Q0vTTR014506; Fri, 26 Jul 2013 00:57:29 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.7 (607090) [OL 12.0.6668.5000 (x86)] X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:76661 Archived-At: > > 1. Users can decide whether the initial hide/show state of new Dired > > buffers reflects the last chosen state for a Dired buffer. This is > > decided by option `dired-hide-details-propagate'. Non-nil means > > propagate the last chosen state as the initial state of a new Dired > > buffer. >=20 > > 2. If `dired-hide-details-propagate' is nil, or if the user has not > > yet explicitly changed any Dired hide/show state, then option > > `dired-hide-details-initially' defines the initial state of a new > > Dired buffer. IOW, it specifies what the "last" state defaults to. >=20 > Hmm... couldn't we merge those two configuration variables? I supppose you mean shouldn't, not couldn't. > Here's the idea: > - Rename dired-hide-details-initially to dired-hide-details-default-mode, > a new (global) minor mode which determines how new dired buffers show u= p. > - Make it so that toggling dired-hide-details-default-mode also toggles t= he > dired-hide-details-mode in the current buffer. > This way, instead of setting dired-hide-details-propagate to t, users > can simply use dired-hide-details-default-mode instead of > dired-hide-details-mode. I see no advantage, only disadvantage. User options are generally the plac= e for default user settings. Why have two minor modes here? I might be missing something, but to my mind that only confuses users and offers no advantage. We should stick to a single command and its key binding, and not make users jump through hoops (yes, including changing key bindings) to choose the def= ault behavior they want (wrt initial hide/show and wrt propagation). And if the same key and command are used (not two different mode commands), a user can easily toggle the option value at any time and have the behavior change - no fiddling with different commands or rebinding keys. But if the *same* behavior is offered by your proposal as by mine, and if users are not additionally bothered by your proposal, then I guess I don't see a problem with it. (That's an if.) IMO: 1. The out-of-the-box default behavior should be as I described. 2. Users should be able to set their own preferred default behavior persistently. To me, that means a user option. In any case, it means not having to toggle anything interactively just to get the preferred behavior as the saved one. 3. If the rest of the behavior I described is also provided, no problem. In sum, it's the behavior I'm interested in. If the behavior is intact then I don't care much how you decide to implement it. The code I sent is in Dired+ at least, so it is anyway available to users who choose it, should you decide it is not the behavior you want for vanilla Emacs. Obviously I would prefer that (a) everyone benefit from this feature and (b) I can then remove it from Dired+. If you implement something different then I will see whether I like its behavior enough to remove what I have now in Dired+. If you think I am missing something, please fill me in. > Your code often exceeds the 80 columns limit. Often? Four of the 113 lines are longer than 80 chars (83, 84, 84, 85). The longest line in dired.el is 103 chars!, both before and after patch. The longest line in the patch I sent is 85 chars. But feel free to shorten any lines you like.