From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#47699: [PATCH] Improve completion-list-mode-map Date: Sun, 11 Apr 2021 10:50:15 +0000 Message-ID: <3755fe92dc6a74421fa9@heytings.org> References: <3755fe92dcbf588701ae@heytings.org> <83o8el46rs.fsf@gnu.org> <3755fe92dc6b58671717@heytings.org> <83k0p944s5.fsf@gnu.org> <3755fe92dc4a9ba66a0b@heytings.org> <83im4t43ul.fsf@gnu.org> <3755fe92dc626b55646c@heytings.org> <83eefh3y0r.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17139"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47699@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 11 12:51:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVXgT-0004Lk-Q7 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Apr 2021 12:51:17 +0200 Original-Received: from localhost ([::1]:59978 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVXgS-0003kq-9b for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Apr 2021 06:51:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33862) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVXgE-0003kA-Cq for bug-gnu-emacs@gnu.org; Sun, 11 Apr 2021 06:51:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42532) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lVXgE-0008Eg-5d for bug-gnu-emacs@gnu.org; Sun, 11 Apr 2021 06:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lVXgE-0006yc-4Z for bug-gnu-emacs@gnu.org; Sun, 11 Apr 2021 06:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Apr 2021 10:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47699 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47699-submit@debbugs.gnu.org id=B47699.161813821826766 (code B ref 47699); Sun, 11 Apr 2021 10:51:02 +0000 Original-Received: (at 47699) by debbugs.gnu.org; 11 Apr 2021 10:50:18 +0000 Original-Received: from localhost ([127.0.0.1]:54078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVXfW-0006xd-Fm for submit@debbugs.gnu.org; Sun, 11 Apr 2021 06:50:18 -0400 Original-Received: from heytings.org ([95.142.160.155]:34170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVXfU-0006xT-NT for 47699@debbugs.gnu.org; Sun, 11 Apr 2021 06:50:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1618138215; bh=SP4R8Vjp5QiyiL1OJ2I7jufFiskWo7+pFROhS5ObetY=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=VUoFhnjLrcI2U1qB2H4V8lyRKjwhai5C6x0Dlt9bHRxI++sOdCvCx+p1e+IV5ZAK0 RB5CiDYTNbFFB2/9czTY6Ti/ThClVWdC6LqOUvgZeTaTK8JBpgUP9XNY3OeY6Onsay JvjMGHVJnRbDFJ28cVIxAz+8P4JJ9t4aSfpizXzu5aHFo8iny2cpemAkbVKjE2MYp9 hoNVARKD4/Oq1NX2V9CB7LoTn0e0ke9enFdT5hrx1KjizNbJ2kasRcv7/rXL7464Ja On0a+bMvZOeTj6IrmnCafBiCtsbwcsOD6ZsRWJfyS6KluBL9VsB1f0eZJ/R5JuLnp/ nUSj7MuPC/lnA== In-Reply-To: <83eefh3y0r.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203840 Archived-At: >> If you agreed with it, I would be pleased to add symmetry there. I use >> M-c for both purposes locally: >> >> (define-key minibuffer-local-map (kbd "M-c") 'switch-to-completions) >> (define-key completion-list-mode-map (kbd "M-c") 'other-window) > > I don't think other-window is the right command, because with some > window configurations it might land you in the wrong window. It has to > be a command that lands you back in the mini-window. > In practice other-window works well there, but now that you mention it, I agree with you that it's not safe enough. What about: (defun switch-to-minibuffer () "Select the minibuffer window." (interactive) (when (active-minibuffer-window) (select-window (active-minibuffer-window))))