From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#47699: [PATCH] Improve completion-list-mode-map Date: Sun, 11 Apr 2021 18:30:03 +0000 Message-ID: <3755fe92dc3b94023c91@heytings.org> References: <3755fe92dcbf588701ae@heytings.org> <83o8el46rs.fsf@gnu.org> <3755fe92dc6b58671717@heytings.org> <83k0p944s5.fsf@gnu.org> <3755fe92dc4a9ba66a0b@heytings.org> <83im4t43ul.fsf@gnu.org> <3755fe92dc626b55646c@heytings.org> <83eefh3y0r.fsf@gnu.org> <3755fe92dc6a74421fa9@heytings.org> <83czv13q3l.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="SE0LF1FiTY" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14589"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47699@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 11 20:31:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVere-0003hF-JE for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Apr 2021 20:31:18 +0200 Original-Received: from localhost ([::1]:55630 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVerd-0004vr-Iu for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Apr 2021 14:31:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49206) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVerO-0004sN-LH for bug-gnu-emacs@gnu.org; Sun, 11 Apr 2021 14:31:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44320) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lVerO-0006X3-EU for bug-gnu-emacs@gnu.org; Sun, 11 Apr 2021 14:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lVerO-0003eL-AN for bug-gnu-emacs@gnu.org; Sun, 11 Apr 2021 14:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Apr 2021 18:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47699 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47699-submit@debbugs.gnu.org id=B47699.161816580713960 (code B ref 47699); Sun, 11 Apr 2021 18:31:02 +0000 Original-Received: (at 47699) by debbugs.gnu.org; 11 Apr 2021 18:30:07 +0000 Original-Received: from localhost ([127.0.0.1]:55865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVeqU-0003d6-Ow for submit@debbugs.gnu.org; Sun, 11 Apr 2021 14:30:07 -0400 Original-Received: from heytings.org ([95.142.160.155]:34622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVeqT-0003bz-BV for 47699@debbugs.gnu.org; Sun, 11 Apr 2021 14:30:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1618165804; bh=ybMtZFtGA4EHRvZxpm8ptiTq8fSNTpCYCxHUsy0UxG4=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=TQLCZTar6jSlBtseLk0M1Ke9inqs+zcCl9bzEeVRQucQyQlmueZDR4OwqlNiZHjxp FgqOUmzDKRpUEPUG6vE68Bwr25GxX+noKdcAxSo5WWBnkjYmZo52uwxf66uVyNXiCw ueoo4z2vTUGzGd3BjxoE/4KuqkpD486TqB7v8y1VSN8adkKiQqB4y3D/VKBK1FIprI QmrvKB2/1W7uuE++OZ6TRGtddsGeNUho3EK1y2QMG2NRV8PSdFs7B1Qs4/AnzfxGS0 GZIJN5LqGuVrjo+050SfnJexjkvLL4NH1LrR0r0bHujXKLszZFvZ4ACOZoFKvT1mvf 9vwqq7m0iaxgQ== In-Reply-To: <83czv13q3l.fsf@gnu.org> Content-ID: <3755fe92dcc50e470743@heytings.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203856 Archived-At: --SE0LF1FiTY Content-Type: text/plain; charset=us-ascii; format=flowed Content-ID: <3755fe92dcf06f5dc3a0@heytings.org> > > LGTM, thanks. Did you test this with minibuffer-only frames? > Thanks. Here is the updated patch. I tested it with minibuffer-only frames, and it seems to work. Are you sure that it's okay to rebind M-c in minibuffer-local-completion-map? It's a good mnemonic for "completion", but it hides the capitalize-word binding, that users might possibly want to use there (I don't, it's only when thinking about this patch that I realized this). Another option would be M-g, which would not hide anything that is possibly useful in the minibuffer, and is still a mnemonic of "goto". --SE0LF1FiTY Content-Type: text/x-diff; name=Improve-completion-list-mode-map.patch; charset=us-ascii Content-Transfer-Encoding: base64 Content-ID: <3755fe92dc6d37db49c9@heytings.org> Content-Description: Content-Disposition: attachment; filename=Improve-completion-list-mode-map.patch RnJvbSAyYWY3OWYyMDRjYmIzMGYzNjcyMmI5MTJlMWFjMGFmZjA2MDI4M2Jk IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBTdW4sIDExIEFw ciAyMDIxIDE4OjEwOjI5ICswMDAwDQpTdWJqZWN0OiBbUEFUQ0hdIEltcHJv dmUgY29tcGxldGlvbi1saXN0LW1vZGUtbWFwDQoNCiogbGlzcC9zaW1wbGUu ZWwgKGNvbXBsZXRpb24tbGlzdC1tb2RlLW1hcCk6IE1ha2Ugc3BlY2lhbC1t b2RlLW1hcCBpdHMNCnBhcmVudCwgdW5iaW5kIHRoZSAnZycgcmV2ZXJ0IGtl eSwgYWRkIHRoZSAnbicgYW5kICdwJyBrZXlzIGZvcg0KbmV4dC1jb21wbGV0 aW9uIGFuZCBwcmV2aW91cy1jb21wbGV0aW9uLCBhbmQgdGhlIE0tYyBrZXkg Zm9yDQpzd2l0Y2gtdG8tbWluaWJ1ZmZlci4NCihzd2l0Y2gtdG8tbWluaWJ1 ZmZlcik6IE5ldyBmdW5jdGlvbg0KDQoqIGxpc3AvbWluaWJ1ZmZlci5lbCAo bWluaWJ1ZmZlci1sb2NhbC1jb21wbGV0aW9uLW1hcCk6IEFkZCB0aGUgTS1j IGtleQ0KZm9yIHN3aXRjaC10by1jb21wbGV0aW9uLg0KLS0tDQogbGlzcC9t aW5pYnVmZmVyLmVsIHwgIDEgKw0KIGxpc3Avc2ltcGxlLmVsICAgICB8IDEx ICsrKysrKysrKysrDQogMiBmaWxlcyBjaGFuZ2VkLCAxMiBpbnNlcnRpb25z KCspDQoNCmRpZmYgLS1naXQgYS9saXNwL21pbmlidWZmZXIuZWwgYi9saXNw L21pbmlidWZmZXIuZWwNCmluZGV4IDVmNTk0Njc5Y2EuLmQxOGEwZjc0NjEg MTAwNjQ0DQotLS0gYS9saXNwL21pbmlidWZmZXIuZWwNCisrKyBiL2xpc3Av bWluaWJ1ZmZlci5lbA0KQEAgLTI0MTMsNiArMjQxMyw3IEBAIG1pbmlidWZm ZXItbG9jYWwtY29tcGxldGlvbi1tYXANCiAgICAgKGRlZmluZS1rZXkgbWFw ICI/IiAnbWluaWJ1ZmZlci1jb21wbGV0aW9uLWhlbHApDQogICAgIChkZWZp bmUta2V5IG1hcCBbcHJpb3JdICdzd2l0Y2gtdG8tY29tcGxldGlvbnMpDQog ICAgIChkZWZpbmUta2V5IG1hcCAiXE0tdiIgICdzd2l0Y2gtdG8tY29tcGxl dGlvbnMpDQorICAgIChkZWZpbmUta2V5IG1hcCAiXE0tYyIgICdzd2l0Y2gt dG8tY29tcGxldGlvbnMpDQogICAgIG1hcCkNCiAgICJMb2NhbCBrZXltYXAg Zm9yIG1pbmlidWZmZXIgaW5wdXQgd2l0aCBjb21wbGV0aW9uLiIpDQogDQpk aWZmIC0tZ2l0IGEvbGlzcC9zaW1wbGUuZWwgYi9saXNwL3NpbXBsZS5lbA0K aW5kZXggOTk5NzU1YTY0Mi4uMjMyMTc3MjA0ZCAxMDA2NDQNCi0tLSBhL2xp c3Avc2ltcGxlLmVsDQorKysgYi9saXNwL3NpbXBsZS5lbA0KQEAgLTg3Njcs NiArODc2Nyw4IEBAIHNldC12YXJpYWJsZQ0KIA0KIChkZWZ2YXIgY29tcGxl dGlvbi1saXN0LW1vZGUtbWFwDQogICAobGV0ICgobWFwIChtYWtlLXNwYXJz ZS1rZXltYXApKSkNCisgICAgKHNldC1rZXltYXAtcGFyZW50IG1hcCBzcGVj aWFsLW1vZGUtbWFwKQ0KKyAgICAoZGVmaW5lLWtleSBtYXAgImciIG5pbCkg OzsgVGhlcmUncyBub3RoaW5nIHRvIHJldmVydCBmcm9tLg0KICAgICAoZGVm aW5lLWtleSBtYXAgW21vdXNlLTJdICdjaG9vc2UtY29tcGxldGlvbikNCiAg ICAgKGRlZmluZS1rZXkgbWFwIFtmb2xsb3ctbGlua10gJ21vdXNlLWZhY2Up DQogICAgIChkZWZpbmUta2V5IG1hcCBbZG93bi1tb3VzZS0yXSBuaWwpDQpA QCAtODc3OCw2ICs4NzgwLDkgQEAgY29tcGxldGlvbi1saXN0LW1vZGUtbWFw DQogICAgIChkZWZpbmUta2V5IG1hcCBbYmFja3RhYl0gJ3ByZXZpb3VzLWNv bXBsZXRpb24pDQogICAgIChkZWZpbmUta2V5IG1hcCAicSIgJ3F1aXQtd2lu ZG93KQ0KICAgICAoZGVmaW5lLWtleSBtYXAgInoiICdraWxsLWN1cnJlbnQt YnVmZmVyKQ0KKyAgICAoZGVmaW5lLWtleSBtYXAgIm4iICduZXh0LWNvbXBs ZXRpb24pDQorICAgIChkZWZpbmUta2V5IG1hcCAicCIgJ3ByZXZpb3VzLWNv bXBsZXRpb24pDQorICAgIChkZWZpbmUta2V5IG1hcCAiXE0tYyIgJ3N3aXRj aC10by1taW5pYnVmZmVyKQ0KICAgICBtYXApDQogICAiTG9jYWwgbWFwIGZv ciBjb21wbGV0aW9uIGxpc3QgYnVmZmVycy4iKQ0KIA0KQEAgLTkwNjcsNiAr OTA3MiwxMiBAQCBzd2l0Y2gtdG8tY29tcGxldGlvbnMNCiAgICAgICA7OyBG SVhNRTogUGVyaGFwcyB0aGlzIHNob3VsZCBiZSBkb25lIGluIGBtaW5pYnVm ZmVyLWNvbXBsZXRpb24taGVscCcuDQogICAgICAgKHdoZW4gKGJvYnApDQog CShuZXh0LWNvbXBsZXRpb24gMSkpKSkpDQorDQorKGRlZnVuIHN3aXRjaC10 by1taW5pYnVmZmVyICgpDQorICAiU2VsZWN0IHRoZSBtaW5pYnVmZmVyIHdp bmRvdy4iDQorICAoaW50ZXJhY3RpdmUpDQorICAod2hlbiAoYWN0aXZlLW1p bmlidWZmZXItd2luZG93KQ0KKyAgICAoc2VsZWN0LXdpbmRvdyAoYWN0aXZl LW1pbmlidWZmZXItd2luZG93KSkpKQ0KIAwNCiA7OzsgU3VwcG9ydCBrZXli b2FyZCBjb21tYW5kcyB0byB0dXJuIG9uIHZhcmlvdXMgbW9kaWZpZXJzLg0K IA0KLS0gDQoyLjMwLjINCg0K --SE0LF1FiTY--