From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#48337: Fwd: 28.0.50; Emacs crashing randomly (possibly minibuffer activity related) Date: Thu, 13 May 2021 09:54:52 +0200 Message-ID: <37291ae0-11cb-c817-cf26-b90ad50bfaaa@gmx.at> References: <87tunasd2u.fsf@linaro.org> <83fsyu57oj.fsf@gnu.org> <838s4l5uld.fsf@gnu.org> <83zgx14cal.fsf@gnu.org> <83cztx3v04.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19924"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48337@debbugs.gnu.org, alex.bennee@linaro.org To: Alan Mackenzie , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 13 09:56:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lh6Ce-000547-59 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 May 2021 09:56:16 +0200 Original-Received: from localhost ([::1]:55036 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lh6Cd-0000E8-79 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 May 2021 03:56:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57750) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lh6CQ-0000BG-7e for bug-gnu-emacs@gnu.org; Thu, 13 May 2021 03:56:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57948) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lh6CP-0006h2-SV for bug-gnu-emacs@gnu.org; Thu, 13 May 2021 03:56:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lh6CP-0004OM-MS for bug-gnu-emacs@gnu.org; Thu, 13 May 2021 03:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 May 2021 07:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48337 X-GNU-PR-Package: emacs Original-Received: via spool by 48337-submit@debbugs.gnu.org id=B48337.162089250416809 (code B ref 48337); Thu, 13 May 2021 07:56:01 +0000 Original-Received: (at 48337) by debbugs.gnu.org; 13 May 2021 07:55:04 +0000 Original-Received: from localhost ([127.0.0.1]:41261 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lh6BT-0004N3-Ox for submit@debbugs.gnu.org; Thu, 13 May 2021 03:55:03 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:54369) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lh6BR-0004MP-SV for 48337@debbugs.gnu.org; Thu, 13 May 2021 03:55:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1620892493; bh=o8+CI+6ZazMmdw1sb7kANV1IRdiC3GVWFWLu6X+pj4o=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=TJR3obizPhHk5QGA+lyjv9UP/0wAIh3tUsxnVHe50hmJ0zpfVprb8O2Mf4+FDqjd7 QhWw39izCi2UMQbuvXLh3Iek72j2HCySN65dhskXk5yDBHPvJw8LcDCeqXCSe+T50k FmpLdtUv7spQPKVDubE8VLL6DblMoQYTx/Ya+tTU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([213.142.96.164]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MXXyP-1m0Yz43Bh1-00Z1xo; Thu, 13 May 2021 09:54:53 +0200 In-Reply-To: Content-Language: en-US X-Provags-ID: V03:K1:P/CGiWLlSXHLBpl2MLNOZvMf6gxv6NziYWSV3aRPYLXCHKYASCe 2I+hyheErexktaRbIHreFU44tYymWagem1C5OorWqJCecKMyPg82peBuPqi6ZasP+L7avkG 9qFbgfdRz+8ojpRgamBu+FQOZxT5VYwGX2QkfTPm7UDWY8rCMnq4Q/chWMsQNmVzB8OHf2o uo/U3LXUUJ89OkBc4Cj9g== X-UI-Out-Filterresults: notjunk:1;V03:K0:FMPedXl6GjU=:olMynqlD4uFrujb5htNg2E CxntcMYSDAsLLLYlKGWcsApdxpFVQ/w50Nza6ntpgE9xNZ9Pu7ckqp+NbGONO8iGUqDOwBP8u gVG6J/gSlWCbW9DrYw/Opg9a6LKPLStAEPUH0GWYNaqy1AvpTrBfl4iIWIzWcUh06ej+d7YEU gnWU2adxiehpsuhFoadngfog2vrS9A2C48G9m+d37zcA3rZN4H4QF0HgPr8dZxhWsAcMOY85j vkhvlBrkCwb7OoQ9Znk/FxQnIxdbKflYQ/x0FFsExpdi8ELJ/TeJsihymlEz4+8UNMCuDzISS YI0PmdStfqqLGvLB0r6RLklVWy2yvMWoWTCINgezXMnRzS1qe7NeA8hcGwRVNt/w2oa05ZCBi c0PfxvhD7/XCTyCKDG3EWz66+yvLpng6fFk7E+2sruBe50GZ+EtazjOWIhLF22oDIy05hn6NM cpqYLWZmDNUxXmtGC9gIL0h4gNr1OSbyKgWxiqnVxKalSCdIRbvbn+EDh2xiiPB57CTdTT27W Dfs5DuHcHiUOf5MScBIoXu0hzzvC2Lwkm1AZeeNhsFJkSSrZj9tD2YKJM1zj6O6VppJM9TSRe WygNueY1tCFiV5ON9rO8dolBs64sSkU21Kis1H0G+Y9w0Drzrz/cmDXUULO6vD5E1BodqUUKe FgU831jn+6I09JMz3TqWSUea30+ZeJxF7hyY9VisfUVxw9ZT1eVCLFv22W/Cw9HUOZNpBpxVS K5nDGVFrRBlS9nsSvonBvx0Rt4GPMtwFMuc61MvRW+koBu01qloBl3lkrF8ru9kFb3war6m9 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206404 Archived-At: > The deeper cause of the bug is that calling buffer-list-update-hook > simply doesn't belong in record-window-buffer. That hook should be > called when the buffer list changes, not when a window's current buffer > gets "recorded". > > So, as the main fix, I propose moving the call of buffer-list-update-hook > to (some of) the places where record-window-buffer gets called, those > places where the buffer list changes. There are exactly two such places, > both in window.c. This will prevent the chain of events in read_minibuf > outlined above. Alan, please take one step back and reconsider. IIUC you added the `record-window-buffer' call to read_minibuf, added the DO-MINIBUF argument to `record-window-buffer' and now decide that `buffer-list-update-hook' doesn't belong into `record-window-buffer'. Aren't you putting the cart before the horse? That decision might be correct but still constitutes a change that affects all applications running `buffer-list-update-hook'. martin