From: martin rudalics <rudalics@gmx.at>
To: Alan Mackenzie <acm@muc.de>, Eli Zaretskii <eliz@gnu.org>
Cc: 48337@debbugs.gnu.org, alex.bennee@linaro.org
Subject: bug#48337: Fwd: 28.0.50; Emacs crashing randomly (possibly minibuffer activity related)
Date: Thu, 13 May 2021 09:54:52 +0200 [thread overview]
Message-ID: <37291ae0-11cb-c817-cf26-b90ad50bfaaa@gmx.at> (raw)
In-Reply-To: <YJwkTQGPy/y1i+NS@ACM>
> The deeper cause of the bug is that calling buffer-list-update-hook
> simply doesn't belong in record-window-buffer. That hook should be
> called when the buffer list changes, not when a window's current buffer
> gets "recorded".
>
> So, as the main fix, I propose moving the call of buffer-list-update-hook
> to (some of) the places where record-window-buffer gets called, those
> places where the buffer list changes. There are exactly two such places,
> both in window.c. This will prevent the chain of events in read_minibuf
> outlined above.
Alan, please take one step back and reconsider. IIUC you added the
`record-window-buffer' call to read_minibuf, added the DO-MINIBUF
argument to `record-window-buffer' and now decide that
`buffer-list-update-hook' doesn't belong into `record-window-buffer'.
Aren't you putting the cart before the horse? That decision might be
correct but still constitutes a change that affects all applications
running `buffer-list-update-hook'.
martin
next prev parent reply other threads:[~2021-05-13 7:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87tunasd2u.fsf@linaro.org>
2021-05-10 19:30 ` bug#48337: Fwd: 28.0.50; Emacs crashing randomly (possibly minibuffer activity related) Alex Bennée
2021-05-10 19:34 ` bug#48337: Alex Bennée
2021-05-11 2:24 ` bug#48337: Fwd: 28.0.50; Emacs crashing randomly (possibly minibuffer activity related) Eli Zaretskii
2021-05-11 6:51 ` Alex Bennée
2021-05-11 8:23 ` Alex Bennée
2021-05-11 8:54 ` Alex Bennée
2021-05-11 12:21 ` Eli Zaretskii
2021-05-11 12:54 ` Alex Bennée
2021-05-11 13:42 ` Eli Zaretskii
2021-05-11 13:47 ` Eli Zaretskii
2021-05-11 19:45 ` Alan Mackenzie
2021-05-11 19:55 ` Eli Zaretskii
2021-05-12 18:54 ` Alan Mackenzie
2021-05-13 7:54 ` martin rudalics [this message]
2021-05-13 9:52 ` Alan Mackenzie
2021-05-13 11:54 ` Alan Mackenzie
2021-05-13 12:09 ` Alan Mackenzie
2021-05-14 15:20 ` Gregory Heytings
2021-05-14 16:05 ` Eli Zaretskii
2021-05-14 17:31 ` Gregory Heytings
2021-05-14 18:19 ` Eli Zaretskii
2021-05-15 9:45 ` Gregory Heytings
2021-05-11 20:14 ` Alan Mackenzie
2021-05-11 22:07 ` Alex Bennée
2021-05-14 16:31 ` Alan Mackenzie
2021-05-14 16:52 ` Alex Bennée
2021-05-14 18:40 ` Alan Mackenzie
2021-05-14 22:35 ` Alex Bennée
2021-05-15 12:00 ` Alan Mackenzie
2021-05-16 14:24 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37291ae0-11cb-c817-cf26-b90ad50bfaaa@gmx.at \
--to=rudalics@gmx.at \
--cc=48337@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=alex.bennee@linaro.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).