From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil Date: Fri, 06 Jan 2023 13:10:18 +0000 Message-ID: <371ba1d0be78fd6c921f@heytings.org> References: <87zgb5lx6y.fsf@oracle.com> <6c9d91cffcdbff97f034@heytings.org> <87lemot7ek.fsf@gmail.com> <0a62cbaeff1ee0497715@heytings.org> <226b32f79f7db2be1bbe@heytings.org> <226b32f79f65b964c636@heytings.org> <86sfgp5ihl.fsf@mail.linkov.net> <8dea9f3e0e993e0bd0a9@heytings.org> <83a62ww4bo.fsf@gnu.org> <371ba1d0be9671d4a3a4@heytings.org> <83v8lkujt0.fsf@gnu.org> <371ba1d0be87d64ed419@heytings.org> <83tu13vqlb.fsf@gnu.org> <371ba1d0bed233c2fbd3@heytings.org> <83pmbrvonx.fsf@gnu.org> <371ba1d0becbcd718fdb@heytings.org> <83mt6vvmxv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33583"; mail-complaints-to="usenet@ciao.gmane.io" Cc: kahatlen@gmail.com, 60411@debbugs.gnu.org, monnier@iro.umontreal.ca, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 06 14:11:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pDmV9-0008RP-4J for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 06 Jan 2023 14:11:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pDmUz-0004QJ-Uc; Fri, 06 Jan 2023 08:11:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDmUx-0004Ps-19 for bug-gnu-emacs@gnu.org; Fri, 06 Jan 2023 08:11:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pDmUw-0006Re-Cg for bug-gnu-emacs@gnu.org; Fri, 06 Jan 2023 08:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pDmUv-0002YZ-TR for bug-gnu-emacs@gnu.org; Fri, 06 Jan 2023 08:11:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Jan 2023 13:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60411 X-GNU-PR-Package: emacs Original-Received: via spool by 60411-submit@debbugs.gnu.org id=B60411.16730106219780 (code B ref 60411); Fri, 06 Jan 2023 13:11:01 +0000 Original-Received: (at 60411) by debbugs.gnu.org; 6 Jan 2023 13:10:21 +0000 Original-Received: from localhost ([127.0.0.1]:54031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDmUH-0002Xf-8i for submit@debbugs.gnu.org; Fri, 06 Jan 2023 08:10:21 -0500 Original-Received: from heytings.org ([95.142.160.155]:33262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDmUF-0002XX-Kh for 60411@debbugs.gnu.org; Fri, 06 Jan 2023 08:10:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1673010618; bh=ICNLU+BN0Y2X1BmGTCbXIgvBIoSEJCkYPrVkyduYYek=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=1ZYPIuDqtTEKF4sc4yt6xi8NZ6D53ufn0jZnvs05U5SdxA24RRuT0eSiz4byYG16E cn8tTCGNUEzSGNXNgpGjtC1L0jRKGiWTD5NvfWuSsor0zDei/HUPehb+pgcIwcFacE 5CchKSzNGpIXTlu0Xp3/jDYOy4FOoAYxMg5ThnjUn8DLBlcdcM11jwhvu/h6I0w2IM 7tpHihqFUoBez81QIzalNoyaXiBH+Ori8uTIQ4WrschsQNBCrw9P35xxyBgRM1R6V9 o/mnAkQpJj/4NLr2+DbOxUscyXJWPK8xO0gL220B9ELwM+H7ckzHYg/rxzGZBAjt5p DJTfKUmeb8Umw== In-Reply-To: <83mt6vvmxv.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252710 Archived-At: > > Didn't you just say that the difference between "first" and "next" is > "the first call"? Can't we make the logic be based on that instead of > assuming that the format produces an empty string under certain > conditions? > As far as I can see, no. What is also possible, if it's the condition that you don't like, is to insert that invisible line unconditionally, like this: diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index f47299bd0d..09125772f3 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -2275,6 +2275,10 @@ display-completion-list (with-current-buffer standard-output (goto-char (point-max)) + ;; Insert an invisible line, otherwise the first call to + ;; 'minibuffer-next-completion' might select the second + ;; completion candidate. See bug#60411. + (insert (propertize "\n" 'invisible t)) (when completions-header-format (insert (format completions-header-format (length completions)))) (completion--insert-strings completions group-fun)))