From: Dmitry Gutov <dgutov@yandex.ru>
To: Lars Ingebrigtsen <larsi@gnus.org>, Sam Steingold <sds@gnu.org>
Cc: 42966@debbugs.gnu.org
Subject: bug#42966: 28.0.50; vc-dir: wrong backend
Date: Fri, 16 Oct 2020 15:44:34 +0300 [thread overview]
Message-ID: <3708c3db-df78-1a50-857a-595f2412e284@yandex.ru> (raw)
In-Reply-To: <87d01imtwl.fsf@gnus.org>
On 16.10.2020 11:55, Lars Ingebrigtsen wrote:
> But:
>
> (catch 'found
> ;; First try: find a responsible backend. If this is for registration,
> ;; it must be a backend under which FILE is not yet registered.
> (dolist (backend vc-handled-backends)
> (and (vc-call-backend backend 'responsible-p file)
> (throw 'found backend))))
>
> This just goes through the backends and the first one that happens to be
> able to say "yes" wins. Shouldn't this instead go through all the
> backends, and if more than one says "yes", then choose the one with the
> most specific path?
>
> Looking at the code, that shouldn't be too hard to implement, because it
> seems like responsible-p returns the root path?
The code should be straightforward, but I'd like to see some performance
measurements: both for the local case, and for the remote one (Tramp).
The difference can be small, though, given that we already try a number
of other backends first (Git is near the end of vc-handled-backends; we
might want to change that, BTW).
next prev parent reply other threads:[~2020-10-16 12:44 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 15:15 bug#42966: 28.0.50; vc-dir: wrong backend Sam Steingold
2020-10-16 8:55 ` Lars Ingebrigtsen
2020-10-16 12:44 ` Dmitry Gutov [this message]
2020-10-16 14:41 ` Lars Ingebrigtsen
2020-10-16 14:44 ` Dmitry Gutov
2020-10-17 7:02 ` Lars Ingebrigtsen
2020-10-17 7:13 ` Lars Ingebrigtsen
2020-10-17 7:19 ` Lars Ingebrigtsen
2020-10-17 20:41 ` Dmitry Gutov
2020-10-18 8:26 ` Lars Ingebrigtsen
2020-10-17 20:44 ` Dmitry Gutov
2020-10-18 7:38 ` Michael Albinus
2020-10-23 23:53 ` Dmitry Gutov
2020-10-24 13:41 ` Michael Albinus
2020-10-24 19:42 ` Dmitry Gutov
2020-10-25 17:49 ` Michael Albinus
2020-10-26 14:29 ` Dmitry Gutov
2020-10-26 15:17 ` Michael Albinus
2020-10-26 20:12 ` bug#42966: (no subject) Lars Ingebrigtsen
2020-10-26 20:13 ` Lars Ingebrigtsen
2020-10-26 20:55 ` bug#42966: Dmitry Gutov
2020-10-26 21:02 ` bug#42966: Lars Ingebrigtsen
2020-10-26 21:44 ` bug#42966: Dmitry Gutov
2020-10-26 21:11 ` bug#42966: 28.0.50; vc-dir: wrong backend Dmitry Gutov
2020-10-18 8:32 ` Lars Ingebrigtsen
2020-10-16 15:35 ` Glenn Morris
2020-10-16 18:19 ` Dmitry Gutov
2020-10-17 6:06 ` Lars Ingebrigtsen
2020-10-17 20:01 ` Dmitry Gutov
2020-10-18 8:31 ` Lars Ingebrigtsen
2020-10-26 21:54 ` Glenn Morris
2020-10-26 21:58 ` Lars Ingebrigtsen
2020-10-26 22:14 ` Dmitry Gutov
2020-10-26 22:11 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3708c3db-df78-1a50-857a-595f2412e284@yandex.ru \
--to=dgutov@yandex.ru \
--cc=42966@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=sds@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).