From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Vinothan Shankar Newsgroups: gmane.emacs.bugs Subject: bug#33780: network-stream.el: network-stream-certificate always returns nil Date: Mon, 17 Dec 2018 19:02:08 +0000 Message-ID: <36f7918ec93135504092dc856a4490c846f6e947.camel@dracon.is> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1545074119 9225 195.159.176.226 (17 Dec 2018 19:15:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 17 Dec 2018 19:15:19 +0000 (UTC) User-Agent: Evolution 3.30.1-1 To: 33780@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 17 20:15:15 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYyMC-0002FS-GO for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Dec 2018 20:15:14 +0100 Original-Received: from localhost ([::1]:48588 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYyOI-0004Yi-V9 for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Dec 2018 14:17:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44740) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYyO4-0004W0-V7 for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2018 14:17:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gYyNy-0003uE-Fg for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2018 14:17:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47890) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gYyNy-0003ts-1u for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2018 14:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gYyNx-00082Z-Ss for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2018 14:17:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Vinothan Shankar Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Dec 2018 19:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 33780 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.154507419030854 (code B ref -1); Mon, 17 Dec 2018 19:17:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 17 Dec 2018 19:16:30 +0000 Original-Received: from localhost ([127.0.0.1]:52146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYyNR-00081Y-WF for submit@debbugs.gnu.org; Mon, 17 Dec 2018 14:16:30 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:58036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYyAD-0007fd-RL for submit@debbugs.gnu.org; Mon, 17 Dec 2018 14:02:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gYyA7-0007gZ-Mf for submit@debbugs.gnu.org; Mon, 17 Dec 2018 14:02:44 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:46493) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gYyA7-0007g2-HH for submit@debbugs.gnu.org; Mon, 17 Dec 2018 14:02:43 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYyA6-00029h-KP for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2018 14:02:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gYyA3-0007Tw-US for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2018 14:02:42 -0500 Original-Received: from e2i510.smtp2go.com ([103.2.141.254]:58529) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gYyA3-0007L4-4f for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2018 14:02:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=smtpservice.net; s=m3dcb0.a1-4.dyn; x=1545074259; h=Feedback-ID: X-Smtpcorp-Track:Date:To:From:Subject:Message-ID:Reply-To:Sender: List-Unsubscribe; bh=Pro8Ao0gpaI0Rs/qiByyU5zvKudPqoT3C9FIUEDIRog=; b=pae6DiJQ duYWhGHS3RRp2MflKuJAjW1zwCNK51elEW+sQdsxWJLwsz9SQ1frBh11+fyS6yYH5ogxmpmUaGAuK ElrAulqWIxGRcVwmIzFoHb+zSjlCMki6lKzwpYsAUQe2LAMGH5tQigIzABU64ZWr8/FgZ7tqcwOit txklYdjO5ZXKyLnfoyLOi3XBtY+4LF0y5Dunzxnboyx/5NHMraDQ0prCIJijlQBDoc/J70THxmauU vgCrIrX2DzsEJ0Ux+LqEZ3BHDu9ElzVWdWvEjAfmQuWDOXmUS2385+WXlfChZOZACasB06LRfnZSv ZAmSgE+py85/bgB57gcvSnhHew==; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dracon.is; i=@dracon.is; q=dns/txt; s=s157259; t=1545073359; h=from : subject : to : message-id : date; bh=Pro8Ao0gpaI0Rs/qiByyU5zvKudPqoT3C9FIUEDIRog=; b=cUPnO0+19IiUmvw1v1d91evg3Xv4vt4X/Frsv2vllrEgZf16Wj1kOUEqnIxqeNctpU2cRI O7w8dE8WGq+Pf+ybUHr+TBP6YEbjDQV9Ya0qC4fzCU62Qg0BmLuxsLH3jfRglLizm4sbFRcv YfcHNlTGF9mM/w2/EfgGraZ+5RAtwQy01meadTaBdtdMNYUvtzGkKvOcNQBQ2GyOUISCiPjW Y2n3HXVSEaFUadfNvwPGyEWn4/kGOeMvBk5m3JngLu3OEh4XGeof4TDdbRbp8MpDMjhtW7Z0 6EkGrhY76WkMfhY8AK0u+q/h/MH04awKKocMDrHORRGjbbQnH+ZoIXfA== Original-Received: from [10.45.33.53] (helo=SmtpCorp) by smtpcorp.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.91) (envelope-from ) id 1gYy9t-TRk2vg-3G for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2018 19:02:29 +0000 Original-Received: from [94.173.179.81] (helo=sandhya.dracon.is) by smtpcorp.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.91) (envelope-from ) id 1gYy9r-rlZ9go-Au for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2018 19:02:27 +0000 Original-Received: from 233.123.93.209.dyn.plus.net ([209.93.123.233] helo=ratna) by sandhya.dracon.is with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.91) (envelope-from ) id 1gYy9a-0001Ke-A2 for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2018 19:02:17 +0000 X-Smtpcorp-Track: 1gYy9rr_Z9gojI.F0LCntxeL Feedback-ID: 157259m:157259aorYhhm:157259s-MRXoImQK X-Report-Abuse: Please forward a copy of this message, including all headers, to X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Mailman-Approved-At: Mon, 17 Dec 2018 14:16:27 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153525 Archived-At: network-stream-certificate will *always* return nil, regardless of whether there actually is a client-certificate value-pair specified, because (plist-get :client-certificate parameters) is always nil. This is because plist-get takes the plist as the first argument, and the key as the second; trying to find a list in a token is always going to be nil. This makes it impossible to use client certificates with Emacs's built- in network-stream support, at least without overriding functions. The error is in net/network-stream.el. It has been there since the function was first written in 2011, according to git blame. I surmise that this, in combination with there being no support for client certificates in network-stream-tls (though it's available in network-stream-starttls) is part of the reason there are so many conflicting guides on, for example, using client-certificate SASL with ERC.