From: Dmitry Gutov <dmitry@gutov.dev>
To: Eli Zaretskii <eliz@gnu.org>, Spencer Baugh <sbaugh@janestreet.com>
Cc: 71179@debbugs.gnu.org
Subject: bug#71179: [PATCH] In rgrep, check matching files before excluding files
Date: Sat, 25 May 2024 17:51:11 +0300 [thread overview]
Message-ID: <368566f1-142e-48d2-a54f-44e81ecf8d0a@gutov.dev> (raw)
In-Reply-To: <86zfsex9mq.fsf@gnu.org>
On 25/05/2024 17:13, Eli Zaretskii wrote:
>> For example, you never
>> considered the cases where the files which match the pattern to search
>> also match the ignored-extensions, and many other possibilities.
>>
>> In that case the file will not be searched, same as before this change. No behavior change.
> We are talking about performance here.
FWIW I don't see which performance problem you have in mind.
If you mean the possible regression in the case "user picked file
extension that's already in ignores", then I don't think it's going to
be any noticeably slower in vast majority of cases. And it's not a
scenario to optimize for anyway.
prev parent reply other threads:[~2024-05-25 14:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-24 20:14 bug#71179: [PATCH] In rgrep, check matching files before excluding files Spencer Baugh
2024-05-24 20:45 ` Dmitry Gutov
2024-05-24 20:54 ` Spencer Baugh
2024-05-25 12:31 ` Dmitry Gutov
2024-05-26 6:50 ` Juri Linkov
2024-05-26 12:48 ` Spencer Baugh
2024-05-26 12:56 ` Dmitry Gutov
2024-05-25 6:36 ` Eli Zaretskii
2024-05-25 12:26 ` Dmitry Gutov
2024-05-25 12:51 ` Eli Zaretskii
2024-05-25 13:03 ` Dmitry Gutov
2024-05-25 13:45 ` Eli Zaretskii
2024-05-25 13:58 ` Dmitry Gutov
2024-05-25 13:36 ` Spencer Baugh
2024-05-25 13:56 ` Eli Zaretskii
2024-05-25 14:02 ` Spencer Baugh
2024-05-25 14:13 ` Eli Zaretskii
2024-05-25 14:47 ` Dmitry Gutov
2024-05-25 15:07 ` Eli Zaretskii
2024-05-26 13:42 ` Spencer Baugh
2024-06-01 14:15 ` Eli Zaretskii
2024-06-02 10:46 ` Stefan Kangas
2024-05-25 14:51 ` Dmitry Gutov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=368566f1-142e-48d2-a54f-44e81ecf8d0a@gutov.dev \
--to=dmitry@gutov.dev \
--cc=71179@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).