From: Yuan Fu <casouri@gmail.com>
To: Theodor Thornhill <theo@thornhill.no>
Cc: Eason Huang <aqua0210@foxmail.com>, 61626@debbugs.gnu.org
Subject: bug#61626: 29.0.60; The indentation of switch case is broken on typescript-ts-mode and tsx-ts-mode
Date: Sun, 26 Feb 2023 00:39:41 -0800 [thread overview]
Message-ID: <3651308B-8B87-4B57-8076-792F31590113@gmail.com> (raw)
In-Reply-To: <91CDFA4A-85CF-45D0-B36E-02D5534D7405@thornhill.no>
> On Feb 24, 2023, at 10:12 PM, Theodor Thornhill <theo@thornhill.no> wrote:
>
>
>
> On 25 February 2023 06:00:45 CET, Yuan Fu <casouri@gmail.com> wrote:
>>
>> Eason Huang <aqua0210@foxmail.com> writes:
>>
>>> Hello Theodor and Emacs dev team,
>>>
>>> Recently I found that the indentation is broken in typescript-ts-mode
>>> and tsx-ts-mode. When I press RET (M-x newline) after the ':' in the
>>> case clause, it will always indent to the the same position of previouse line.
>>>
>>> For example:
>>> In typescript-ts-mode and tsx-ts-mode will get this result as below:
>>>
>>> ```
>>> let day: number = 1;
>>>
>>> switch (day) {
>>> case 0:
>>> console.log("It is a Sunday.");
>>> break;
>>> case 1:
>>> console.log("It is a Monday.");
>>> break;
>>> default:
>>> console.log("No such day exists!");
>>> break;
>>> }
>>> ```
>>> expected:
>>>
>>> ```
>>> let day: number = 1;
>>>
>>> switch (day) {
>>> case 0:
>>> console.log("It is a Sunday.");
>>> break;
>>> case 1:
>>> console.log("It is a Monday.");
>>> break;
>>> default:
>>> console.log("No such day exists!");
>>> break;
>>> }
>>> ```
>>>
>>> steps to reprodue:
>>>
>>> 1. start emacs with `emacs -Q`
>>> 2. C-x C-f ~/test.tsx to open a test.tsx
>>> 3. M-x typescript-ts-mode
>>> 4. input the exmaple code mentioned above
>>> 5. you will see the result.
>>
>> The following patch should fix this, Theo, WDYT?
>>
>> Yuan
>>
>
> This is already fixed:)
Oh! Glad I asked first ;-)
Yuan
next prev parent reply other threads:[~2023-02-26 8:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m2pma523g1.fsf@foxmail.com>
2023-02-25 5:00 ` bug#61626: 29.0.60; The indentation of switch case is broken on typescript-ts-mode and tsx-ts-mode Yuan Fu
2023-02-25 6:12 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-26 8:39 ` Yuan Fu [this message]
2023-02-19 13:24 Eason Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3651308B-8B87-4B57-8076-792F31590113@gmail.com \
--to=casouri@gmail.com \
--cc=61626@debbugs.gnu.org \
--cc=aqua0210@foxmail.com \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).