unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Cambell Barton <ideasman42@gmail.com>
To: Stefan Kangas <stefan@marxist.se>
Cc: 36526@debbugs.gnu.org
Subject: bug#36526: 26.2; Open diff at current location (feature request with suggested code)
Date: Sat, 14 Sep 2019 05:29:20 +1000	[thread overview]
Message-ID: <35d4b535-1e93-ef31-ca63-044721c1314f@gmail.com> (raw)
In-Reply-To: <CADwFkmnHCsvpRw4hqGngojo-hBDhNBBk-jeNa1=FsqZTGTB4Kg@mail.gmail.com>

Hi Stefan, I don't mind doing the copyright assignment.

Would someone be able to check the code and see if it's going in the 
right direction?

I'm still not that experienced with elisp, so I'd rather not spend time 
to make a patch if the general approach isn't right.

On 2019-09-13 21:59, Stefan Kangas wrote:
> Campbell Barton <ideasman42@gmail.com> writes:
> 
>> This is a feature suggestion which I've written example code for
>>
>> `vc-root-diff` (or a new function), could jump to the closest line.
>>
>> This is useful since you move to the context of the current line.
>>
>> I've written code that does this,
>> it would be useful if it was built into emacs.
>>
>> See: https://emacs.stackexchange.com/a/51439/2418
> 
> Thanks for the feature suggestion.
> 
> I haven't looked at your code, but if we decided to use it, it seems
> like a non-trivial change and would require you to sign copyright
> papers.  You can find more information about copyright assignment
> here:
> 
> https://www.gnu.org/software/emacs/manual/html_node/emacs/Copyright-Assignment.html
> 
> Would you be willing to do that?
> 
> If the answer to that is yes, could you please also submit your code
> as a patch?  You can find more information on how to do that in the
> CONTRIBUTE file in the emacs repository.  That would make it easier to
> review and test your suggested changes.
> 
> Best regards,
> Stefan Kangas
> 





  reply	other threads:[~2019-09-13 19:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-06 13:08 bug#36526: 26.2; Open diff at current location (feature request with suggested code) Campbell Barton
2019-09-13 11:59 ` Stefan Kangas
2019-09-13 19:29   ` Cambell Barton [this message]
2019-09-15 14:52     ` Stefan Kangas
2019-11-02  1:02       ` Stefan Kangas
2019-11-06 11:15         ` Campbell Barton
2019-12-27  8:18         ` Campbell Barton
2020-01-15  2:20           ` Stefan Kangas
2020-01-15 22:50             ` Dmitry Gutov
2020-08-09 19:37               ` Lars Ingebrigtsen
2020-08-09 21:08                 ` Dmitry Gutov
2020-08-10 10:43                   ` Lars Ingebrigtsen
2020-08-10 10:52                     ` Dmitry Gutov
2020-08-15 13:12           ` Lars Ingebrigtsen
2020-10-17  6:00 ` bug#36526: Previous work on this subject Herring, Davis via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-11-16 21:12   ` Juri Linkov
2020-11-16 21:29     ` Dmitry Gutov
2020-11-16 22:04       ` Juri Linkov
2020-11-17 21:02         ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35d4b535-1e93-ef31-ca63-044721c1314f@gmail.com \
    --to=ideasman42@gmail.com \
    --cc=36526@debbugs.gnu.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).