From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Olivier Certner Newsgroups: gmane.emacs.bugs Subject: bug#44100: On Amin's proposed change Date: Tue, 06 Jul 2021 16:29:43 +0200 Message-ID: <3590251.0TOR21KIAd@ravel> References: <4578382.cRamKGfW39@ravel> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7Bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24659"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Amin Bandali To: 44100@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 06 17:09:53 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m0mhf-0005mh-Vg for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Jul 2021 17:09:39 +0200 Original-Received: from localhost ([::1]:55294 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m0mhe-00036T-Uj for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Jul 2021 11:09:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0mXR-0005CJ-FV for bug-gnu-emacs@gnu.org; Tue, 06 Jul 2021 10:59:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38137) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m0mXP-0002FH-6P for bug-gnu-emacs@gnu.org; Tue, 06 Jul 2021 10:59:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m0mXP-0006yk-64 for bug-gnu-emacs@gnu.org; Tue, 06 Jul 2021 10:59:03 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <4578382.cRamKGfW39@ravel> Resent-From: Olivier Certner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Jul 2021 14:59:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44100 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44100-submit@debbugs.gnu.org id=B44100.162558352026761 (code B ref 44100); Tue, 06 Jul 2021 14:59:03 +0000 Original-Received: (at 44100) by debbugs.gnu.org; 6 Jul 2021 14:58:40 +0000 Original-Received: from localhost ([127.0.0.1]:49675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0mX2-0006xT-F2 for submit@debbugs.gnu.org; Tue, 06 Jul 2021 10:58:40 -0400 Original-Received: from smtp5-g21.free.fr ([212.27.42.5]:34384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0m56-000418-Bx for 44100@debbugs.gnu.org; Tue, 06 Jul 2021 10:30:03 -0400 Original-Received: from ravel.localnet (unknown [2.15.208.149]) (Authenticated sender: ocert.dev@free.fr) by smtp5-g21.free.fr (Postfix) with ESMTPSA id 76DF660FEF; Tue, 6 Jul 2021 16:29:43 +0200 (CEST) X-Mailman-Approved-At: Tue, 06 Jul 2021 10:58:37 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209522 Archived-At: For the record, an extract of a private exchange with Amin on the change he proposed earlier in this bug (Bug#44100). > > Sounds good, thanks! Instrumenting the function(s), > > putting breakpoints, and playing around with them should > > hopefully help develop some intuition around them. > > As I was suspecting, your patch didn't work just because you did not convert > the calls to `erc-track-find-face' correctly with respect to the change you > wanted to make. > > I'm not particularly keen on changing `erc-modified-channels-alist' format, > I just find it OK as it is (more compact), and chose to change its > documentation instead. Now, if you really insist on the other way, it's > quick to do as well, and I'll send you the corresponding proposal. > > I've also spent a while figuring out what `erc-track-find-face' does, and > I've decided to rewrite it for clarification (without changing the > behavior). It then appeared to me that its interface and call sites were > doing something I also suspected to be wrong, for which I did apply another > correction. > > And I also updated the documentation of some vars/funs involved in tracking, > to make things a bit easier to understand and cross-link better between > them. > > I'm currently testing the changes, and everything seems fine so far. I'll > make the changes publicly available tomorrow for you to see, so we can > start discussing them. I made these changes public a while ago in Bug#46775. -- Olivier Certner