unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#22748: 24.5; (elisp) `Type Predicates': Repeat the rule from `Coding Conventions'
@ 2016-02-20 18:23 Drew Adams
  2016-02-20 18:52 ` Eli Zaretskii
  0 siblings, 1 reply; 3+ messages in thread
From: Drew Adams @ 2016-02-20 18:23 UTC (permalink / raw)
  To: 22748

(elisp) `Coding Conventions' makes clear that a predicate name that has
multiple words should end in `-p', not just `p'.  This should also be
made clear in node `Type Predicates', which currently says only this
about the naming:

  Following a general Lisp convention for predicate functions, most type
  predicates=A1=AF names end with =A1=AEp=A1=AF.

And that node should have a cross reference to node `Coding
Conventions', which details the "general Lisp convention for predicate
functions" that it refers to.


In GNU Emacs 24.5.1 (i686-pc-mingw32)
 of 2015-04-11 on LEG570
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=3D/c/usr --host=3Di686-pc-mingw32'





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#22748: 24.5; (elisp) `Type Predicates': Repeat the rule from `Coding Conventions'
  2016-02-20 18:23 Drew Adams
@ 2016-02-20 18:52 ` Eli Zaretskii
  0 siblings, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2016-02-20 18:52 UTC (permalink / raw)
  To: Drew Adams; +Cc: 22748-done

> Date: Sat, 20 Feb 2016 10:23:32 -0800 (PST)
> From: Drew Adams <drew.adams@oracle.com>
> 
> (elisp) `Coding Conventions' makes clear that a predicate name that has
> multiple words should end in `-p', not just `p'.  This should also be
> made clear in node `Type Predicates', which currently says only this
> about the naming:
> 
>   Following a general Lisp convention for predicate functions, most type
>   predicates=A1=AF names end with =A1=AEp=A1=AF.
> 
> And that node should have a cross reference to node `Coding
> Conventions', which details the "general Lisp convention for predicate
> functions" that it refers to.

"Coding Conventions" are about future code; "Type Predicates" describe
the reality.  These two are not necessarily identical.

Closing.





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#22748: 24.5; (elisp) `Type Predicates': Repeat the rule from `Coding Conventions'
       [not found] ` <<83io1jnrjg.fsf@gnu.org>
@ 2016-02-20 19:10   ` Drew Adams
  0 siblings, 0 replies; 3+ messages in thread
From: Drew Adams @ 2016-02-20 19:10 UTC (permalink / raw)
  To: Eli Zaretskii, Drew Adams; +Cc: 22748-done

> "Coding Conventions" are about future code;

No, they describe the conventions that we follow.
That's general: past, present, future.

> "Type Predicates" describe the reality.  These two are not
> necessarily identical.

Agreed.  But `Type Predicates' specifically points to the
convention.  It should link to it, so readers can understand
just what that _convention_ is - as opposed to the more lax
description of "the reality".

FWIW: I was pretty sure that this convention was described
somewhere, so I tried `i predicate' and then narrowed that
to "type predicates" and landed at `Type Predicates'.

I did not find what I was looking for there, wrt the rule
for naming type predicates.  I then resorted to, yes,
searching the manual (I even searched the Emacs manual, as
well), using regexps such as "[^CM]-p\b"...  Eventually, I
got to (elisp) `Coding Conventions'.

Sure, I should have started there, perhaps.  But I should
have also been able to get there easily from `Type Predicates'
after using `i predicate'.  Just one user, sure.

Why you would not want to add a cross-reference to the
node that actually defines the "general Lisp convention for
predicate functions" is beyond me.  Perhaps you are having
a bad day?  If you don't have time to add that cross-ref
now, why not leave the bug open until someone does?

Why should this node mention, vaguely, "a general Lisp
convention for predicate functions" without helping users
find out what that convention is?

> Closing.

Too bad.





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-02-20 19:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <<6f905e9f-8bb4-4ec1-8cce-b00a6bf7a402@default>
     [not found] ` <<83io1jnrjg.fsf@gnu.org>
2016-02-20 19:10   ` bug#22748: 24.5; (elisp) `Type Predicates': Repeat the rule from `Coding Conventions' Drew Adams
2016-02-20 18:23 Drew Adams
2016-02-20 18:52 ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).