From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#51270: 28.0.50; xref core package 1.3.0 published, breaks etags Date: Mon, 18 Oct 2021 23:38:59 +0300 Message-ID: <35441e56-49ed-480c-7a60-ffce7c173912@yandex.ru> References: <87sfwyej4f.fsf@kenko.localhost.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33485"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 To: Ingo Lohmar , 51270@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 18 22:40:56 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcZRI-0008U3-2m for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Oct 2021 22:40:56 +0200 Original-Received: from localhost ([::1]:56422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcZRG-0008QB-Mv for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Oct 2021 16:40:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36696) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcZQR-0008Np-TB for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2021 16:40:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37174) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mcZQR-0000P5-Hk for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2021 16:40:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mcZQQ-0001Xv-BN for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2021 16:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Oct 2021 20:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51270 X-GNU-PR-Package: emacs Original-Received: via spool by 51270-submit@debbugs.gnu.org id=B51270.16345895505876 (code B ref 51270); Mon, 18 Oct 2021 20:40:02 +0000 Original-Received: (at 51270) by debbugs.gnu.org; 18 Oct 2021 20:39:10 +0000 Original-Received: from localhost ([127.0.0.1]:48720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcZPa-0001Wi-01 for submit@debbugs.gnu.org; Mon, 18 Oct 2021 16:39:10 -0400 Original-Received: from mail-lj1-f172.google.com ([209.85.208.172]:39749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcZPX-0001WK-85 for 51270@debbugs.gnu.org; Mon, 18 Oct 2021 16:39:09 -0400 Original-Received: by mail-lj1-f172.google.com with SMTP id r6so1975728ljg.6 for <51270@debbugs.gnu.org>; Mon, 18 Oct 2021 13:39:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MLwrCjIXBROnDu31wDpY4b7UpkwJiVohoaspbAMdf7s=; b=Utv/pimWbH+l9F8riahR5RBqaDKXp/MJeoOpQmDj9dsjQ0y3SFRzuzsSgjNs32vCtm hwLpj0n4q7J+VOwallrNkHIYwpFopx+UioqIpJ22qCxdRowhBnrgmZnNaGpjmE1uJw3X o5rRhwJlb694VKrN2PvHx4LrIAJGSu6LLkfit+y3x5r4Y/BfujiW3W8FhXVEvNyTXa39 OboG0QQo580hPv70vp1nAzTLpDvJc28WdxpwSuzmSkcnbssoy2mVvQkGDLFONU1AJNUS pwhBnVl4cloyOB969qDKVbWseP7MayguRbn7yJiPcSjFcucWy1qyjC2ND8DX39DXlFtt PvlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MLwrCjIXBROnDu31wDpY4b7UpkwJiVohoaspbAMdf7s=; b=rsM03XvEF4jftResUIMdlKb4CAbkRVtt8w/ZfuhzjhK7r0EXkRU0qo4b/wYeqHk7g2 CHbRzQWyo3DEi0OJYHfTEOFapMfq696kgRGNXVpKj4AZAapDNbdcSmXQvucddthcHifv UPwB7qPyktfLHdlHUiXUE5/TvQNZW6AGpDOaK8h5+MhG3QRNXzRSUZO9qctYMJeGUAZo n5+1SWREyXObCKuGztc2OArkzmzRse3SE32+Iy2u0slSW/wdjKCqylM7tgglk/OGUJMb Z1mYambbf8ps0QZNyqysgBwdFNqmlyL88D/2CVjdAIpHcCQ1608P8ECGXV3lh8A7IqKo Fd6g== X-Gm-Message-State: AOAM530yybDT9VYl+dm0rBSNyPCPs6AJKDHdVphqh42KjbsOJqPp2PDr Y4hL4hkJ0kew56KJhkmdHA/wvuAXe3A= X-Google-Smtp-Source: ABdhPJzHWQwt8JJ5G2nh9Ts3hUni4P5h7joPjBgCqlUK8b1s1rDFeY/JBEk2t5BwYQNRuiMJms1GZg== X-Received: by 2002:a2e:5cc7:: with SMTP id q190mr2140380ljb.494.1634589541151; Mon, 18 Oct 2021 13:39:01 -0700 (PDT) Original-Received: from [192.168.0.103] ([5.18.248.29]) by smtp.googlemail.com with ESMTPSA id b18sm1844579lji.99.2021.10.18.13.39.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Oct 2021 13:39:00 -0700 (PDT) In-Reply-To: <87sfwyej4f.fsf@kenko.localhost.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217522 Archived-At: Hi! On 18.10.2021 13:13, Ingo Lohmar wrote: > > This appears to be a packaging bug: The xref core package has changed > its version number from 1.2.2 to 1.3.0 in > 35a752863afc9f9075473e34c395d36e0bd18bff. > > The breakage happens because xref 1.3.0 has been published on GNU ELPA > https://elpa.gnu.org/packages/ (although the details page shows 1.2.2 as > the latest version, don't know why). I am using the "eglot" package, > which requires xref (at a lower minimum version), and when upgrading > packages this morning, I got xref 1.3.0. Which version of Emacs are you using? I understand Emacs 26 might have a problem with :noinline instructions in the new struct definitions. But as for loading eieio and defining the xref-location class, the top-level version check at the beginning of xref.el should supposedly help. It looks like: (eval-and-compile (when (version< emacs-version "28") ;; etags.el in Emacs 26 and 27 uses EIEIO, and its location type ;; inherits from `xref-location'. (require 'eieio) (with-no-warnings (defclass xref-location () () :documentation "...")))) > After that, everything related to etags fell apart (company backends, > after-save hooks to regenerate tags etc) with error messages about > undefined xref-location classes (and more). A backtrace example with an error could help as well. > Brief analysis: The new xref version switches from eieio to > cl-defstruct, which means that older etags (not a core package) code > breaks, because it relies on the xref-location class. This seems to be > in violation of the comment in xref.el: "Avoid functionality that is not > compatible with the version of Emacs recorded above." (the version > "recorded above" is 26.1) > > I am not really clear on how the "core package" idea is supposed to > work. One solution would be to "un-publish" xref 1.3.0. A more general > approach would introduce semantic versioning to package.el, and the > above change would require a version 2.0.0 in that world. Yes, it is definitely a problem. Semantic versioning wouldn't help, though. Emacs repositories don't retain non-latest versions of packages, and we don't have a way to specify an upper bound on a dependency either.