bug#21481: 24.5; show-paren-mode does not work with --color=no

bug#21481: 24.5; show-paren-mode does not work with --color=no

[Simon Gerraty]

Hi,

I've noticed in recent versions of Emacs that paren matching does not
work.

Turns out it *does* work, but I cannot see the result, because emacs is
started with --color=no (sorry but I cannot stand the color stuff)

If I start emacs without that paren matching works - using cyan
to highlight open paren.

That would suggest that the face used for show-paren-match is wrong -
ignoring color=no.

I cannot confirm that since I cannot seem to get any of the functions in
faces.el to run, even after explicitly loading it.
Which is odd.

I've seen this on multiple platforms, the common factor being emacs
version > 22

In GNU Emacs 24.5.1 (x86_64--netbsd)
 of 2015-07-10 on amd64-nb61
Configured using:
 `configure --srcdir=/work/editors/emacs24-nox11/work/emacs-24.5
 --localstatedir=/var --without-dbus --without-m17n-flt --without-otf
 --without-rsvg --without-x --without-xft --without-gif --without-jpeg
 --without-png --without-tiff --without-xpm --prefix=/usr/pkg
 --build=x86_64--netbsd --host=x86_64--netbsd --infodir=/usr/pkg/info
 --mandir=/usr/pkg/man 'CFLAGS=-O2 -I/usr/include' 'CPPFLAGS=-DTERMINFO
 -I/usr/include' 'LDFLAGS=-L/usr/lib -Wl,-R/usr/lib -Wl,-R/usr/pkg/lib''

Important settings:
  value of $LC_ALL: C
  value of $LANG: C
  locale-coding-system: nil

bug#21481: 24.5; show-paren-mode does not work with --color=no

[Eli Zaretskii]

> From: Simon Gerraty <sjg@juniper.net>
> Date: Mon, 14 Sep 2015 12:31:59 -0700
> 
> I've noticed in recent versions of Emacs that paren matching does not
> work.
> 
> Turns out it *does* work, but I cannot see the result, because emacs is
> started with --color=no (sorry but I cannot stand the color stuff)
> 
> If I start emacs without that paren matching works - using cyan
> to highlight open paren.
> 
> That would suggest that the face used for show-paren-match is wrong -
> ignoring color=no.

Thanks, I modified the definition of show-paren-match face to use
underline on color-less displays.

bug#21481: 24.5; show-paren-mode does not work with --color=no

[Simon J. Gerraty]

Eli Zaretskii <eliz@gnu.org> wrote:
> > That would suggest that the face used for show-paren-match is wrong -
> > ignoring color=no.
> 
> Thanks, I modified the definition of show-paren-match face to use
> underline on color-less displays.

Cool - is there a patch I can grab?

Thanks
--sjg

bug#21481: 24.5; show-paren-mode does not work with --color=no

[Dmitry Gutov]

On 09/15/2015 05:54 PM, Simon J. Gerraty wrote:

> Cool - is there a patch I can grab?

That would be 
http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=a1cbf94359cbe0e39ff49e4f639f7dd15d17fbcf

bug#21481: 24.5; show-paren-mode does not work with --color=no

[Simon J. Gerraty]

Dmitry Gutov <dgutov@yandex.ru> wrote:

> On 09/15/2015 05:54 PM, Simon J. Gerraty wrote:
> 
> > Cool - is there a patch I can grab?
> 
> That would be
> http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=a1cbf94359cbe0e39ff49e4f639f7dd15d17fbcf

Thanks... is there something else needed?

Applying that, removing old .elc and restarting emacs, seems to have
no effect.

I ended up customizing show-paren-match via list-faces-display,
it showed background was grey.

So I've solved my specific issue but not sure the patch helped.

Thanks
--sjg

bug#21481: 24.5; show-paren-mode does not work with --color=no

[Dmitry Gutov]

On 09/15/2015 07:16 PM, Simon J. Gerraty wrote:

> Applying that, removing old .elc and restarting emacs, seems to have
> no effect.

You need to recompile Emacs as well, faces.el is among the preloaded files.

bug#21481: 24.5; show-paren-mode does not work with --color=no

[Simon J. Gerraty]

Dmitry Gutov <dgutov@yandex.ru> wrote:

> On 09/15/2015 07:16 PM, Simon J. Gerraty wrote:
> 
> > Applying that, removing old .elc and restarting emacs, seems to have
> > no effect.
> 
> You need to recompile Emacs as well, faces.el is among the preloaded files.

I *knew* you were going to say that ;-)

Thanks for confirmation.