From: Konstantin Kharlamov <hi-angel@yandex.ru>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 46538@debbugs.gnu.org
Subject: bug#46538: Patch: wrap around smerge-vc-next-conflict if current file still has conflicts
Date: Tue, 16 Feb 2021 01:00:49 +0300 [thread overview]
Message-ID: <34d88602bcc902d9e0e3f03817bdc105c81172a1.camel@yandex.ru> (raw)
In-Reply-To: <87wnv9ta5i.fsf@tcd.ie>
Thank you! I will fix it up.
Nice hint on the `ignore-errors` macro, I didn't know about it
On Mon, 2021-02-15 at 19:15 +0000, Basil L. Contovounesios wrote:
> tags 46538 + patch
> quit
>
> Konstantin Kharlamov <hi-angel@yandex.ru> writes:
>
> > Attached patch implements additional check for conflicts just for the case
> > when
> > the buffer is the last conflicted file and all conflicts are above current
> > point.
>
> Thanks, just a few nits from me.
>
> > From f8d8f1cbdb94f75765165acacd089f1e3cc4a763 Mon Sep 17 00:00:00 2001
> > From: Konstantin Kharlamov <Hi-Angel@yandex.ru>
> > Date: Mon, 15 Feb 2021 21:37:33 +0300
> > Subject: [PATCH] vc: make smerge-vc-next-conflict wrap around
> >
> > lisp/vc/smerge-mode.el:
> > (smerge-next-safe): a wrapper around smerge-next that doesn't throw
> > an error.
> > (smerge-vc-next-conflict): make it wrap around a file if it's the last
> > conflicted file, and it still has conflicts
>
> Please use proper sentences starting with a capital letter and ending in
> a full stop.
>
> > ---
> > lisp/vc/smerge-mode.el | 20 ++++++++++++++------
> > 1 file changed, 14 insertions(+), 6 deletions(-)
> >
> > diff --git a/lisp/vc/smerge-mode.el b/lisp/vc/smerge-mode.el
> > index 3b09dfe5d2..0558240120 100644
> > --- a/lisp/vc/smerge-mode.el
> > +++ b/lisp/vc/smerge-mode.el
> > @@ -1446,6 +1446,14 @@ smerge-change-buffer-confirm
> > "If non-nil, request confirmation before moving to another buffer."
> > :type 'boolean)
> >
> > +(defun smerge-next-safe ()
> > + "Tries to move to next conflict, returns t on success, nil
> ^^^^
> Excess indentation.
>
> > +otherwise"
>
> The first line should contain a whole sentence, usually in the
> imperative; see (info "(elisp) Documentation Tips"). E.g.:
>
> "Try moving to next conflict.
> Return non-nil on success; nil otherwise."
>
> > + (condition-case err
> ^^^
> This variable is unused, so just pass nil instead.
>
> > + (not (smerge-next))
> > + ('error
> ^^
> Conditions are usually unquoted.
>
> > + nil)))
>
> You can reuse the macro ignore-errors for this:
>
> (ignore-errors (not (smerge-next)))
>
> > (defun smerge-vc-next-conflict ()
> > "Go to next conflict, possibly in another file.
> > First tries to go to the next conflict in the current buffer, and if not
> > @@ -1469,12 +1477,12 @@ smerge-vc-next-conflict
> > (if (and (buffer-modified-p) buffer-file-name)
> > (save-buffer))
> > (vc-find-conflicted-file)
> > - (if (eq buffer (current-buffer))
> > - ;; Do nothing: presumably `vc-find-conflicted-file' already
> > - ;; emitted a message explaining there aren't any more
> > conflicts.
> > - nil
> > - (goto-char (point-min))
> > - (smerge-next)))))))
> > + (when (eq buffer (current-buffer))
> > + ;; try to find a conflict marker in current file above the point
> > + (let ((prev-pos (point)))
> > + (goto-char (point-min))
> > + (when (not (smerge-next-safe))
> ^^^^^^^^^^
> Nit: when + not = unless
>
> > + (goto-char prev-pos)))))))))
>
next prev parent reply other threads:[~2021-02-15 22:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 18:51 bug#46538: Patch: wrap around smerge-vc-next-conflict if current file still has conflicts Konstantin Kharlamov
2021-02-15 19:15 ` Basil L. Contovounesios
2021-02-15 22:00 ` Konstantin Kharlamov [this message]
2021-02-15 22:25 ` bug#46538: [PATCH] vc: make smerge-vc-next-conflict wrap around Konstantin Kharlamov
2021-02-16 11:50 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34d88602bcc902d9e0e3f03817bdc105c81172a1.camel@yandex.ru \
--to=hi-angel@yandex.ru \
--cc=46538@debbugs.gnu.org \
--cc=contovob@tcd.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).