unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 68648@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>,
	stefankangas@gmail.com
Subject: bug#68648: 30.0.50; read-only-mode-hook's are not executed when buffer-read-only is t
Date: Thu, 01 Feb 2024 19:58:19 +0200	[thread overview]
Message-ID: <34698.1865864777$1706810389@news.gmane.org> (raw)
In-Reply-To: <86le84z0wz.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 01 Feb 2024 16:58:36 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Stefan Monnier <monnier@iro.umontreal.ca>
>> Cc: Stefan Kangas <stefankangas@gmail.com>,  bjorn.bidar@thaodan.de,
>>   68648@debbugs.gnu.org
>> Date: Thu, 01 Feb 2024 09:17:13 -0500
>> 
>> > Stefan & Stefan, any comments or opinions on this issue?  I' debating
>> > whether to do anything (and if so, what) about this, or close this bug
>> > as wontfix.
>> 
>> [ This a bug of my own making, when I decided to replace
>>   `toggle-read-only` with`read-only-mode`.  ]
>> 
>> I'd be in favor of replacing the `(setq buffer-read-only t)` with
>> `(read-only-mode 1)`, but it will require other changes: since calling
>> `read-only-mode` will handle `view-read-only`, it might make for a nice
>> simplification, but since the code is fairly complex over there, it
>> might also make things worse.
>
> I agree that it would be nice to clean this up, but since it isn't
> easy (which I, of course, noticed as well), I'm not sure it is worth
> our while, given that the problem is really minor.  Thus my doubts and
> my question.

I think trying to fix the problem if it so minor can take time.
However closing it as won't is not a good idea because of the ambiguity
of semantics here. It's easy to misunderstanding if you don't know.





  reply	other threads:[~2024-02-01 17:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <875xzma0hd.fsf@>
2024-01-22  9:00 ` bug#68648: 30.0.50; read-only-mode-hook's are not executed when buffer-read-only is t Eli Zaretskii
2024-01-23 13:47   ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-23 13:47   ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found]   ` <874jf4nove.fsf@>
2024-01-23 18:23     ` Eli Zaretskii
2024-02-01  9:48       ` Eli Zaretskii
2024-02-01 14:17         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-01 14:58           ` Eli Zaretskii
2024-02-01 17:58             ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-02-03  9:32             ` Eli Zaretskii
2024-02-03 16:28               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-03 22:09                 ` Stefan Kangas
2024-02-10  8:37                   ` Eli Zaretskii
2024-01-21 20:35 Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='34698.1865864777$1706810389@news.gmane.org' \
    --to=bug-gnu-emacs@gnu.org \
    --cc=68648@debbugs.gnu.org \
    --cc=bjorn.bidar@thaodan.de \
    --cc=eliz@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).