From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Brian Leung via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map Date: Mon, 19 Jul 2021 16:51:45 +0200 (CEST) Message-ID: <343742107.2068902.1626706305280@ichabod.co-bxl> References: <89178870.2006793.1626665845848@ichabod.co-bxl> <87eebupi5k.fsf@gnus.org> Reply-To: Brian Leung Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33240"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 49632@debbugs.gnu.org, Juri Linkov To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 19 16:52:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5Ucs-0008Q4-QZ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Jul 2021 16:52:10 +0200 Original-Received: from localhost ([::1]:33464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5Ucr-0002FX-TA for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Jul 2021 10:52:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37980) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5Ucl-0002FD-0B for bug-gnu-emacs@gnu.org; Mon, 19 Jul 2021 10:52:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48192) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m5Uck-00008q-Cy for bug-gnu-emacs@gnu.org; Mon, 19 Jul 2021 10:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m5Uck-0005vL-Co for bug-gnu-emacs@gnu.org; Mon, 19 Jul 2021 10:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Brian Leung Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Jul 2021 14:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49632-submit@debbugs.gnu.org id=B49632.162670631822762 (code B ref 49632); Mon, 19 Jul 2021 14:52:02 +0000 Original-Received: (at 49632) by debbugs.gnu.org; 19 Jul 2021 14:51:58 +0000 Original-Received: from localhost ([127.0.0.1]:59738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5Ucg-0005v4-CV for submit@debbugs.gnu.org; Mon, 19 Jul 2021 10:51:58 -0400 Original-Received: from wilbur.contactoffice.com ([212.3.242.68]:46592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5Ucd-0005up-Uf for 49632@debbugs.gnu.org; Mon, 19 Jul 2021 10:51:57 -0400 Original-Received: from ichabod.co-bxl (ichabod.co-bxl [10.2.0.36]) by wilbur.contactoffice.com (Postfix) with ESMTP id 378A5AF2; Mon, 19 Jul 2021 16:51:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1626706309; s=20210208-e7xh; d=mailfence.com; i=leungbk@mailfence.com; h=Date:From:Reply-To:Cc:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding; l=1549; bh=q0icfcct23IH5cahT+6PW5ZDY2Ufkg62jJQBBwLKWh4=; b=gIX4OL3TWqZHE6esE5VtoYz44T8l5GTmwoMrInPNlu6ljjwns2Drg0b+FpGA9GQx FSE+YUk857QGVF7uhWMCnAFdUXqAT5lTsMSGyfXD380ShQT1n6gf8laK0qM0hHmrU7M PgC9zUwx/MCO+3t33l/p42C2CaP6ZJ6/gEkCtcOmI99xoEqe6UeUAC1Hsri6sUDslSY KG6DPPaFHOK921ccHbw03wzEbmUfE+Yl/aSOBaviB73a1WQDYY8qoxe8IlO7HErUKBk uxBj7eLV5Sr69KtHwj37tMv0/fFgDRhtnuu3VahyrYihqc47sHbg/Wxx8tdQzFcz/Rb pvu/CpB7Zg== In-Reply-To: <87eebupi5k.fsf@gnus.org> X-Priority: 3 X-Mailer: ContactOffice Mail X-ContactOffice-Account: com:225491745 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" X-ACL-Warn: , Brian Leung Xref: news.gmane.io gmane.emacs.bugs:210251 Archived-At: > But I don't quite understand why gud-repeat-map is populated in the > normal way -- i.e., in `gud-repeat-map' so that users can > redefine/override entries as usual. I think it is presently done this way because things like M-x gdb, M-x pdb,= etc. all use their own debugger commands, so we need to re-bind exactly th= e right ones each time. For example, in M-x perldb, gud-finish, gud-up, and= gud-down are all commented out even though gdb clearly supports those func= tions. > ---------------------------------------- > From: Lars Ingebrigtsen > Sent: Mon Jul 19 15:06:31 CEST 2021 > To: Brian Leung > Cc: <49632@debbugs.gnu.org>, Juri Linkov > Subject: Re: bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-= map >=20 >=20 > Brian Leung writes: >=20 > > * lisp/progmodes/gdb-mi.el (gdb): Populate gud-repeat-map. This is > > copied from the gud-gdb command. >=20 > Instead of copying the code, perhaps it should be separated out into its > own function and then called from both places? >=20 > But I don't quite understand why gud-repeat-map is populated in the > normal way -- i.e., in `gud-repeat-map' so that users can > redefine/override entries as usual. >=20 > Juri? >=20 > --=20 > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no --=C2=A0 Sent with https://mailfence.com Secure and private email --=20 Mailfence.com Private and secure email