From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#57241: Commit b87400c broke master Date: Tue, 16 Aug 2022 11:51:07 -0700 Message-ID: <33c9e553-32fa-740b-018a-4616fc3150a2@gmail.com> References: <83ilmsfivh.fsf@gnu.org> <83czd0fhvh.fsf@gnu.org> <83bkskfgpc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9115"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57241@debbugs.gnu.org To: Eli Zaretskii , Dario Gjorgjevski Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 16 20:52:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oO1ff-0002AO-F2 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Aug 2022 20:52:11 +0200 Original-Received: from localhost ([::1]:35746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oO1fd-0003gw-S3 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Aug 2022 14:52:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50052) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oO1fX-0003gk-0S for bug-gnu-emacs@gnu.org; Tue, 16 Aug 2022 14:52:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58572) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oO1fW-0005zk-No for bug-gnu-emacs@gnu.org; Tue, 16 Aug 2022 14:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oO1fW-0006Os-Jj for bug-gnu-emacs@gnu.org; Tue, 16 Aug 2022 14:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Aug 2022 18:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57241 X-GNU-PR-Package: emacs Original-Received: via spool by 57241-submit@debbugs.gnu.org id=B57241.166067588224541 (code B ref 57241); Tue, 16 Aug 2022 18:52:02 +0000 Original-Received: (at 57241) by debbugs.gnu.org; 16 Aug 2022 18:51:22 +0000 Original-Received: from localhost ([127.0.0.1]:48319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oO1er-0006Nk-Df for submit@debbugs.gnu.org; Tue, 16 Aug 2022 14:51:22 -0400 Original-Received: from mail-pg1-f173.google.com ([209.85.215.173]:40732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oO1el-0006NJ-E2 for 57241@debbugs.gnu.org; Tue, 16 Aug 2022 14:51:19 -0400 Original-Received: by mail-pg1-f173.google.com with SMTP id 24so10020299pgr.7 for <57241@debbugs.gnu.org>; Tue, 16 Aug 2022 11:51:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :date:message-id:from:references:cc:to:subject:from:to:cc; bh=uKeJE7sN+dFOuAcRlnSMro3CZjvmC8o3uZ2j+Q+1eOI=; b=qzYXmCRqzSuBaNlVfAhTqsELoJLrwp8xzGvSVo4PTZG5Q4RCOQ1gMYw11Jc5xlC20p UC3iaL4gQrH5tAbXvB7kE50mdWyMM5npWi3GXUTxQvPzgnwvb67gHtSZG70Z6Kuhhq/Z IKVbuUAKoSkVBBhwJFZfrlsKoAelaqYk1ZB/+PEJwZjRUk/LPsnaqZdeuYz62uyZjDJp AAGPZpZ2aOFzDxwrXJAtfMKVCB3oesQBZ1Z8rvQQrIJsQenBL9/QLjT0Fw0fmKR9R+JB WDyA9THiwHSjzJAtnvtFt1izYWVvKO7zYV4v3k62UrZQzIuaQ1jwZjGZLP8KuFuVDP8l gISg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :date:message-id:from:references:cc:to:subject:x-gm-message-state :from:to:cc; bh=uKeJE7sN+dFOuAcRlnSMro3CZjvmC8o3uZ2j+Q+1eOI=; b=CoTg2MSMrQco7bjmwG9mvRJ+jALN8W2BcIhqIfdXfsChwsVZGPPubmtI7HF9REhsJG RErHCfH1vwqvYy+73jWYLkTEmmNHNwtrh4DiF7+X3Kdcz4pbRJWt1gt30zkwh/gNbFnV aTkIxaaWzHg1lfxigg7ZjNhh5EvziBMtK/xQxK5kkA/iaYqaEiWecNDC9FkoKZT75vnQ Ix9oRf1AVH5teS/sOWhMLIrjYrzeHC7MoKz56bz0H4BSvKXztw6P71SjTq6b2KVd0c14 9z4DXMx4xBMExnS3c2rEQcRPajkv6nKzSYDR0ff1j6TgMzEty0od0xEuW/7QW712QnJB EN+w== X-Gm-Message-State: ACgBeo0g+/PqSB4mppWljATUTLw4eaf1FcNkfgmo144gMtuXj1hCpehq KlFC2et+QLoXXnqu+RYnIAZzI4pgL8Y= X-Google-Smtp-Source: AA6agR4+sCMeAv4AtDwMD6FWlnJJuHQjqx3xuaOTPs1H7PWSNvlP9hE+g9aI7zP15qp+RhKHQzZNPw== X-Received: by 2002:a63:c02:0:b0:428:829b:310a with SMTP id b2-20020a630c02000000b00428829b310amr10405833pgl.470.1660675869375; Tue, 16 Aug 2022 11:51:09 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id q17-20020a170902eb9100b0016db774e702sm9276985plg.93.2022.08.16.11.51.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Aug 2022 11:51:08 -0700 (PDT) In-Reply-To: <83bkskfgpc.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239990 Archived-At: On 8/16/2022 6:42 AM, Eli Zaretskii wrote: >> From: Dario Gjorgjevski >> Date: Tue, 16 Aug 2022 15:23:58 +0200 >> Cc: 57241@debbugs.gnu.org, jporterbugs@gmail.com >> >> On Tue, Aug 16, 2022 at 3:17 PM Eli Zaretskii wrote:> >>> Can you (load "fringe") in such a build? If not, a simple 'require' >>> won't help. >> >> Yes, I can. > > OK, I tried to fix this now. Maybe it would make sense for fringe.el to be loaded in all builds, but to have more things be stub implementations like 'define-fringe-bitmap' is? Or maybe 'fringe-custom-set-bitmap' should just be autoloaded? 'require' works here, but if other places start using 'fringe-custom-set-bitmap' they'll break --without-x builds too. For example, gdb-mi.el and edebug.el seem like good candidates for eventually doing something like bookmark.el does. > Jim, I wonder whether the default value should be nil on TTY frames. It could make sense on --without-x builds, but I don't think it should depend on the frame type. With the Emacs daemon, you might switch between TTY and GUI frames, and it would be strange if you didn't see the fringe indicator in a GUI frame if you had set the indicator in a TTY frame. That said, on --without-x builds, setting a fringe indicator on a particular line of text should be safe, right? It just doesn't display anything, I think. Previously, I believe the code would (try to) set the fringe indicator on --without-x builds, and it seems to not be a problem, or else someone would have filed a bug about that against Emacs 28.