unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Jared Finder via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Olaf Rogalsky <olaf.rogalsky@t-online.de>
Cc: 69915@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#69915: 30.0.50; mouse-autoselect-window has no effect in terminal
Date: Thu, 21 Mar 2024 10:00:51 -0700	[thread overview]
Message-ID: <339ee67827867e0ec87bdbb1ba46415e@finder.org> (raw)
In-Reply-To: <87v85gbwcd.fsf@t-online.de>

On 2024-03-20 11:10, Olaf Rogalsky wrote:
>> On an MS-Windows terminal I don't see this problem, so maybe there's
>> more here than meets the eye?
> Yes, same in X11. I wasn't able to track it down. Maybe it is burried
> deep inside of "read_char".

I tried this change locally on master without the change to window.el 
and everything worked fine for me. Are you certain you need the change 
to window.el as well? I'd be very surprised if it is necessary to change 
the structure of the <select-window> event to get autoselect to work.

My repro was just:

src/emacs -nw -Q
M-x xterm-mouse-mode
M-x set-variable RET mouse-autoselect-window RET t
C-x 2
C-x 3
Then moving the mouse between the three visible windows.

Is your setup is different somehow?


A few other pieces of feedback (you may find it easier to generate the 
events in xterm-mouse-translate-1 to address):

<select-window> events shouldn't be generated while the mouse is being 
dragged. This probably is reflected in fully by track-mouse, but I'd 
suggest looking at the native code that generates the event to confirm.

If there is a case where two events should be generated (not sure if 
this case exists depending on above), we'd want to return both, but you 
can only return a single key sequence from the translate function. I 
think this case deserves a FIXME note.

Did you try out switching frames? I'm not certain if <select-window> is 
supposed to be generated when the frame is switched.

Please name the new internal state variable with prefix "xt-mouse--".

   -- MJF





  reply	other threads:[~2024-03-21 17:00 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-20 14:29 bug#69915: 30.0.50; mouse-autoselect-window has no effect in terminal Olaf Rogalsky
2024-03-20 16:43 ` Eli Zaretskii
2024-03-20 18:10   ` Olaf Rogalsky
2024-03-21 17:00     ` Jared Finder via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-03-24 19:27 ` Olaf Rogalsky
2024-03-25 21:53   ` Jared Finder via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-26 12:31     ` Eli Zaretskii
2024-03-26 23:50     ` Olaf Rogalsky
2024-03-27 21:47 ` Jared Finder via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-28  6:11   ` Eli Zaretskii
2024-03-28 14:41     ` Jared Finder via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-31  8:58       ` Eli Zaretskii
2024-04-01  9:09         ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-01 11:40           ` Eli Zaretskii
2024-04-01 14:08             ` Jared Finder via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-02  7:50               ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-04 16:32                 ` Jared Finder via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-04 16:41                   ` Jared Finder via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-06 10:15                   ` Eli Zaretskii
2024-03-30 17:03     ` Olaf Rogalsky
2024-03-30 20:18 ` Jared Finder via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found] ` <handler.69915.D69915.17123985538558.notifdone@debbugs.gnu.org>
2024-04-08 14:13   ` Olaf Rogalsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=339ee67827867e0ec87bdbb1ba46415e@finder.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=69915@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=jared@finder.org \
    --cc=olaf.rogalsky@t-online.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).