From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chris Newton Newsgroups: gmane.emacs.bugs Subject: bug#4680: 23.1.50; minor url-http.el fix Date: Thu, 15 Oct 2009 07:57:06 -0600 Message-ID: <339668590910150657y516d0c7bk794cdc8dc8cc7ccd@mail.gmail.com> References: <339668590910081551l4bc4957cv90478d801557371@mail.gmail.com> Reply-To: Chris Newton , 4680@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1255639696 14891 80.91.229.12 (15 Oct 2009 20:48:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 15 Oct 2009 20:48:16 +0000 (UTC) To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 15 22:48:05 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MyXEu-0008Lt-4B for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Oct 2009 22:48:00 +0200 Original-Received: from localhost ([127.0.0.1]:34727 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MyXEt-0006Mk-K4 for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Oct 2009 16:47:59 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MyXEI-00065H-Po for bug-gnu-emacs@gnu.org; Thu, 15 Oct 2009 16:47:22 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MyXED-00061J-Hz for bug-gnu-emacs@gnu.org; Thu, 15 Oct 2009 16:47:22 -0400 Original-Received: from [199.232.76.173] (port=44169 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MyXEC-00060y-TL for bug-gnu-emacs@gnu.org; Thu, 15 Oct 2009 16:47:16 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:49703) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MyXEC-0000cC-Aq for bug-gnu-emacs@gnu.org; Thu, 15 Oct 2009 16:47:16 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9FKlBwQ015051; Thu, 15 Oct 2009 13:47:11 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n9FKe7Y3013955; Thu, 15 Oct 2009 13:40:07 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Chris Newton Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Thu, 15 Oct 2009 20:40:07 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4680 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4680-submit@emacsbugs.donarmstrong.com id=B4680.125563890913310 (code B ref 4680); Thu, 15 Oct 2009 20:40:07 +0000 Original-Received: (at 4680) by emacsbugs.donarmstrong.com; 15 Oct 2009 20:35:09 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9FKZ78L013234 for <4680@emacsbugs.donarmstrong.com>; Thu, 15 Oct 2009 13:35:08 -0700 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1MyX2Q-0002q5-3J for 4680@emacsbugs.donarmstrong.com; Thu, 15 Oct 2009 16:35:06 -0400 Resent-Message-ID: <19159.34681.988439.117113@fencepost.gnu.org> Resent-Date: Thu, 15 Oct 2009 16:35:05 -0400 Resent-From: Glenn Morris Resent-To: 4680@emacsbugs.donarmstrong.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=sEi9wMtv0uhoh+SDjZO+vli1dbV0a/G7VzIobJTSq5k=; b=BYvWLEIP9z9YL/wucdllnkk8konmegCD09PXYNPqAc/PqOB4QNKf1jDStf7PR5R3eD MFdgNVaIDSpHtL4h4IE4ACrPHjtpfxKf9CjdJydAV+2kvzZNwCNspqil8zVGAknfEOUQ pJpD0l8LyapTLwW50AS/4qXpb6gYkZtU6ktCA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=rTUS4DVbuPNA2RAK85iKGHQUoRWmtnIseeQD3FvrMzAiA7RD7OtGJR7d3o9sW84Z2m 5KJ2ek57qMVFYGpOhp3wmUgMQhvAPTnuQ58mUJNDRRmMZZRiOtRV9SgyaiiEUbjAm9Mh rUH/eAIYj4nrMhYDgDftTOxxFozbNF/1aOKAA= In-Reply-To: X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-Bogosity: no, spamicity=0.091055, v1.0.1 Resent-Date: Thu, 15 Oct 2009 16:35:06 -0400 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31972 Archived-At: Whoops. I don't know what I was thinking about url-display-percentage. Ignore that. :) I came across this because of twit.el. It can do http operations every so often in the background. It binds (with let, so local bind, what ever the terminology is) url-show-status to nil when doing an async get. Since its async, it sets up a process buffer to do the get. But in the context of the process buffer, the local binding of url-show-status is long gone and the primary value takes over. By default its t, which would make sense for the vast majority of cases. So url-http displays progress on a background process when the user of url-http does not what that to happen. On Thu, Oct 15, 2009 at 1:03 AM, Glenn Morris wrote: > Chris Newton wrote: > >> Here is a small fix for the url-http function. When binding the >> url-show-status and/or url-display-percentage variables they would not >> get copied to the async buffer. So calls to url-lazy-message would not >> do the correct thing. The patch just adds those two functions to the >> list of variables to be copied. Thanks. > > I'm sorry, can you explain why this is necessary? Can you give an > example of what the behaviour is with and without this change? > > On the face of it, this change makes no sense to me. url-show-status > is a user option, and url-display-percentage is a function, not a > variable. > > > @@ -1142,6 +1144,8 @@ > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 url-http-chunked-start > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 url-callback-function > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 url-callback-arguments > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0url-show-status > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0url-display-percentage > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 url-http-process > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 url-http-method > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 url-http-extra-headers >