From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#37609: Tool-bar-mode grows the frame's height Date: Wed, 5 May 2021 09:24:48 +0200 Message-ID: <332adca2-1088-3dc6-d18f-778b73b24e0c@gmx.at> References: <87bluxihw0.fsf@mail.linkov.net> <507f8fc7-651a-12ea-20e6-bf2092ab5ed1@gmx.at> <87y2cub2gf.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8965"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 37609@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 05 09:26:25 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leBvM-0002DQ-Jc for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 May 2021 09:26:24 +0200 Original-Received: from localhost ([::1]:49206 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leBvL-0002uI-Lc for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 May 2021 03:26:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leBu2-0001V0-Ib for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 03:25:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46664) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1leBu2-0003Vy-9U for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 03:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1leBu2-0004Yr-5b for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 03:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 May 2021 07:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37609 X-GNU-PR-Package: emacs Original-Received: via spool by 37609-submit@debbugs.gnu.org id=B37609.162019950017524 (code B ref 37609); Wed, 05 May 2021 07:25:02 +0000 Original-Received: (at 37609) by debbugs.gnu.org; 5 May 2021 07:25:00 +0000 Original-Received: from localhost ([127.0.0.1]:58210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leBu0-0004Ya-Gl for submit@debbugs.gnu.org; Wed, 05 May 2021 03:25:00 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:51115) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leBtw-0004YS-EJ for 37609@debbugs.gnu.org; Wed, 05 May 2021 03:24:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1620199490; bh=jUexOZKgap6yUBlE3imQUQ+O+qDUOQ2uOtngz0hsnJ0=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=HTYl3tp9pAH8LX1je3AlZAzk/A8XuDxv+07s35WC8/LLCqxNT5Bor72NiLeHDpJbq wl6FyDw4gGx6CS3rLNpoDHppKFsnH+Cn0BlWTlBkr7GwqJ+oKyV3Clo3/BuDyJVKxY eIG3J3iS193qOKMRq7BzT87Lz8yunPU1WcAU9XDs= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([46.125.249.109]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MORAU-1lu5Oe0eRq-00PtD6; Wed, 05 May 2021 09:24:50 +0200 In-Reply-To: <87y2cub2gf.fsf@mail.linkov.net> Content-Language: en-US X-Provags-ID: V03:K1:HOHe3CI6jIiFik1b0xgyAqAfWVw9dOLZs2VjkZ1boDXV6O7ANwW b4ABOYYFcnhNDS9FZAkHUXky8/R7qRb7ZaYUvFiTwZcamumPFrOfAiEyzR4FuLVOlSbz7s4 hSp/xjFXZb+587btZcDk8supFbUIP1sovaS0q+Plg54zkhAiCSvYMz/FFXGaGGm7QiVCtFl DnUCdkv/9wIxivtu7cm7Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:KjcyV6Sd16Q=:Oc7xM7advheRVZ0O3Nu6Rs /Iwwb+JdvspDFNiWHERJ0E2MPHYljK187yPoReaNwTRoDWC+v3AgkCCmcBsxf5xTqA3OKfo7u IUuKF90lgamg3uEx2+HoXejeKwQMIO2IKfirCkjdXPZIB5zhl/pg72BjH6DuGr6XPXuki67Pd oIb/b2PUdNdFQVzsI7gFVBKcAS+7WWXfOfbdjyhJh3khwl/W0DJ+Uc0KmKLApjFK4S71N6YIU rfqEhE+4wL9tXGys/JGJZbcb9gZoNI/8VX85QfAweRsguq7OGmj1k2HniGynVXJnkQfKH2SxB G4jUZfQy90OuUdRPb9rwJ/+Wnzsv6Vi0qqu2cKAYkem6HnB9ZNH3DIijs89fuzBUps5huTqhK JC2uB0gqxnrsC/knNGI5sFnFFnd2wrYZFW0+1HG9rraOq/7Shprit3QocpMFW6qgeEK0z+NfV nwcUwc/oUCCNUJbVlpHK49ygdfS9AkEjyWCKLowYsAl9QUUEzLooJhvmFpN+KIhpZjzEw/OaU 7PmF7pKUi1dHc65GTDhXZD8ohIWgLrX8itw3YMesVUjLnThL5aJppM2ViGSwSZzy57BAHfmZ2 +5DIEHiW593gkjdKj+0V+JdqBYDNHgOWO/0EjbGzHqtdfQus38TGSFdZDTj732Tqj9DjMTFRw QWmB2iAtiDCttG+E8JUiUlbVqedES9rx4t2I5hIK724Xz+Luk4vkCoM3tbUwjFsj8EdK7psln ZU3h19xpUn1QNtrMoC2Z39z2s11D1FDR3Xl6OYjxmXXbzOdMea01tSqIsW6EcT/iaNvdJqSl X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205658 Archived-At: >> Can you please check again? Did you check with Lucid? > Now the frame's height doesn't grow but shrinks on GTK: > > ((outer-size 694 . 690) (outer-size 694 . 738)) Here when I start a GTK3 build with emacs -Q -f tool-bar-mode and do (let ((initial (assq 'outer-size (frame-geometry)))) (tool-bar-mode 1) (tool-bar-mode 0) (list (assq 'outer-size (frame-geometry)) initial)) I get ((outer-size 762 . 697) (outer-size 762 . 697)) an invariable frame height of 36, a frame pixel height of 648 (which sums up correctly with a menu bar height of 25, a title bar height of 14 and an external border of 5 pixels) and no visible change of any kind. >>> OTOH, in a new session again with emacs -Q -f tool-bar-mode >>> >>> (progn >>> (tool-bar-mode 1) >>> (assq 'outer-size (frame-geometry))) >>> >>> => (outer-size 680 . 693) >> >> This gets me >> >> (outer-size 764 . 720) > > (outer-size 694 . 690) > >> but evaluating >> >> (assq 'outer-size (frame-geometry)) >> >> once more (it takes time to relate such changes to `frame-geometry') now >> gives >> >> (outer-size 764 . 738) > > (outer-size 694 . 738) > >> which should yield the same value of (frame-height) as before (please >> check). > > (frame-height) > 36 > >> On Emacs 27 this was botched because the outer size changed to >> >> (outer-size 764 . 720) >> >> only and the frame height dropped from 36 to 35 lines. >> >>> (progn >>> (tool-bar-mode 0) >>> (assq 'outer-size (frame-geometry))) >>> >>> => (outer-size 680 . 693) >> >> This now gets me >> >> (outer-size 764 . 702) >> >> as expected. > > (outer-size 694 . 690) > >>> It's strange that the results are the same because visually >>> the frame's height grows. > >> So please have one more look into this issue. > > Do you think now it's improved? It's up to you to decide. I can try to fix all inconsistencies you still see. As far as outer sizes are concerned be aware that snippets like (progn (tool-bar-mode 1) (assq 'outer-size (frame-geometry))) might not tell the whole truth because the frame geometry may not have changed yet at the time you call that function. And please make sure to associate every result you report with the corresponding toolkit. Thanks, martin