From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Konstantin Kharlamov Newsgroups: gmane.emacs.bugs Subject: bug#45200: [PATCH] Force Glibc to free the memory freed Date: Wed, 03 Feb 2021 00:17:02 +0300 Message-ID: <331805c74fc5d3d412dd2065030b11fa3343710d.camel@yandex.ru> References: <83k0rz21dw.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-cKi0qJ2/NeN4hWbvfzJw" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21514"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.38.3 Cc: carlos@redhat.com, fweimer@redhat.com, 45200@debbugs.gnu.org, dj@redhat.com To: Stefan Monnier , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 02 22:18:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l733s-0005Vc-Cl for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Feb 2021 22:18:12 +0100 Original-Received: from localhost ([::1]:44418 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l733r-0003We-9n for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Feb 2021 16:18:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55328) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l733i-0003Un-MG for bug-gnu-emacs@gnu.org; Tue, 02 Feb 2021 16:18:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52968) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l733i-00072D-E6 for bug-gnu-emacs@gnu.org; Tue, 02 Feb 2021 16:18:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l733i-0003us-A6 for bug-gnu-emacs@gnu.org; Tue, 02 Feb 2021 16:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Feb 2021 21:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45200 X-GNU-PR-Package: emacs Original-Received: via spool by 45200-submit@debbugs.gnu.org id=B45200.161230063514997 (code B ref 45200); Tue, 02 Feb 2021 21:18:02 +0000 Original-Received: (at 45200) by debbugs.gnu.org; 2 Feb 2021 21:17:15 +0000 Original-Received: from localhost ([127.0.0.1]:36281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l732x-0003tp-1L for submit@debbugs.gnu.org; Tue, 02 Feb 2021 16:17:15 -0500 Original-Received: from forward105j.mail.yandex.net ([5.45.198.248]:53230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l732s-0003tZ-IZ for 45200@debbugs.gnu.org; Tue, 02 Feb 2021 16:17:14 -0500 Original-Received: from iva7-553ca43bc648.qloud-c.yandex.net (iva7-553ca43bc648.qloud-c.yandex.net [IPv6:2a02:6b8:c0c:2e99:0:640:553c:a43b]) by forward105j.mail.yandex.net (Yandex) with ESMTP id E935EB22401; Wed, 3 Feb 2021 00:17:03 +0300 (MSK) Original-Received: from iva5-057a0d1fbbd8.qloud-c.yandex.net (iva5-057a0d1fbbd8.qloud-c.yandex.net [2a02:6b8:c0c:7f1c:0:640:57a:d1f]) by iva7-553ca43bc648.qloud-c.yandex.net (mxback/Yandex) with ESMTP id zU606MBpXS-H2HiaLJ4; Wed, 03 Feb 2021 00:17:03 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1612300623; bh=qBTGpSobwMuMwMUZctn8IQ3WGGe6TbgGXH1NwEMfpnY=; h=In-Reply-To:Cc:To:From:Subject:Message-ID:References:Date; b=Uj4hdj0B+sCcXN4e8cV1GoMKPxibCpDjUIPvgaX7VCG53Fj+R9hZZ/G3mmg6mJwIK CUZ319vE06sP35/GZvWZTg/g3KSSsQ2J4NjUntgVTbQThzUH+dSyakHRYv6RjlCIaw CTrBKi1erdTWIjeuRRiaNdu0fsYjASTbxULZIMrA= Authentication-Results: iva7-553ca43bc648.qloud-c.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: by iva5-057a0d1fbbd8.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id dJjaVGW32F-H2nOTHMe; Wed, 03 Feb 2021 00:17:02 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199170 Archived-At: --=-cKi0qJ2/NeN4hWbvfzJw Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit On Tue, 2021-01-26 at 10:30 -0500, Stefan Monnier wrote: > > That'd be easy to implement, but I'm not yet sure it's the best > > alternative.  In particular, I'd like to have some idea regarding how > > much time such a call could take.  In some usage patterns Emacs calls > > GC very frequently, which slows down command execution and makes Emacs > > less responsive. > > The most important case where this happens is during phases of creation > of large new structures (e.g. while loading a large package like Org), > where a lot of memory is allocated without generating much garbage, so > every time we run the GC that time is mostly wasted (since we don't > recover any garbage) and calling malloc_trim would also be useless in > those cases. So, I just did some benchmarking; the patch I bencharked it with was modified per Stefan's comment (i.e. `malloc_trim(0)` is moved to the end of `garbage_collec()`). I'm attaching it here as well. Benchamarking was done as follows: I ran built emacs as `src/emacs -Q`; and used this code (benchmark-run (let ((i 1000000)) (while (> i 0) (print "hello") (setq i (- i 1))))) which I ran 3 times. First with the patch; then I git-checked out HEAD^ (i.e. to the code without my patch), built it, and ran 3 times again. This code you may recognize, it was the reproducer to show Emacs taking 200M of memory, except I cut out the line disabling GC, and the line that calls GC manually. IOW I used a known memory-heavy testcase, and ran it with vanilla Emacs configuration. Results are: with malloc_trim: (8.920371394 232 2.106283245) (9.038083601 231 2.060810826) (9.140798641 231 2.0594013240000004) without malloc_trim: (8.987097209 232 2.070143482) (8.700478084 231 1.7745506179999997) (8.781121056 231 1.7870093610000004) The difference is just 3-4% (8.7 / 9 ≈ 0.9666666667). It looks to me insignificant enough to not show up anywhere during interactive work with Emacs. --=-cKi0qJ2/NeN4hWbvfzJw Content-Disposition: attachment; filename="1.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="1.patch"; charset="UTF-8" RnJvbSBiYzA5Y2U0ZTI1ZmYyYzM2MWQxOWFjZTM1ZTU1NmI3Mzg2NTFjMGEyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLb25zdGFudGluIEtoYXJsYW1vdiA8SGktQW5nZWxAeWFuZGV4 LnJ1PgpEYXRlOiBTdW4sIDI0IEphbiAyMDIxIDE3OjU1OjIzICswMzAwClN1YmplY3Q6IFtQQVRD SF0gRm9yY2UgR2xpYmMgdG8gZnJlZSB0aGUgbWVtb3J5IGZyZWVkCgpjb25maWd1cmUuYWM6IGNo ZWNrIHdoZXRoZXIgbWFsbG9jX3RyaW0gaXMgc3Vwb3J0ZWQKc3JjL2FsbG9jLmMgKGdhcmJhZ2Vf Y29sbGVjdCk6IGNhbGwgbWFsbG9jX3RyaW0oKSBpZiBwb3NzaWJsZQooYnVnIzQ1MjAwKQotLS0K IGNvbmZpZ3VyZS5hYyB8IDMgKysrCiBzcmMvYWxsb2MuYyAgfCAzICsrKwogMiBmaWxlcyBjaGFu Z2VkLCA2IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9jb25maWd1cmUuYWMgYi9jb25maWd1 cmUuYWMKaW5kZXggMDhmM2MwY2Q4NS4uNDE2Y2ZiZTM4OSAxMDA2NDQKLS0tIGEvY29uZmlndXJl LmFjCisrKyBiL2NvbmZpZ3VyZS5hYwpAQCAtNDU1Niw2ICs0NTU2LDkgQEAgQUNfREVGVU4KIGRu bCB0aGUgY3VycmVudCBDRkxBR1MgZXRjLgogQUNfQ0hFQ0tfRlVOQ1Moc25wcmludGYpCiAKKwor QUNfQ0hFQ0tfRlVOQ1MobWFsbG9jX3RyaW0pCisKIGRubCBDaGVjayBmb3IgZ2xpYi4gIFRoaXMg ZGlmZmVycyBmcm9tIG90aGVyIGxpYnJhcnkgY2hlY2tzIGluIHRoYXQKIGRubCBFbWFjcyBuZWVk IG5vdCBsaW5rIHRvIGdsaWIgdW5sZXNzIHNvbWUgb3RoZXIgbGlicmFyeSBpcyBhbHJlYWR5CiBk bmwgbGlua2luZyB0byBnbGliLiAgQWx0aG91Z2ggZ2xpYiBwcm92aWRlcyBubyBmYWNpbGl0aWVz IHRoYXQgRW1hY3MKZGlmZiAtLWdpdCBhL3NyYy9hbGxvYy5jIGIvc3JjL2FsbG9jLmMKaW5kZXgg Yjg2ZWQ0ZWQyNi4uMzEyNDM3OGZiOCAxMDA2NDQKLS0tIGEvc3JjL2FsbG9jLmMKKysrIGIvc3Jj L2FsbG9jLmMKQEAgLTYxNDYsNiArNjE0Niw5IEBAIGdhcmJhZ2VfY29sbGVjdCAodm9pZCkKICAg ICAgIGlmICh0b3RfYWZ0ZXIgPCB0b3RfYmVmb3JlKQogCW1hbGxvY19wcm9iZSAobWluICh0b3Rf YmVmb3JlIC0gdG90X2FmdGVyLCBTSVpFX01BWCkpOwogICAgIH0KKyNpZmRlZiBIQVZFX01BTExP Q19UUklNCisgIG1hbGxvY190cmltKDApOyAvKiB3b3JrIGFyb3VuZCBmb3IgaGlnaCBtZW1vcnkg Y29uc3VtcHRpb24sIHNlZSBidWcgNDUyMDAgKi8KKyNlbmRpZiAvKiBIQVZFX01BTExPQ19UUklN ICovCiB9CiAKIERFRlVOICgiZ2FyYmFnZS1jb2xsZWN0IiwgRmdhcmJhZ2VfY29sbGVjdCwgU2dh cmJhZ2VfY29sbGVjdCwgMCwgMCwgIiIsCi0tIAoyLjMwLjAKCg== --=-cKi0qJ2/NeN4hWbvfzJw--