From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#35564: [PATCH v3] Tweak dired warning about "wildcard" characters Date: Fri, 28 Jun 2019 08:35:41 -0700 (PDT) Message-ID: <32acf7a4-70d2-4c33-a3f5-18b082903d4a@default> References: <87zho2cd4f.fsf@gmail.com> <87wohvf22u.fsf@gmail.com> <87h88cvpkj.fsf_-_@gmail.com> <87a7e27gh5.fsf@gmail.com> <8736jujkvj.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="102570"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35564@debbugs.gnu.org, Stefan Monnier To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec , Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 28 17:55:52 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hgtE8-000QYe-96 for geb-bug-gnu-emacs@m.gmane.org; Fri, 28 Jun 2019 17:55:52 +0200 Original-Received: from localhost ([::1]:33614 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgtE7-0004ke-1e for geb-bug-gnu-emacs@m.gmane.org; Fri, 28 Jun 2019 11:55:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56960) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgsv1-0001IN-Mf for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2019 11:36:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgsuz-00047P-8D for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2019 11:36:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57516) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hgsuw-00044E-Dp for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2019 11:36:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hgsuw-0002iG-9R for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2019 11:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Jun 2019 15:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35564 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35564-submit@debbugs.gnu.org id=B35564.156173615410399 (code B ref 35564); Fri, 28 Jun 2019 15:36:02 +0000 Original-Received: (at 35564) by debbugs.gnu.org; 28 Jun 2019 15:35:54 +0000 Original-Received: from localhost ([127.0.0.1]:42825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgsuo-0002hf-9k for submit@debbugs.gnu.org; Fri, 28 Jun 2019 11:35:54 -0400 Original-Received: from userp2130.oracle.com ([156.151.31.86]:35356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgsul-0002hR-Lt for 35564@debbugs.gnu.org; Fri, 28 Jun 2019 11:35:52 -0400 Original-Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5SFXgSt166631; Fri, 28 Jun 2019 15:35:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=tGN6d7pdU4B29X2A4DaQVWBgy6KbHSrWYCp4xdSoAqg=; b=rc0OL4sJffUlro7hvLQkys6iPRB9KXDeZX/f1/0OiRlqjdkdrhUqZ5Ro8I5O/fyWUTES sBYwHHclumIW2kNgBdM13Fd1MJStw90w9CsS9SRnkgcLrMn5vfEOB5DUSlzt0aekGUlt xMd9bn69GxiN+yMCETxWlp3pn/2EqmyCox5T2VVM43Gvkyhy3/RltWP+ehiUvBK16Ayr i0CYDouJNHkg1TrVBrVyLLh4LEiX8UnZybebGu9A5WWXAJ5H2nUFhkqYsnGamqf4EPPw w56mIryfjxAOl9ZOssl0uTcbS6dzWtTswBe3e6sv8bvycxFO9UY/Tx4r/VLk3PNbPrG6 Vg== Original-Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 2t9brtpbw1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 28 Jun 2019 15:35:45 +0000 Original-Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5SFYrd6112655; Fri, 28 Jun 2019 15:35:44 GMT Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 2t9p6vyhpb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 28 Jun 2019 15:35:44 +0000 Original-Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x5SFZf6b014162; Fri, 28 Jun 2019 15:35:41 GMT In-Reply-To: <8736jujkvj.fsf@gmail.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4861.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9302 signatures=668688 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906280179 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9302 signatures=668688 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906280180 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161740 Archived-At: (Apologies if I missed something - I took only a quick look at the patches and the bug report.) The old question=20 "Confirm--do you mean to use `*' as a wildcard? " Seemed clear enough, I thought. But I see now from the bug report that it could be confusing. But the new question (and actually it's not even a question - it should be, no?) seems even less clear to me: "Confirm--the highlighted characters will not be substituted:" (And too long - "highlighted chars won't be substituted" says the same thing as "the highlighted...".) Maybe something like this? "Should highlighted chars be substituted? " or "Substitute highlighted occurrences of `*'? " But see next - 1. It's not clear to me what someone will understand by "substituted" here. What would (otherwise) be substituted for what, where, and for what purpose? What substitution are we talking about, and how would a user be expected to know what we mean, here? 2. Are there multiple different "characterS" involved, or is the confirmation about only _one_ character, in (possibly) multiple locations - occurrences of one char? 3. Is it the case that the new prompt does not, itself, show the character? Do you have to look elsewhere to see which char or chars(?) are meant by the prompt? Shouldn't the prompt itself show the char? I think more thought might need to be put into this, by those who understand what the code actually does, ways in which the resulting behavior could be confusing, and just what it is we're asking the user to confirm. (I'm not one who really understands all of this. I'm just saying that my guess is that things are still not so clear after the patching.) A final comment, which I'm not sure is relevant: We should not, in any case, _rely_ on any highlighting to get across meaning (semantics). Highlighting should always be an extra - a nice-to-have. Some users will not see the highlighting - it cannot be the only thing that gets the intended meaning across. (Again, I'm not saying that we _are_ relying on highlighting this way. I just want to be sure we're not. We don't want to unnecessarily introduce an accessibility problem.)