From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#43470: 27.1; Drag and Drop not working properly in 27.1 on OSX Date: Thu, 17 Sep 2020 20:46:37 +0100 Message-ID: <32895e7e-d608-48ad-8f03-397f2d03cd06_IMAP_ADDED_MISSING@ICHABOD> References: <0EB1A591-9FE4-4128-96A0-C2A8E36BC8CE@duke.edu> <20200917174640.GB635@breton.holly.idiocy.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="975"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "Paul Magwene, Ph.D." , 43470@debbugs.gnu.org To: Daniel =?UTF-8?Q?Mart=C3=83=3F=C3=82n?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 17 21:48:41 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIztZ-00006Q-Fh for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Sep 2020 21:48:41 +0200 Original-Received: from localhost ([::1]:59186 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIztY-0007yf-Ei for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Sep 2020 15:48:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIzry-00078a-Ql for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 15:47:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55848) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kIzry-0004j1-14 for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 15:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kIzrx-0006wv-VA for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 15:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Sep 2020 19:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43470 X-GNU-PR-Package: emacs Original-Received: via spool by 43470-submit@debbugs.gnu.org id=B43470.160037201226699 (code B ref 43470); Thu, 17 Sep 2020 19:47:01 +0000 Original-Received: (at 43470) by debbugs.gnu.org; 17 Sep 2020 19:46:52 +0000 Original-Received: from localhost ([127.0.0.1]:39161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIzro-0006wZ-Fe for submit@debbugs.gnu.org; Thu, 17 Sep 2020 15:46:52 -0400 Original-Received: from wilbur.contactoffice.com ([212.3.242.68]:37686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIzrl-0006wK-PL for 43470@debbugs.gnu.org; Thu, 17 Sep 2020 15:46:50 -0400 Original-Received: from smtpauth1.co-bxl (smtpauth1.co-bxl [10.2.0.15]) by wilbur.contactoffice.com (Postfix) with ESMTP id 412761106; Thu, 17 Sep 2020 21:46:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1600372003; s=20200222-6h9o; d=idiocy.org; i=alan@idiocy.org; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To; l=1346; bh=cVpER9HRrUokLguCZH4d/bLuxjam0AGsR36//lHdX24=; b=eEibHnJuzqjrxPUo8N36tUhRdC+2FVxeQeiPJHrtLEsZ4T5B9OyxE96KOhyE25NK yL+Vv0OHYTG3wdLr89kUW/Exo4xev8MK2MU0y6QEdJicaxHC5xUbzqjr31DJHUR0EvQ UgUp9y/11t9nwzEGjUszZOkFr7g/ZGWMpzkoWMYEpXgcjuME58+X93pGMgbCdnqeKbW gd/ZuEgMsRTKKe9W7o6ucxrfmgh5kelM+gGVThFCofo7IRXifQSIW+85W0EUoMVGdlU PNdLU1RGtk8iitK+bupmSYmGWwKUwzRtof2ldyjZ4sevvOUfq6klzb0+YTWcizNjVp2 90LcV6+PNw== Original-Received: by smtp.mailfence.com with ESMTPA ; Thu, 17 Sep 2020 21:46:38 +0200 (CEST) Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 92712202563B6E; Thu, 17 Sep 2020 20:46:37 +0100 (BST) Mail-Followup-To: Alan Third , Daniel =?UTF-8?Q?Mart=C3=83=3F=C3=82n?= , "Paul Magwene, Ph.D." , 43470@debbugs.gnu.org Content-Disposition: inline In-Reply-To: X-ContactOffice-Account: com:241649512 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188249 Archived-At: On Thu, Sep 17, 2020 at 08:12:56PM +0200, Daniel Mart�­n via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > Alan Third writes: > > > > Confirmed. > > > > Annoyingly I could've sworn this worked just a few months ago. I > > wonder if Apple have changed something in their libraries to > > completely deprecate the old methods. > > > > Anyway, It'll need to be almost completely rewritten (again!). > > Hi, Alan: > > Could it be caused by an incomplete rename done at > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=9624f609493da7c08016ba00d6895bad0fe26a0e? > > The following patch fixes the reported bug for me on 10.15.6 and Emacs > 28.0.50, and also fixes some compilation warnings as well: IIRC (and I could definitely be wrong here) a simple find/replace breaks the ability to handle more than one file being dragged at a time, which is why I left it (it used to work fine even though it was flagged as deprecated). Obviously that doesn't matter if it now no longer works at all, but we need to retain backwards compatibility so any patch will have to work on GNUstep and older versions of macOS. The bottom of nsterm.h shows how we've handled that with previous deprecations. Can you check whether your patch handles the multi-file case? -- Alan Third