unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Holger Arnold <holgerar@gmail.com>
To: 12392@debbugs.gnu.org
Subject: bug#12392: emacs-gtk misinterprets floating-point numbers under certain locales on openSUSE 12.2
Date: Fri, 21 Sep 2012 22:08:02 +0200	[thread overview]
Message-ID: <3280435.OyV9o2Zt6I@thinkpad.home> (raw)
In-Reply-To: <5051974D.2020106@cs.ucla.edu>

On Thursday 13 September 2012 at 01:20:29, Paul Eggert wrote:
> This particular problem looks like it's probably an OpenSUSE bug, but
> in general one cannot combine LC_NUMERIC=C with random encodings in
> LC_CTYPE.  It's safer if Emacs uses the C locale when parsing floating
> point numbers.  Here's a proposed patch to do that.  Can you apply
> this against the Emacs trunk and give it a try?

I have not yet had a chance to test these patches.  But is it really the 
correct approach to set the locale to "C" whenever a number literal is read or 
written and to set it back afterward?  (Btw., is setlocale() thread-safe?)  
Wouldn't it be simpler and more reliable to have number conversion functions 
that are independent of the current locale?

> +/* Cache for the C locale object.
> +   Marked volatile so that different threads see the same value
> +   (avoids locking).  */
> +static volatile locale_t c_locale_cache;

Maybe I'm missing something, but declaring a variable volatile does not 
automatically make it thread-safe, does it?

		Holger





      parent reply	other threads:[~2012-09-21 20:08 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-09  7:37 bug#12392: 24.2; emacs-gtk misinterprets floating-point numbers under certain locales on openSUSE 12.2 Achim Gratz
2012-09-09  7:43 ` Achim Gratz
2012-09-09  8:09 ` Achim Gratz
2012-09-09  8:30 ` Achim Gratz
2012-09-10 17:37   ` Jan Djärv
2012-09-10 19:00     ` Achim Gratz
2012-09-13  8:20 ` bug#12392: " Paul Eggert
2012-09-13 17:59   ` Achim Gratz
2012-09-14 15:58   ` Achim Gratz
2012-09-21  9:59   ` Holger Arnold
2012-09-22  6:19     ` Achim Gratz
2012-09-22 14:38       ` Holger Arnold
2012-09-22 15:08         ` Andreas Schwab
2012-09-22 15:49           ` Holger Arnold
2012-09-22 16:07             ` Eli Zaretskii
2012-09-22 17:04               ` Holger Arnold
2012-09-22 17:19                 ` Jan Djärv
2012-09-22 17:22                   ` Jan Djärv
2012-09-22 16:54             ` Jan Djärv
2012-09-22 16:55               ` Jan Djärv
2012-09-22 17:00                 ` Holger Arnold
2012-09-23 10:04                   ` Jan Djärv
2012-09-23 17:27                 ` Achim Gratz
2012-09-23 19:58                   ` Holger Arnold
2012-09-22 16:56               ` Holger Arnold
2012-09-22 16:02         ` Eli Zaretskii
2012-09-22 16:38           ` Holger Arnold
2012-09-22 16:41             ` Eli Zaretskii
2012-09-22 16:54               ` Holger Arnold
2012-09-22 17:10                 ` Eli Zaretskii
2012-09-22 17:18                   ` Holger Arnold
2012-09-22 19:02                     ` Eli Zaretskii
2012-09-22 19:44                       ` Holger Arnold
2012-09-22 16:36         ` Achim Gratz
2012-10-07 10:57           ` Holger Arnold
2012-09-21 20:08   ` Holger Arnold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3280435.OyV9o2Zt6I@thinkpad.home \
    --to=holgerar@gmail.com \
    --cc=12392@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).