From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#62429: 30.0.50; Add jsx faces to typescript-ts-mode Date: Sun, 2 Apr 2023 15:10:55 -0700 Message-ID: <326EC262-DCF5-4067-B553-E40DE3CE19C9@gmail.com> References: <79CDDA5E-421D-4760-B744-F0C661118711@gmail.com> <83lejlc8sy.fsf@gnu.org> <10D725F2-9162-4BC3-B362-1F54719C8313@gmail.com> <837cv4b020.fsf@gnu.org> <9E07A07B-EDF4-436F-8208-01D2CCA7A7AF@gmail.com> <83wn2y6caq.fsf@gnu.org> <83mt3u48fn.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21229"; mail-complaints-to="usenet@ciao.gmane.io" Cc: theo@thornhill.no, 62429@debbugs.gnu.org, Stefan Monnier To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 03 00:12:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pj5vq-0005I0-3N for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 Apr 2023 00:12:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pj5vk-0002Db-FT; Sun, 02 Apr 2023 18:12:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pj5vg-00029r-WF for bug-gnu-emacs@gnu.org; Sun, 02 Apr 2023 18:12:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pj5ve-0006yr-AY for bug-gnu-emacs@gnu.org; Sun, 02 Apr 2023 18:12:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pj5vd-0004dn-Rc for bug-gnu-emacs@gnu.org; Sun, 02 Apr 2023 18:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Apr 2023 22:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62429 X-GNU-PR-Package: emacs Original-Received: via spool by 62429-submit@debbugs.gnu.org id=B62429.168047347517785 (code B ref 62429); Sun, 02 Apr 2023 22:12:01 +0000 Original-Received: (at 62429) by debbugs.gnu.org; 2 Apr 2023 22:11:15 +0000 Original-Received: from localhost ([127.0.0.1]:42917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pj5ut-0004cn-DS for submit@debbugs.gnu.org; Sun, 02 Apr 2023 18:11:15 -0400 Original-Received: from mail-pl1-f169.google.com ([209.85.214.169]:45714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pj5uq-0004cZ-Ta for 62429@debbugs.gnu.org; Sun, 02 Apr 2023 18:11:13 -0400 Original-Received: by mail-pl1-f169.google.com with SMTP id le6so26241191plb.12 for <62429@debbugs.gnu.org>; Sun, 02 Apr 2023 15:11:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680473467; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HQzUBxZ9pGpxFBq9WgpvwKDlBeo7ax/zL3NiN4R+u/c=; b=ORzQGOryvltXsCuuOOUUdNv70kLs1jazyhZmFT10W0YR3NUO3fhmNJcsJZSIeR3tOF oN/pqpWhP7n7p7hXNC0+kIgJwSoV9VbjpWd8V8cDO/tvA9x7do05kyTD6/1fTSAbg3Uw Digri33neS3hVJKI10INPM8dBoX4SlLoyQxN63ZAApjMzy5KPSPP5gA7CCmAqbNIgovH LmaRwqzvhXZ2LppUVB+QpH/H8WP5wq6yIGlPjx7o/NG7qs8UnOt2Hzufo4IxmqAyIK6l vpg7cDNhaOgtuC395VfU9rbsWETWNtL2Fo5ta8FtA1uwcWPf7eYQnci2Hh53ruAaGDEe h7hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680473467; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HQzUBxZ9pGpxFBq9WgpvwKDlBeo7ax/zL3NiN4R+u/c=; b=2f60wrJe0Wu89dulpB2btMqW/h250/Yr7W1mBcXfSYSUyCE/wDaT5dgw0Kp3hYgSYM V+A2f4oto9iyv7qaA++EjQRiJ84NzgyCB2SkZkjo/c+GMiNSN2IfnVLyyBcze8oWA3n4 Uez/X1YT4gmqtni+VwvnXMT+o0SBypoO/FR+Ta8RK0FF+/oXFNs+ees5XiWjM07SwCUL zkrdECcD698RT6+rG4pvjHWqUEs3Erec0qTvtUvtiHnghHj/emoZFjOwHHXc4mHHVGjI s5wubnp/oR6doKNErFireXT7Hu/AhEKwJf1xFj0z+2cB12qamSocy2ODrwPer4Bklvit qyhg== X-Gm-Message-State: AAQBX9cS07gJGkWJhlPtnJWyjIX6F/wgFqu4jd9ye9DuqCGSxMDV+tTl GoZTOEYAWXmA1LWMe/Zhn4g= X-Google-Smtp-Source: AKy350ZcdfvD3i8ilqq4hz6qXSfKnvDzIejG3bDlaFRK/itabipN1MsWzEHBaU+GxziQjorMAeibjg== X-Received: by 2002:a05:6a20:8014:b0:e3:9972:6573 with SMTP id e20-20020a056a20801400b000e399726573mr15470404pza.14.1680473466996; Sun, 02 Apr 2023 15:11:06 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id a5-20020aa78645000000b00627f054a3cdsm5460092pfo.31.2023.04.02.15.11.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 02 Apr 2023 15:11:06 -0700 (PDT) In-Reply-To: <83mt3u48fn.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.400.51.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259140 Archived-At: > On Mar 30, 2023, at 7:31 AM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Thu, 30 Mar 2023 01:11:48 -0700 >> Cc: Stefan Monnier , >> 62429-done@debbugs.gnu.org, >> theodor thornhill >>=20 >>>>> OK, but then how will these JSX-specific faces fit into the = overall >>>>> scheme of treesit-font-lock faces? For example, in what level = will >>>>> they be used, and how will users know what level to set to see = these >>>>> faces in their buffers? >>>>=20 >>>> At level 3 for tsx-ts-mode, under the =E2=80=9Cjsx=E2=80=9D = feature. So they are enabled by default. Though it=E2=80=99s true that = it=E2=80=99s not immediately obvious what face to customize. At the very = least these faces appear in the customize group of typescript. We can = add something to the docstring of the major mode, too. >>>>=20 >>>>>=20 >>>>> These are the downsides of mode-specific faces, and if we think = it's >>>>> important enough to have them, we should resolve these issues when = we >>>>> install such faces. >>>=20 >>> Then it is fine by me, as long as those measures you mentioned are >>> taken to make sure users know how to customize font-lock with these >>> faces. >>=20 >> Cool. I pushed the change. >=20 > Thanks, but please also tell in the doc string of the mode which > font-lock level uses these special faces. Done. Yuan=