From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#60044: 30.0.50; hideshow in python-ts-mode not working Date: Sat, 7 Jan 2023 15:15:47 -0800 Message-ID: <326199CA-57DA-4C4A-B392-092E1FE03BC3@gmail.com> References: <87y1rboyin.fsf@kraus.my> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29065"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60044@debbugs.gnu.org To: daniel@kraus.my Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 08 00:16:30 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pEIQQ-0007Kz-4C for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Jan 2023 00:16:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pEIQ6-0005ag-Qr; Sat, 07 Jan 2023 18:16:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEIPz-0005Y6-1f for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2023 18:16:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pEIPy-0002aZ-QK for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2023 18:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pEIPy-0001QI-L7 for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2023 18:16:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87y1rboyin.fsf@kraus.my> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Jan 2023 23:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60044 X-GNU-PR-Package: emacs Original-Received: via spool by 60044-submit@debbugs.gnu.org id=B60044.16731333565442 (code B ref 60044); Sat, 07 Jan 2023 23:16:02 +0000 Original-Received: (at 60044) by debbugs.gnu.org; 7 Jan 2023 23:15:56 +0000 Original-Received: from localhost ([127.0.0.1]:59243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEIPs-0001Ph-EP for submit@debbugs.gnu.org; Sat, 07 Jan 2023 18:15:56 -0500 Original-Received: from mail-pj1-f42.google.com ([209.85.216.42]:36579) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEIPq-0001D9-7L for 60044@debbugs.gnu.org; Sat, 07 Jan 2023 18:15:54 -0500 Original-Received: by mail-pj1-f42.google.com with SMTP id h7-20020a17090aa88700b00225f3e4c992so9027609pjq.1 for <60044@debbugs.gnu.org>; Sat, 07 Jan 2023 15:15:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=p4FVl1O8Kw1aqxmkh1dgK2MAQ39IZSAiuonfst/lKNo=; b=AIjLh7PF3uG+7/VgXZXSTcAyr7OCpZR4O8j7WExKbjpQMY1Cv+KB/ueeqrjhTebXvs dDc6uHLNsZcL5gKSw9tbn4zO4krweenoxH+s5uzouMZqvNDmasYhR7affbJS4JxijJkl E9io5fNoqLhAC3Cf+CFwtF8mXKh+zjBcEE+3K8OCdCV2tYkRTienOiTPxIWHu14EVz9r XY7dJwddujVCdOcwWe7+x33O5iCaw/Acb0NGk3+UyZj1E0Mywkzctoc+iNpJXaHDC9hD FlBrZqQVjFxj7J/fiBvKe8GB7aIEgFtzqUR/CeasfHPz/w+yliHY5jpKgUUkTfPBWzId rSAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p4FVl1O8Kw1aqxmkh1dgK2MAQ39IZSAiuonfst/lKNo=; b=0cW8VdFOWtxqTzbjVPwkHDed2u/6+dqYjjWf9cmCB2TI4Tl5ZD3JTJa1etCyESU364 SRLCfmmrAOaI90P+OstRm5zVdPASqvjkuEhjZeVe5p4IW3BbB0IuEMOTlSf6e0r91cmw ZXw27u0wsxCivAE5AHu5sChNOWAzPnrezL7FTJOF6VLqTB0NTB9X4BBpq5hf5kzueVE7 ZmwXsyU3mG7BZLZ7Cwn1/1pGyxDHxQNHPl/UTcnGxC+3y+bY/XcT9AXeO9ue91o7zvdW jI1e9I274zbVOMuy+Ahz647Jv7FtOsr+1bPAJyLy97a8lTF/mq1dhXlY+EfqPxmZyaNa tRSA== X-Gm-Message-State: AFqh2kqSCPCpp2iKebGyt1Khrk6obqcZ5JSsFN8OlSzcXiG1QnckH/WD 0t0bF0Jj3De444S5bD3kZYp9AhpU79ZkRg== X-Google-Smtp-Source: AMrXdXvOO3xVbuVvUxh3ohCkg7VztEdWFq09SYWlXxUgSUWwddzfAVrJ90pxr0V/uo/euFt/DxQxLg== X-Received: by 2002:a17:902:7582:b0:192:4d6b:2311 with SMTP id j2-20020a170902758200b001924d6b2311mr59819011pll.46.1673133348467; Sat, 07 Jan 2023 15:15:48 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id j1-20020a170902c3c100b0018853416bbcsm3327359plj.7.2023.01.07.15.15.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 Jan 2023 15:15:48 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252842 Archived-At: Yuan Fu writes: > Daniel Kraus writes: > >> Not sure if this is a bug report or feature request >> but I use hideshow for code folding and I see that >> `python-base-mode` only adds python-mode to hs-special-modes-alist: >> >> (add-to-list >> 'hs-special-modes-alist >> `(python-mode >> ,python-nav-beginning-of-block-regexp >> ;; Use the empty string as end regexp so it doesn't default to >> ;; "\\s)". This way parens at end of defun are properly hidden. >> "" >> "#" >> python-hideshow-forward-sexp-function >> nil >> python-nav-beginning-of-block >> python-hideshow-find-next-block >> python-info-looking-at-beginning-of-block)) >> >> >> Simply adding the same with python-ts-mode makes hideshow work >> but I guess maybe `python-nav-beginning-of-block` etc should >> be replaced with the equivalent tree-sitter functions?! >> Maybe it's the same with the other treesit modes, I haven't checked. >> >> Thanks, >> Daniel > > Thanks for reporting this! For now I just python-ts-mode to the setup, > as you suggested. In the future we will switch it to use tree-sitter. > > Yuan Supporting hideshow with tree-sitter is harder that I thought. I = didn=E2=80=99t make it work. So "in the future" is now "in the distant future" :-) Yuan