From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Bruno Haible Newsgroups: gmane.emacs.bugs,gmane.comp.lib.gnulib.bugs Subject: bug#36370: 27.0.50; XFIXNAT called on negative numbers Date: Sat, 29 Jun 2019 19:48:37 +0200 Message-ID: <3251111.n4rrPxjoDE@omega> References: <2515002.Q0mBYvUW8C@omega> <99bacb9f-1192-1315-85d7-5ab4924dfef8@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="50571"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: KMail/5.1.3 (Linux/4.4.0-151-generic; KDE/5.18.0; x86_64; ; ) Cc: 36370@debbugs.gnu.org, bug-gnulib@gnu.org, Pip Cet To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 29 19:50:02 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hhHU7-000CuW-OS for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Jun 2019 19:50:01 +0200 Original-Received: from localhost ([::1]:41692 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhHU1-0004Zp-MY for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Jun 2019 13:49:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37181) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhHTI-0004ZD-EG for bug-gnu-emacs@gnu.org; Sat, 29 Jun 2019 13:49:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hhHTG-0007AV-PD for bug-gnu-emacs@gnu.org; Sat, 29 Jun 2019 13:49:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59572) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hhHTB-00077G-VR for bug-gnu-emacs@gnu.org; Sat, 29 Jun 2019 13:49:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hhHTB-0005jU-Qo for bug-gnu-emacs@gnu.org; Sat, 29 Jun 2019 13:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Bruno Haible Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Jun 2019 17:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36370 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36370-submit@debbugs.gnu.org id=B36370.156183052621997 (code B ref 36370); Sat, 29 Jun 2019 17:49:01 +0000 Original-Received: (at 36370) by debbugs.gnu.org; 29 Jun 2019 17:48:46 +0000 Original-Received: from localhost ([127.0.0.1]:44883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhHSt-0005ig-S6 for submit@debbugs.gnu.org; Sat, 29 Jun 2019 13:48:46 -0400 Original-Received: from mo4-p00-ob.smtp.rzone.de ([85.215.255.25]:20893) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhHSr-0005iW-2h for 36370@debbugs.gnu.org; Sat, 29 Jun 2019 13:48:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1561830518; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=tcdPX/lsQ4mdwRf039gNRd9OEZp4iTKFtb5VAL3oGyE=; b=HqKe8loo4xSBWi4RBGW7lV2XL4+EOjsANsJNkakAA7A1uKPkP9MTG2jNzjkItFU2fx XdBXQgey3b1yDNVKQU4ZrNlCmrktGleeAPi0z20ctsYhf5XVcgbh4uF+M/J41yO/Invo Hi+StF0UHofZUlBZZQ4qHjFLs9va/17sq4NBPXIWpbU0y+7MA7m0xIDLKZOlekFm48Vb F48sa4qT/xzzL3evTA/6x+ltTep0LNi7THLPbde2VtJOviXCZd3/k64Nh1LIxmj1d8jH eXKjiOeJBdD6/H2oQXKlsxDuwpjlb2I1AFHgZFSH5CYX7ea6qLEkKThYvpjBquHxBAXL Kzvg== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOGaf0zJZW" X-RZG-CLASS-ID: mo00 Original-Received: from bruno.haible.de by smtp.strato.de (RZmta 44.24 DYNA|AUTH) with ESMTPSA id v018bcv5THmbmwQ (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Sat, 29 Jun 2019 19:48:37 +0200 (CEST) In-Reply-To: <99bacb9f-1192-1315-85d7-5ab4924dfef8@cs.ucla.edu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161837 gmane.comp.lib.gnulib.bugs:40601 Archived-At: Hi Paul, > > + If you want the use of this macro to improve, not deteriorate, > > + performance, R should not contain function calls except to functions > > + that are declared 'inline __attribute__((__always_inline__))'. */ > > A reader of that might incorrectly conclude that using such functions will > always improve performance, compared to using functions not declared that way. For functions not declared 'inline __attribute__((__always_inline__))', it depends on the inlining heuristics of the compiler whether the 'assume (R)' will be a performance improvement or the opposite. > Also, given Pip Cet's misunderstanding it'd be helpful to add a word or two > about the intent of 'assume (R)'. > > How about the attached patch? That's a good compromise. > > - evaluated. Behavior is undefined if R is false. */ > > + evaluated. The behavior is undefined if R is false. > > This is a nit, but to my ears the shorter version is better OK, fine. Bruno