From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#39293: [PATCH] Base bookmark-bmenu-mode on 'tabulated-list-mode' Date: Sat, 23 May 2020 14:26:17 -0700 (PDT) Message-ID: <323e521b-503b-4ed3-bd42-aa3707de37c1@default> References: <87lfpu9ag8.fsf@marxist.se> <87367qmm0l.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="4480"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Karl Fogel , 39293@debbugs.gnu.org To: Matthias Meulien , Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 23 23:29:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jcbhd-00013Y-27 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 May 2020 23:29:09 +0200 Original-Received: from localhost ([::1]:56514 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jcbhc-0001CW-53 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 May 2020 17:29:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35788) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jcbhW-0001Ak-2W for bug-gnu-emacs@gnu.org; Sat, 23 May 2020 17:29:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52559) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jcbhV-0005u4-PP for bug-gnu-emacs@gnu.org; Sat, 23 May 2020 17:29:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jcbhV-00061f-MT for bug-gnu-emacs@gnu.org; Sat, 23 May 2020 17:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 May 2020 21:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39293-submit@debbugs.gnu.org id=B39293.159026932323139 (code B ref 39293); Sat, 23 May 2020 21:29:01 +0000 Original-Received: (at 39293) by debbugs.gnu.org; 23 May 2020 21:28:43 +0000 Original-Received: from localhost ([127.0.0.1]:35872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcbgy-00060u-4o for submit@debbugs.gnu.org; Sat, 23 May 2020 17:28:43 -0400 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:38744) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcbgw-00060g-1O for 39293@debbugs.gnu.org; Sat, 23 May 2020 17:28:26 -0400 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 04NLMHD9079479; Sat, 23 May 2020 21:28:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=l08FgZdog6c0szuTYVvUsHlU2LlJaI2cKeYd6M2ANBA=; b=hx4bJerAr07o5EU5CTlsj9nXsTEhLSj6JJ4ClVCXvadt6xx4FtBojSif9fHk//MT5Ofl blDpVBL8t88Zu9tg6OO+XUs6fvwxANYK/Deo/7c/bcVvdlpPfMVzRA/MOBquZWo5TnQf sMsdeufdKqx6evyGeUVtYSot1ZwBqNbPwEZJX8emV/1W4IFT9Jk8cBIaWoeYx5BdReQl g1nW4GyJIgAzRghxvKTR3kWRtBc2klze2E1k7kwl8rqLZGXgYK3HSyOe3Vcy+FzqhgVi 1PcGoSNNrVtoqvdtsfL/sIatz62nQcv4Rk3RI0lCHIMC5ErdgiDrafha+I5cIHrb5jBY eA== Original-Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 316uskhgpy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 23 May 2020 21:28:20 +0000 Original-Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 04NLNLDK050108; Sat, 23 May 2020 21:26:19 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 316u5j3u70-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 23 May 2020 21:26:19 +0000 Original-Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 04NLQIb7029778; Sat, 23 May 2020 21:26:18 GMT In-Reply-To: <87367qmm0l.fsf@gmail.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5005.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9630 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2005230181 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9630 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 priorityscore=1501 clxscore=1011 impostorscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 cotscore=-2147483648 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2005230181 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180851 Archived-At: > > The attached patch changes bookmark-bmenu-mode to be based on > > tabulated-list-mode instead of special-mode. > > > > This allows us to simplify the code in several cases. In > > addition, we get many features for free, such as sorting columns > > by clicking on the column headers, changing size of columns. >=20 > Both features looks interesting to me. Thanks for working on that! >=20 > > In the future, this will obviously include any new feature added > > to 'tabulated-list-mode'. > > > > The only functional step backwards is that we no longer support > > the optional "inline" header line -- a bookmark.el-specific hack > > to have a header without using 'header-line-format'. I don't > > believe this feature is very useful since the lack of such > > support for anything similar in e.g. 'package-menu-mode' has not > > caused any problems. It seems to have been added together with > > 'header-line-format' as a fire escape if the latter caused any > > problems. Please don't do that. As I said earlier: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D39293#8 this is totally incompatible with the many enhancements I've made to bookmarks. It will force me to include the (former) bookmark.el code in Bookmark+, and separate the latter completely from bookmark.el. Until now, it's been a compatible extension. Tabulated-list mode is a step backward for any feature that offers more. Just because something is capable of displaying some info in columns, that doesn't mean it should be reduced to the limitations of t-l mode. Thinking that t-l mode is for all columnar presentations and interactions is akin to thinking that a soda straw is appropriate for an oil pipeline. This is serious for me. If you don't care, too bad for me, and for anyone who cares about Bookmark+ and compatibility with vanilla Emacs. > I am the one who introduced `header-line-format in bookmark.el > (7a78e19f24) and I confirm that I kept the legacy header "just in > case". The new behavior has been enabled by default since 2013, > and I've not heard any complaint. I would have complained about it. But I've been able to ignore it, because a "legacy header" is still supported. Enabled only by default means that hearing no complaints signifies nothing. If a user option is provided to let users NOT have tabulated-list display imposed, and let them continue as before, then fine. Otherwise I'll be forced to fork, I'm afraid.